From 1b6fb7de44900ec15d54e26182f4b6d747757a87 Mon Sep 17 00:00:00 2001 From: hduelme Date: Wed, 25 Jan 2023 21:46:32 +0100 Subject: [PATCH] Use a more efficient conversion from ByteArrayOutputStream to String. Resolves #1324. --- .../ws/transport/jms/TextMessageOutputStream.java | 2 +- .../springframework/ws/transport/xmpp/MessageOutputStream.java | 2 +- .../ws/transport/jms/JmsMessageSenderIntegrationTest.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-ws-support/src/main/java/org/springframework/ws/transport/jms/TextMessageOutputStream.java b/spring-ws-support/src/main/java/org/springframework/ws/transport/jms/TextMessageOutputStream.java index 00fcb124..15c2214a 100644 --- a/spring-ws-support/src/main/java/org/springframework/ws/transport/jms/TextMessageOutputStream.java +++ b/spring-ws-support/src/main/java/org/springframework/ws/transport/jms/TextMessageOutputStream.java @@ -50,7 +50,7 @@ class TextMessageOutputStream extends FilterOutputStream { super.flush(); try { ByteArrayOutputStream baos = (ByteArrayOutputStream) out; - String text = new String(baos.toByteArray(), encoding); + String text = baos.toString(encoding); message.setText(text); } catch (JMSException ex) { throw new JmsTransportException(ex); diff --git a/spring-ws-support/src/main/java/org/springframework/ws/transport/xmpp/MessageOutputStream.java b/spring-ws-support/src/main/java/org/springframework/ws/transport/xmpp/MessageOutputStream.java index ff5b418a..67a45650 100644 --- a/spring-ws-support/src/main/java/org/springframework/ws/transport/xmpp/MessageOutputStream.java +++ b/spring-ws-support/src/main/java/org/springframework/ws/transport/xmpp/MessageOutputStream.java @@ -48,7 +48,7 @@ class MessageOutputStream extends FilterOutputStream { public void flush() throws IOException { super.flush(); ByteArrayOutputStream bos = (ByteArrayOutputStream) out; - String text = new String(bos.toByteArray(), encoding); + String text = bos.toString(encoding); message.setBody(text); } } diff --git a/spring-ws-support/src/test/java/org/springframework/ws/transport/jms/JmsMessageSenderIntegrationTest.java b/spring-ws-support/src/test/java/org/springframework/ws/transport/jms/JmsMessageSenderIntegrationTest.java index 72251a18..c9209889 100644 --- a/spring-ws-support/src/test/java/org/springframework/ws/transport/jms/JmsMessageSenderIntegrationTest.java +++ b/spring-ws-support/src/test/java/org/springframework/ws/transport/jms/JmsMessageSenderIntegrationTest.java @@ -171,7 +171,7 @@ public class JmsMessageSenderIntegrationTest { ByteArrayOutputStream bos = new ByteArrayOutputStream(); messageFactory.createMessage().writeTo(bos); - final String text = new String(bos.toByteArray(), StandardCharsets.UTF_8); + final String text = bos.toString(StandardCharsets.UTF_8); jmsTemplate.send(request.getJMSReplyTo(), session -> {