diff --git a/spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/MethodEndpoint.java b/spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/MethodEndpoint.java index f67f5ccb..1951a3e3 100644 --- a/spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/MethodEndpoint.java +++ b/spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/MethodEndpoint.java @@ -156,8 +156,7 @@ public final class MethodEndpoint { if (this == o) { return true; } - if (o instanceof MethodEndpoint) { - MethodEndpoint other = (MethodEndpoint) o; + if (o instanceof MethodEndpoint other) { return this.bean.equals(other.bean) && this.method.equals(other.method); } return false; diff --git a/spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/adapter/XPathParamAnnotationMethodEndpointAdapter.java b/spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/adapter/XPathParamAnnotationMethodEndpointAdapter.java index 67c4df8e..163126b4 100644 --- a/spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/adapter/XPathParamAnnotationMethodEndpointAdapter.java +++ b/spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/adapter/XPathParamAnnotationMethodEndpointAdapter.java @@ -127,8 +127,7 @@ public class XPathParamAnnotationMethodEndpointAdapter extends AbstractMethodEnd Element payloadElement = getRootElement(messageContext.getRequest().getPayloadSource()); Object[] args = getMethodArguments(payloadElement, methodEndpoint.getMethod()); Object result = methodEndpoint.invoke(args); - if (result instanceof Source) { - Source responseSource = (Source) result; + if (result instanceof Source responseSource) { WebServiceMessage response = messageContext.getResponse(); transform(responseSource, response.getPayloadResult()); } diff --git a/spring-ws-core/src/main/java/org/springframework/ws/soap/addressing/core/EndpointReference.java b/spring-ws-core/src/main/java/org/springframework/ws/soap/addressing/core/EndpointReference.java index e17625cb..d929f4e6 100644 --- a/spring-ws-core/src/main/java/org/springframework/ws/soap/addressing/core/EndpointReference.java +++ b/spring-ws-core/src/main/java/org/springframework/ws/soap/addressing/core/EndpointReference.java @@ -90,8 +90,7 @@ public final class EndpointReference implements Serializable { if (this == o) { return true; } - if (o instanceof EndpointReference) { - EndpointReference other = (EndpointReference) o; + if (o instanceof EndpointReference other) { return address.equals(other.address); } return false; diff --git a/spring-ws-security/src/main/java/org/springframework/ws/soap/security/wss4j2/Wss4jSecurityInterceptor.java b/spring-ws-security/src/main/java/org/springframework/ws/soap/security/wss4j2/Wss4jSecurityInterceptor.java index 93ef8bab..f370b068 100644 --- a/spring-ws-security/src/main/java/org/springframework/ws/soap/security/wss4j2/Wss4jSecurityInterceptor.java +++ b/spring-ws-security/src/main/java/org/springframework/ws/soap/security/wss4j2/Wss4jSecurityInterceptor.java @@ -852,8 +852,7 @@ public class Wss4jSecurityInterceptor extends AbstractWsSecurityInterceptor impl if (!CollectionUtils.isEmpty(results)) { WSSecurityEngineResult actionResult = results.get(0); Principal principal = (Principal) actionResult.get(WSSecurityEngineResult.TAG_PRINCIPAL); - if (principal instanceof WSUsernameTokenPrincipalImpl) { - WSUsernameTokenPrincipalImpl usernameTokenPrincipal = (WSUsernameTokenPrincipalImpl) principal; + if (principal instanceof WSUsernameTokenPrincipalImpl usernameTokenPrincipal) { UsernameTokenPrincipalCallback callback = new UsernameTokenPrincipalCallback(usernameTokenPrincipal); try { validationCallbackHandler.handle(new Callback[] { callback }); diff --git a/spring-xml/src/main/java/org/springframework/xml/namespace/QNameEditor.java b/spring-xml/src/main/java/org/springframework/xml/namespace/QNameEditor.java index a3053960..e367c51f 100644 --- a/spring-xml/src/main/java/org/springframework/xml/namespace/QNameEditor.java +++ b/spring-xml/src/main/java/org/springframework/xml/namespace/QNameEditor.java @@ -62,10 +62,7 @@ public class QNameEditor extends PropertyEditorSupport { @Override public String getAsText() { Object value = getValue(); - if (!(value instanceof QName)) { - return ""; - } else { - QName qName = (QName) value; + if (value instanceof QName qName) { String prefix = qName.getPrefix(); if (StringUtils.hasLength(qName.getNamespaceURI()) && StringUtils.hasLength(prefix)) { return "{" + qName.getNamespaceURI() + "}" + prefix + ":" + qName.getLocalPart(); @@ -74,6 +71,8 @@ public class QNameEditor extends PropertyEditorSupport { } else { return qName.getLocalPart(); } + } else { + return ""; } } }