From 047b3bf65dadb1d30670c2609103b89c32c14a97 Mon Sep 17 00:00:00 2001 From: Andy Wilkinson Date: Tue, 8 Dec 2015 17:22:53 +0000 Subject: [PATCH] Remove feedback required label when closing due to overdue feedback --- .../io/spring/issuebot/feedback/StandardFeedbackListener.java | 1 + .../spring/issuebot/feedback/StandardFeedbackListenerTests.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/main/java/io/spring/issuebot/feedback/StandardFeedbackListener.java b/src/main/java/io/spring/issuebot/feedback/StandardFeedbackListener.java index 9212637..a4633f8 100644 --- a/src/main/java/io/spring/issuebot/feedback/StandardFeedbackListener.java +++ b/src/main/java/io/spring/issuebot/feedback/StandardFeedbackListener.java @@ -67,6 +67,7 @@ final class StandardFeedbackListener implements FeedbackListener { private void close(Issue issue) { this.gitHub.addComment(issue, this.closeComment); this.gitHub.close(issue); + this.gitHub.removeLabel(issue, this.requiredLabel); } private void remind(Issue issue) { diff --git a/src/test/java/io/spring/issuebot/feedback/StandardFeedbackListenerTests.java b/src/test/java/io/spring/issuebot/feedback/StandardFeedbackListenerTests.java index 5112c17..f97135e 100644 --- a/src/test/java/io/spring/issuebot/feedback/StandardFeedbackListenerTests.java +++ b/src/test/java/io/spring/issuebot/feedback/StandardFeedbackListenerTests.java @@ -64,6 +64,8 @@ public class StandardFeedbackListenerTests { public void feedbackRequiredAndOverdue() { this.listener.feedbackRequired(this.issue, OffsetDateTime.now().minusDays(15)); verify(this.gitHub).addComment(this.issue, "closing"); + verify(this.gitHub).close(this.issue); + verify(this.gitHub).removeLabel(this.issue, "required"); } }