SpringCloud/issue-bot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Ignore own comments when determining if feedback has been provided

Browse Source
This commit is contained in:
Andy Wilkinson
2015-12-09 17:38:12 +00:00
parent a4266ef86c
commit 8519bc4a78
3 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/test/java/io/spring/issuebot/feedback/FeedbackIssueListenerTests.java
View File

@@ -48,7 +48,7 @@ public class FeedbackIssueListenerTests {
private final FeedbackListener feedbackListener = mock(FeedbackListener.class);
private final IssueListener listener = new FeedbackIssueListener(this.gitHub,
"required", Arrays.asList("Amy", "Brian"), this.feedbackListener);
"required", Arrays.asList("Amy", "Brian"), "IssueBot", this.feedbackListener);
@Test
public void pullRequestsAreIgnored() {
@@ -123,6 +123,21 @@ public class FeedbackIssueListenerTests {
verify(this.feedbackListener).feedbackRequired(issue, requestTime);
}
@Test
public void feedbackRequiredAfterCommentFromIssueBot() {
Issue issue = new Issue(null, null, null, null, null,
Arrays.asList(new Label("required")), null, null);
OffsetDateTime requestTime = OffsetDateTime.now().minusDays(1);
given(this.gitHub.getEvents(issue)).willReturn(new StandardPage<>(
Arrays.asList(new Event("labeled", requestTime, new Label("required"))),
() -> null));
given(this.gitHub.getComments(issue)).willReturn(new StandardPage<>(
Arrays.asList(new Comment(new User("IssueBot"), OffsetDateTime.now())),
() -> null));
this.listener.onOpenIssue(issue);
verify(this.feedbackListener).feedbackRequired(issue, requestTime);
}
@Test
public void issueWithNoMatchingLabeledEventIsIgnored() {
Issue issue = new Issue(null, null, null, null, null,