From 4d874c77c1dea91cf664b4aa306d269d19a6d5d6 Mon Sep 17 00:00:00 2001 From: Spring Operator Date: Wed, 20 Mar 2019 15:37:17 -0500 Subject: [PATCH] URL Cleanup This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * [ ] http://myfiles/app.jar (UnknownHostException) with 1 occurrences migrated to: https://myfiles/app.jar ([https](https://myfiles/app.jar) result UnknownHostException). * [ ] http://myfiles/app1.jar (UnknownHostException) with 5 occurrences migrated to: https://myfiles/app1.jar ([https](https://myfiles/app1.jar) result UnknownHostException). * [ ] http://myfiles/app2.jar (UnknownHostException) with 5 occurrences migrated to: https://myfiles/app2.jar ([https](https://myfiles/app2.jar) result UnknownHostException). ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html with 1 occurrences migrated to: https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html ([https](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) result 200). * [ ] http://contributor-covenant.org with 1 occurrences migrated to: https://contributor-covenant.org ([https](https://contributor-covenant.org) result 301). * [ ] http://contributor-covenant.org/version/1/3/0/ with 1 occurrences migrated to: https://contributor-covenant.org/version/1/3/0/ ([https](https://contributor-covenant.org/version/1/3/0/) result 301). * [ ] http://plugins.jetbrains.com/plugin/6546 with 1 occurrences migrated to: https://plugins.jetbrains.com/plugin/6546 ([https](https://plugins.jetbrains.com/plugin/6546) result 301). # Ignored These URLs were intentionally ignored. * http://localhost with 9 occurrences * http://localhost/v2 with 1 occurrences * http://localhost/v3 with 1 occurrences * http://localhost:8888 with 4 occurrences --- CODE_OF_CONDUCT.adoc | 2 +- CONTRIBUTING.adoc | 4 ++-- .../appbroker/deployer/BackingAppDeploymentServiceTest.java | 4 ++-- .../appbroker/manager/BackingAppManagementServiceTest.java | 4 ++-- .../AppDeploymentCreateServiceInstanceWorkflowTest.java | 4 ++-- .../AppDeploymentDeleteServiceInstanceWorkflowTest.java | 4 ++-- .../workflow/instance/AppDeploymentInstanceWorkflowTest.java | 2 +- .../AppDeploymentUpdateServiceInstanceWorkflowTest.java | 4 ++-- 8 files changed, 14 insertions(+), 14 deletions(-) diff --git a/CODE_OF_CONDUCT.adoc b/CODE_OF_CONDUCT.adoc index 86596e2..e40132f 100644 --- a/CODE_OF_CONDUCT.adoc +++ b/CODE_OF_CONDUCT.adoc @@ -24,4 +24,4 @@ Instances of abusive, harassing, or otherwise unacceptable behavior may be repor All complaints will be reviewed and investigated and will result in a response that is deemed necessary and appropriate to the circumstances. Maintainers are obligated to maintain confidentiality with regard to the reporter of an incident. -This Code of Conduct is adapted from the http://contributor-covenant.org[Contributor Covenant], version 1.3.0, available at http://contributor-covenant.org/version/1/3/0/[contributor-covenant.org/version/1/3/0/]. +This Code of Conduct is adapted from the https://contributor-covenant.org[Contributor Covenant], version 1.3.0, available at https://contributor-covenant.org/version/1/3/0/[contributor-covenant.org/version/1/3/0/]. diff --git a/CONTRIBUTING.adoc b/CONTRIBUTING.adoc index 5057d60..32f7d0e 100644 --- a/CONTRIBUTING.adoc +++ b/CONTRIBUTING.adoc @@ -28,7 +28,7 @@ added after the original pull request but before a merge. `eclipse-code-formatter.xml` file from the https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/master/spring-cloud-dependencies-parent/eclipse-code-formatter.xml[Spring Cloud Build] project. If using IntelliJ, you can use the - http://plugins.jetbrains.com/plugin/6546[Eclipse Code Formatter + https://plugins.jetbrains.com/plugin/6546[Eclipse Code Formatter Plugin] to import the same file. * Make sure all new `.java` files to have a simple Javadoc class comment with at least an `@author` tag identifying you, and preferably at least a paragraph on what the class is @@ -41,7 +41,7 @@ added after the original pull request but before a merge. * A few unit tests would help a lot as well -- someone has to do it. * If no-one else is using your branch, please rebase it against the current master (or other target branch in the main project). -* When writing a commit message please follow http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html[these conventions], +* When writing a commit message please follow https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html[these conventions], if you are fixing an existing issue please add `Fixes gh-XXXX` at the end of the commit message (where XXXX is the issue number). diff --git a/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/deployer/BackingAppDeploymentServiceTest.java b/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/deployer/BackingAppDeploymentServiceTest.java index 416fec8..5521f52 100644 --- a/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/deployer/BackingAppDeploymentServiceTest.java +++ b/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/deployer/BackingAppDeploymentServiceTest.java @@ -28,11 +28,11 @@ class BackingAppDeploymentServiceTest { backingApps = BackingApplications.builder() .backingApplication(BackingApplication.builder() .name("testApp1") - .path("http://myfiles/app1.jar") + .path("https://myfiles/app1.jar") .build()) .backingApplication(BackingApplication.builder() .name("testApp2") - .path("http://myfiles/app2.jar") + .path("https://myfiles/app2.jar") .build()) .build(); } diff --git a/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/manager/BackingAppManagementServiceTest.java b/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/manager/BackingAppManagementServiceTest.java index 7313f87..093f8db 100644 --- a/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/manager/BackingAppManagementServiceTest.java +++ b/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/manager/BackingAppManagementServiceTest.java @@ -63,11 +63,11 @@ class BackingAppManagementServiceTest { this.backingApps = BackingApplications.builder() .backingApplication(BackingApplication.builder() .name("testApp1") - .path("http://myfiles/app1.jar") + .path("https://myfiles/app1.jar") .build()) .backingApplication(BackingApplication.builder() .name("testApp2") - .path("http://myfiles/app2.jar") + .path("https://myfiles/app2.jar") .build()) .build(); diff --git a/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentCreateServiceInstanceWorkflowTest.java b/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentCreateServiceInstanceWorkflowTest.java index e5c1ac8..2c08883 100644 --- a/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentCreateServiceInstanceWorkflowTest.java +++ b/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentCreateServiceInstanceWorkflowTest.java @@ -87,12 +87,12 @@ class AppDeploymentCreateServiceInstanceWorkflowTest { .backingApplication(BackingApplication .builder() .name("app1") - .path("http://myfiles/app1.jar") + .path("https://myfiles/app1.jar") .build()) .backingApplication(BackingApplication .builder() .name("app2") - .path("http://myfiles/app2.jar") + .path("https://myfiles/app2.jar") .build()) .build(); diff --git a/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentDeleteServiceInstanceWorkflowTest.java b/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentDeleteServiceInstanceWorkflowTest.java index 1551ff8..14d8c9a 100644 --- a/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentDeleteServiceInstanceWorkflowTest.java +++ b/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentDeleteServiceInstanceWorkflowTest.java @@ -74,12 +74,12 @@ class AppDeploymentDeleteServiceInstanceWorkflowTest { .backingApplication(BackingApplication .builder() .name("app1") - .path("http://myfiles/app1.jar") + .path("https://myfiles/app1.jar") .build()) .backingApplication(BackingApplication .builder() .name("app2") - .path("http://myfiles/app2.jar") + .path("https://myfiles/app2.jar") .build()) .build(); diff --git a/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentInstanceWorkflowTest.java b/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentInstanceWorkflowTest.java index bfbe20f..9c5c6ab 100644 --- a/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentInstanceWorkflowTest.java +++ b/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentInstanceWorkflowTest.java @@ -38,7 +38,7 @@ class AppDeploymentInstanceWorkflowTest { backingApps = BackingApplications.builder() .backingApplication(BackingApplication.builder() .name("app1") - .path("http://myfiles/app.jar") + .path("https://myfiles/app.jar") .build()) .build(); diff --git a/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentUpdateServiceInstanceWorkflowTest.java b/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentUpdateServiceInstanceWorkflowTest.java index f52fda8..df30660 100644 --- a/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentUpdateServiceInstanceWorkflowTest.java +++ b/spring-cloud-app-broker-core/src/test/java/org/springframework/cloud/appbroker/workflow/instance/AppDeploymentUpdateServiceInstanceWorkflowTest.java @@ -81,11 +81,11 @@ class AppDeploymentUpdateServiceInstanceWorkflowTest { .builder() .backingApplication(BackingApplication.builder() .name("app1") - .path("http://myfiles/app1.jar") + .path("https://myfiles/app1.jar") .build()) .backingApplication(BackingApplication.builder() .name("app2") - .path("http://myfiles/app2.jar") + .path("https://myfiles/app2.jar") .build()) .build();