diff --git a/src/main/java/org/springframework/cloud/bindings/boot/OracleBindingsPropertiesProcessor.java b/src/main/java/org/springframework/cloud/bindings/boot/OracleBindingsPropertiesProcessor.java index b4f829c..11fe915 100644 --- a/src/main/java/org/springframework/cloud/bindings/boot/OracleBindingsPropertiesProcessor.java +++ b/src/main/java/org/springframework/cloud/bindings/boot/OracleBindingsPropertiesProcessor.java @@ -25,6 +25,8 @@ import java.util.Map; /** * An implementation of {@link BindingsPropertiesProcessor} that detects {@link Binding}s of kind: {@value KIND}. + * + * @see JDBC URL Format */ public final class OracleBindingsPropertiesProcessor implements BindingsPropertiesProcessor { @@ -40,9 +42,8 @@ public final class OracleBindingsPropertiesProcessor implements BindingsProperti properties.put("spring.datasource.driver-class-name", "oracle.jdbc.OracleDriver"); properties.put("spring.datasource.password", secret.get("password")); - properties.put("spring.datasource.url", String.format("jdbc:oracle://%s:%s/%s?user=%s&password=%s", - secret.get("host"), secret.get("port"), secret.get("db"), secret.get("username"), - secret.get("password"))); + properties.put("spring.datasource.url", String.format("jdbc:oracle://%s:%s/%s", + secret.get("host"), secret.get("port"), secret.get("database"))); properties.put("spring.datasource.username", secret.get("username")); }); } diff --git a/src/test/java/org/springframework/cloud/bindings/boot/Db2BindingsPropertiesProcessorTest.java b/src/test/java/org/springframework/cloud/bindings/boot/Db2BindingsPropertiesProcessorTest.java index be1c2c7..7df433e 100644 --- a/src/test/java/org/springframework/cloud/bindings/boot/Db2BindingsPropertiesProcessorTest.java +++ b/src/test/java/org/springframework/cloud/bindings/boot/Db2BindingsPropertiesProcessorTest.java @@ -52,8 +52,7 @@ final class Db2BindingsPropertiesProcessorTest { assertThat(properties) .containsEntry("spring.datasource.driver-class-name", "com.ibm.db2.jcc.DB2Driver") .containsEntry("spring.datasource.password", "test-password") - .containsEntry("spring.datasource.url", - "jdbc:db2://test-host:test-port/test-database") + .containsEntry("spring.datasource.url", "jdbc:db2://test-host:test-port/test-database") .containsEntry("spring.datasource.username", "test-username"); } diff --git a/src/test/java/org/springframework/cloud/bindings/boot/OracleBindingsPropertiesProcessorTest.java b/src/test/java/org/springframework/cloud/bindings/boot/OracleBindingsPropertiesProcessorTest.java index 262fdb6..1968f3c 100644 --- a/src/test/java/org/springframework/cloud/bindings/boot/OracleBindingsPropertiesProcessorTest.java +++ b/src/test/java/org/springframework/cloud/bindings/boot/OracleBindingsPropertiesProcessorTest.java @@ -41,7 +41,7 @@ final class OracleBindingsPropertiesProcessorTest { new Binding("test-name", Paths.get("test-path"), Collections.singletonMap("kind", KIND), new FluentMap() - .withEntry("db", "test-db") + .withEntry("database", "test-database") .withEntry("host", "test-host") .withEntry("password", "test-password") .withEntry("port", "test-port") @@ -52,8 +52,7 @@ final class OracleBindingsPropertiesProcessorTest { assertThat(properties) .containsEntry("spring.datasource.driver-class-name", "oracle.jdbc.OracleDriver") .containsEntry("spring.datasource.password", "test-password") - .containsEntry("spring.datasource.url", - "jdbc:oracle://test-host:test-port/test-db?user=test-username&password=test-password") + .containsEntry("spring.datasource.url", "jdbc:oracle://test-host:test-port/test-database") .containsEntry("spring.datasource.username", "test-username"); }