SpringCloud/spring-cloud-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Uningnored some tests to do with binding to lists

Browse Source 
See https://github.com/spring-projects/spring-boot/issues/9137
This commit is contained in:
Dave Syer
2017-05-14 11:06:33 +01:00
parent ac9d609a27
commit 021a77d997
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-cloud-context/src/test/java/org/springframework/cloud/context/properties/ConfigurationPropertiesRebinderListIntegrationTests.java
View File

@@ -58,13 +58,12 @@ public class ConfigurationPropertiesRebinderListIntegrationTests {
private ConfigurableEnvironment environment;
@Test
@Ignore // TODO: reinstate this if possible see https://github.com/spring-projects/spring-boot/issues/9137
@DirtiesContext
public void testAppendProperties() throws Exception {
assertEquals("[one, two]", this.properties.getMessages().toString());
EnvironmentTestUtils.addEnvironment(this.environment, "messages[0]:foo");
this.rebinder.rebind();
assertEquals("[foo, two]", this.properties.getMessages().toString());
assertEquals("[foo]", this.properties.getMessages().toString());
}
@Test
@@ -91,7 +90,6 @@ public class ConfigurationPropertiesRebinderListIntegrationTests {
}
@Test
@Ignore // TODO: reinstate this if possible see https://github.com/spring-projects/spring-boot/issues/9137
@DirtiesContext
public void testReplacePropertiesWithCommaSeparated() throws Exception {
assertEquals("[one, two]", this.properties.getMessages().toString());

4
spring-cloud-context/src/test/java/org/springframework/cloud/context/scope/refresh/RefreshScopeListBindingIntegrationTests.java
View File

@@ -20,7 +20,6 @@ import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -61,14 +60,13 @@ public class RefreshScopeListBindingIntegrationTests {
private ConfigurableEnvironment environment;
@Test
@Ignore // TODO: reinstate this if possible https://github.com/spring-projects/spring-boot/issues/9137
@DirtiesContext
public void testAppendProperties() throws Exception {
assertEquals("[one, two]", this.properties.getMessages().toString());
assertTrue(this.properties instanceof Advised);
EnvironmentTestUtils.addEnvironment(this.environment, "test.messages[0]:foo");
this.scope.refreshAll();
assertEquals("[foo, two]", this.properties.getMessages().toString());
assertEquals("[foo]", this.properties.getMessages().toString());
}
@Test