diff --git a/docs/pom.xml b/docs/pom.xml index 925416d3..b224296f 100644 --- a/docs/pom.xml +++ b/docs/pom.xml @@ -54,29 +54,13 @@ exec-maven-plugin - generate-metrics-metadata + generate-docs prepare-package java - io.micrometer.docs.metrics.DocsFromSources - true - - ${micrometer-docs-generator.inputPath} - ${micrometer-docs-generator.inclusionPattern} - ${micrometer-docs-generator.outputPath} - - - - - generate-tracing-metadata - prepare-package - - java - - - io.micrometer.docs.spans.DocsFromSources + io.micrometer.docs.DocsGeneratorCommand true ${micrometer-docs-generator.inputPath} @@ -88,11 +72,9 @@ - io.micrometer - + io.micrometer micrometer-docs-generator - ${micrometer-docs-generator.version} - + ${micrometer-docs-generator.version} jar diff --git a/spring-cloud-commons/src/main/java/org/springframework/cloud/client/circuitbreaker/observation/CircuitBreakerObservationDocumentation.java b/spring-cloud-commons/src/main/java/org/springframework/cloud/client/circuitbreaker/observation/CircuitBreakerObservationDocumentation.java index 8b062619..773e63e5 100644 --- a/spring-cloud-commons/src/main/java/org/springframework/cloud/client/circuitbreaker/observation/CircuitBreakerObservationDocumentation.java +++ b/spring-cloud-commons/src/main/java/org/springframework/cloud/client/circuitbreaker/observation/CircuitBreakerObservationDocumentation.java @@ -42,10 +42,6 @@ enum CircuitBreakerObservationDocumentation implements ObservationDocumentation return "spring.cloud.circuitbreaker"; } - @Override - public String getContextualName() { - return "circuit-breaker"; - } }, /** @@ -68,10 +64,6 @@ enum CircuitBreakerObservationDocumentation implements ObservationDocumentation return "spring.cloud.circuitbreaker"; } - @Override - public String getContextualName() { - return "circuit-breaker fallback"; - } }; public enum LowCardinalityTags implements KeyName { diff --git a/spring-cloud-commons/src/main/java/org/springframework/cloud/client/circuitbreaker/observation/DefaultCircuitBreakerObservationConvention.java b/spring-cloud-commons/src/main/java/org/springframework/cloud/client/circuitbreaker/observation/DefaultCircuitBreakerObservationConvention.java index 60368cc3..99cae778 100644 --- a/spring-cloud-commons/src/main/java/org/springframework/cloud/client/circuitbreaker/observation/DefaultCircuitBreakerObservationConvention.java +++ b/spring-cloud-commons/src/main/java/org/springframework/cloud/client/circuitbreaker/observation/DefaultCircuitBreakerObservationConvention.java @@ -44,4 +44,12 @@ public class DefaultCircuitBreakerObservationConvention implements CircuitBreake return "spring.cloud.circuitbreaker"; } + @Override + public String getContextualName(CircuitBreakerObservationContext context) { + if (context.getType() == CircuitBreakerObservationContext.Type.SUPPLIER) { + return "circuit-breaker"; + } + return "circuit-breaker fallback"; + } + }