SpringCloud/spring-cloud-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes DefaultOkHttpClientFactoryTest to not use reflection

Browse Source
This commit is contained in:
spencergibb
2022-02-24 13:54:37 -05:00
parent 76d522c125
commit 7817046f77
1 changed files with 5 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
spring-cloud-commons/src/test/java/org/springframework/cloud/commons/httpclient/DefaultOkHttpClientFactoryTest.java
View File

@@ -16,17 +16,12 @@
package org.springframework.cloud.commons.httpclient; package org.springframework.cloud.commons.httpclient;
import java.lang.reflect.Field;
import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeUnit;
import javax.net.ssl.HostnameVerifier;
import okhttp3.ConnectionPool; import okhttp3.ConnectionPool;
import okhttp3.OkHttpClient; import okhttp3.OkHttpClient;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.springframework.util.ReflectionUtils;
import static org.assertj.core.api.BDDAssertions.then; import static org.assertj.core.api.BDDAssertions.then;
/** /**
@@ -41,23 +36,11 @@ public class DefaultOkHttpClientFactoryTest {
ConnectionPool pool = poolFactory.create(4, 5, TimeUnit.DAYS); ConnectionPool pool = poolFactory.create(4, 5, TimeUnit.DAYS);
OkHttpClient httpClient = okHttpClientFactory.createBuilder(true).connectTimeout(2, TimeUnit.MILLISECONDS) OkHttpClient httpClient = okHttpClientFactory.createBuilder(true).connectTimeout(2, TimeUnit.MILLISECONDS)
.readTimeout(3, TimeUnit.HOURS).followRedirects(true).connectionPool(pool).build(); .readTimeout(3, TimeUnit.HOURS).followRedirects(true).connectionPool(pool).build();
int connectTimeout = getField(httpClient, "connectTimeout"); then(httpClient.connectTimeoutMillis()).isEqualTo(2);
then(connectTimeout).isEqualTo(2); then(httpClient.readTimeoutMillis()).isEqualTo(TimeUnit.HOURS.toMillis(3));
int readTimeout = getField(httpClient, "readTimeout"); then(httpClient.followRedirects()).isTrue();
then(readTimeout).isEqualTo(TimeUnit.HOURS.toMillis(3)); then(httpClient.connectionPool()).isEqualTo(pool);
boolean followRedirects = getField(httpClient, "followRedirects"); then(OkHttpClientFactory.TrustAllHostnames.class.isInstance(httpClient.hostnameVerifier())).isTrue();
then(followRedirects).isTrue();
ConnectionPool poolFromClient = getField(httpClient, "connectionPool");
then(poolFromClient).isEqualTo(pool);
HostnameVerifier hostnameVerifier = getField(httpClient, "hostnameVerifier");
then(OkHttpClientFactory.TrustAllHostnames.class.isInstance(hostnameVerifier)).isTrue();
}
protected <T> T getField(Object target, String name) {
Field field = ReflectionUtils.findField(target.getClass(), name);
ReflectionUtils.makeAccessible(field);
Object value = ReflectionUtils.getField(field, target);
return (T) value;
} }
} }