From c44c28dcadae42c0370f3a44a95bfe90be569c74 Mon Sep 17 00:00:00 2001 From: Spencer Gibb Date: Fri, 4 Aug 2017 12:41:21 -0600 Subject: [PATCH] polish --- ...ultApacheHttpClientConnectionManagerFactoryTests.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/spring-cloud-commons/src/test/java/org/springframework/cloud/commons/httpclient/DefaultApacheHttpClientConnectionManagerFactoryTests.java b/spring-cloud-commons/src/test/java/org/springframework/cloud/commons/httpclient/DefaultApacheHttpClientConnectionManagerFactoryTests.java index 4b2f535b..2544f6ca 100644 --- a/spring-cloud-commons/src/test/java/org/springframework/cloud/commons/httpclient/DefaultApacheHttpClientConnectionManagerFactoryTests.java +++ b/spring-cloud-commons/src/test/java/org/springframework/cloud/commons/httpclient/DefaultApacheHttpClientConnectionManagerFactoryTests.java @@ -2,6 +2,7 @@ package org.springframework.cloud.commons.httpclient; import java.lang.reflect.Field; import java.util.concurrent.TimeUnit; + import org.apache.http.conn.HttpClientConnectionManager; import org.apache.http.impl.conn.PoolingHttpClientConnectionManager; import org.junit.Test; @@ -9,7 +10,6 @@ import org.springframework.util.ReflectionUtils; import static org.junit.Assert.assertEquals; - /** * @author Ryan Baxter */ @@ -22,8 +22,7 @@ public class DefaultApacheHttpClientConnectionManagerFactoryTests { .getDefaultMaxPerRoute()); assertEquals(2, ((PoolingHttpClientConnectionManager) connectionManager).getMaxTotal()); - Object pool = getField(((PoolingHttpClientConnectionManager) connectionManager), - "pool"); + Object pool = getField((connectionManager), "pool"); assertEquals(-1l, ((Long)getField(pool, "timeToLive")).longValue()); TimeUnit timeUnit = getField(pool, "tunit"); assertEquals(TimeUnit.MILLISECONDS, timeUnit); @@ -37,13 +36,13 @@ public class DefaultApacheHttpClientConnectionManagerFactoryTests { .getDefaultMaxPerRoute()); assertEquals(2, ((PoolingHttpClientConnectionManager) connectionManager).getMaxTotal()); - Object pool = getField(((PoolingHttpClientConnectionManager) connectionManager), - "pool"); + Object pool = getField((connectionManager), "pool"); assertEquals(56l, ((Long)getField(pool, "timeToLive")).longValue()); TimeUnit timeUnit = getField(pool, "tunit"); assertEquals(TimeUnit.DAYS, timeUnit); } + @SuppressWarnings("unchecked") protected T getField(Object target, String name) { Field field = ReflectionUtils.findField(target.getClass(), name); ReflectionUtils.makeAccessible(field);