From f70b006b320b1e822c971f2192d3148543741db4 Mon Sep 17 00:00:00 2001
From: jizhuozhi <1218060852@qq.com>
Date: Fri, 11 Mar 2022 19:50:13 +0800
Subject: [PATCH] Remove unnecessary sign check, whether positive or negative
 (#1078)

---
 .../core/RoundRobinLoadBalancerTest.java      | 23 ++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/spring-cloud-loadbalancer/src/test/java/org/springframework/cloud/loadbalancer/core/RoundRobinLoadBalancerTest.java b/spring-cloud-loadbalancer/src/test/java/org/springframework/cloud/loadbalancer/core/RoundRobinLoadBalancerTest.java
index 20a1bb89..3482ea82 100644
--- a/spring-cloud-loadbalancer/src/test/java/org/springframework/cloud/loadbalancer/core/RoundRobinLoadBalancerTest.java
+++ b/spring-cloud-loadbalancer/src/test/java/org/springframework/cloud/loadbalancer/core/RoundRobinLoadBalancerTest.java
@@ -26,6 +26,7 @@ import org.springframework.cloud.client.ServiceInstance;
 import org.springframework.cloud.loadbalancer.support.SimpleObjectProvider;
 
 import static java.lang.Integer.MAX_VALUE;
+import static java.lang.Integer.MIN_VALUE;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.mock;
@@ -37,7 +38,22 @@ import static org.mockito.Mockito.when;
 class RoundRobinLoadBalancerTest {
 
 	@Test
-	void shouldEnforceOrderWhenPositiveOverflow() {
+	void shouldOrderEnforcedWhenPositive() {
+		assertOrderEnforced(0);
+	}
+
+	@Test
+	void shouldOrderEnforcedWhenNegative() {
+		assertOrderEnforced(MIN_VALUE);
+	}
+
+	@Test
+	void shouldOrderEnforcedWhenPositiveOverflow() {
+		assertOrderEnforced(MAX_VALUE);
+	}
+
+	@SuppressWarnings("all")
+	void assertOrderEnforced(int seed) {
 		List<ServiceInstance> instances = new ArrayList<>();
 		for (int i = 0; i < 10; i++) {
 			ServiceInstance instance = mock(ServiceInstance.class);
@@ -49,11 +65,12 @@ class RoundRobinLoadBalancerTest {
 		when(supplier.get(any())).thenReturn(Flux.just(instances));
 
 		RoundRobinLoadBalancer loadBalancer = new RoundRobinLoadBalancer(new SimpleObjectProvider<>(supplier),
-				"shouldStartFromZeroWhenPositiveOverflow", MAX_VALUE);
+				"shouldStartFromZeroWhenPositiveOverflow", seed);
 
 		for (int i = 0; i < 10; i++) {
+			int instanceId = ((seed + 1 + i) & MAX_VALUE) % instances.size();
 			ServiceInstance chosen = loadBalancer.choose().block().getServer();
-			assertThat(chosen.getInstanceId()).isEqualTo(i + "");
+			assertThat(chosen.getInstanceId()).isEqualTo(instanceId + "");
 		}
 	}
 }