SpringCloud/spring-cloud-config
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1559 from mohammedalics/fixesgh/20302

Browse Source 
Add check if the file extension is null before calling the to toLowerCase() - Fixes gh-20302
This commit is contained in:
Ryan Baxter
2020-02-27 10:10:10 -05:00
committed by GitHub
parent 33c6be1cf5 8ce1b45519
commit 34ac90c4ee
3 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/resource/ResourceController.java
View File

@@ -145,14 +145,16 @@ public class ResourceController {
// ensure InputStream will be closed to prevent file locks on Windows // ensure InputStream will be closed to prevent file locks on Windows
try (InputStream is = resource.getInputStream()) { try (InputStream is = resource.getInputStream()) {
String text = StreamUtils.copyToString(is, Charset.forName("UTF-8")); String text = StreamUtils.copyToString(is, Charset.forName("UTF-8"));
String ext = StringUtils.getFilenameExtension(resource.getFilename()) String ext = StringUtils.getFilenameExtension(resource.getFilename());
.toLowerCase(); if (ext != null) {
ext = ext.toLowerCase();
}
Environment environment = this.environmentRepository.findOne(name, profile, Environment environment = this.environmentRepository.findOne(name, profile,
label, false); label, false);
if (resolvePlaceholders) { if (resolvePlaceholders) {
text = resolvePlaceholders(prepareEnvironment(environment), text); text = resolvePlaceholders(prepareEnvironment(environment), text);
} }
if (encryptEnabled && plainTextEncryptEnabled) { if (ext != null && encryptEnabled && plainTextEncryptEnabled) {
ResourceEncryptor re = this.resourceEncryptorMap.get(ext); ResourceEncryptor re = this.resourceEncryptorMap.get(ext);
if (re == null) { if (re == null) {
logger.warn("Cannot decrypt for extension " + ext); logger.warn("Cannot decrypt for extension " + ext);

7
spring-cloud-config-server/src/test/java/org/springframework/cloud/config/server/resource/ResourceControllerTests.java
View File

@@ -175,6 +175,13 @@ public class ResourceControllerTests {
assertThat(resource).isEqualToIgnoringNewLines("foo: dev_bar/spam"); assertThat(resource).isEqualToIgnoringNewLines("foo: dev_bar/spam");
} }
@Test
public void resourceWithoutFileExtension() throws Exception {
this.environmentRepository.setSearchLocations("classpath:/test");
String resource = this.controller.retrieve("foo", "bar", "dev", "foo", true);
assertThat(resource).isEqualToIgnoringNewLines("foo: dev_bar");
}
@Test @Test
public void resourceWithSlash() throws Exception { public void resourceWithSlash() throws Exception {
this.environmentRepository.setSearchLocations("classpath:/test"); this.environmentRepository.setSearchLocations("classpath:/test");

1
spring-cloud-config-server/src/test/resources/test/dev/foo Normal file
View File

@@ -0,0 +1 @@
foo: dev_bar