c6b902cb47
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). These URLs were unable to be fixed. Please review them to see if they can be manually resolved. * [ ] http://myconfigserver.com (200) with 2 occurrences could not be migrated: ([https](https://myconfigserver.com) result ConnectTimeoutException). These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * [ ] http://doc.gitlab.com/ee/web_hooks/web_hooks.html (302) with 2 occurrences migrated to: https://docs.gitlab.com/ee/web_hooks/web_hooks.html ([https](https://doc.gitlab.com/ee/web_hooks/web_hooks.html) result SSLHandshakeException). * [ ] http://:foobar:@localhost:9999 (UnknownHostException) with 1 occurrences migrated to: https://:foobar:@localhost:9999 ([https](https://:foobar:@localhost:9999) result UnknownHostException). * [ ] http://:foobar@localhost:9999 (UnknownHostException) with 1 occurrences migrated to: https://:foobar@localhost:9999 ([https](https://:foobar@localhost:9999) result UnknownHostException). * [ ] http://authenticated.http.proxy (UnknownHostException) with 2 occurrences migrated to: https://authenticated.http.proxy ([https](https://authenticated.http.proxy) result UnknownHostException). * [ ] http://authenticated.https.proxy (UnknownHostException) with 2 occurrences migrated to: https://authenticated.https.proxy ([https](https://authenticated.https.proxy) result UnknownHostException). * [ ] http://compose.docker.io/ (UnknownHostException) with 1 occurrences migrated to: https://compose.docker.io/ ([https](https://compose.docker.io/) result UnknownHostException). * [ ] http://example/git (UnknownHostException) with 10 occurrences migrated to: https://example/git ([https](https://example/git) result UnknownHostException). * [ ] http://foo:8877/ (UnknownHostException) with 2 occurrences migrated to: https://foo:8877/ ([https](https://foo:8877/) result UnknownHostException). * [ ] http://foo:8877/bar (UnknownHostException) with 1 occurrences migrated to: https://foo:8877/bar ([https](https://foo:8877/bar) result UnknownHostException). * [ ] http://foo:bar@localhost:9999 (UnknownHostException) with 2 occurrences migrated to: https://foo:bar@localhost:9999 ([https](https://foo:bar@localhost:9999) result UnknownHostException). * [ ] http://foobar:@localhost:9999 (UnknownHostException) with 1 occurrences migrated to: https://foobar:@localhost:9999 ([https](https://foobar:@localhost:9999) result UnknownHostException). * [ ] http://foobar@localhost:9999 (UnknownHostException) with 1 occurrences migrated to: https://foobar@localhost:9999 ([https](https://foobar@localhost:9999) result UnknownHostException). * [ ] http://git/team-a/config-repo.git (UnknownHostException) with 4 occurrences migrated to: https://git/team-a/config-repo.git ([https](https://git/team-a/config-repo.git) result UnknownHostException). * [ ] http://git/team-b/config-repo.git (UnknownHostException) with 2 occurrences migrated to: https://git/team-b/config-repo.git ([https](https://git/team-b/config-repo.git) result UnknownHostException). * [ ] http://gitea.lawyers.corp/avatars/5868737ae078a4441031bf550d16e967 (UnknownHostException) with 2 occurrences migrated to: https://gitea.lawyers.corp/avatars/5868737ae078a4441031bf550d16e967 ([https](https://gitea.lawyers.corp/avatars/5868737ae078a4441031bf550d16e967) result UnknownHostException). * [ ] http://gitea.lawyers.corp/avatars/dbc87f99ecd29cb0eb4447807ad73f9f (UnknownHostException) with 1 occurrences migrated to: https://gitea.lawyers.corp/avatars/dbc87f99ecd29cb0eb4447807ad73f9f ([https](https://gitea.lawyers.corp/avatars/dbc87f99ecd29cb0eb4447807ad73f9f) result UnknownHostException). * [ ] http://gitea.lawyers.corp/internal/lawsuits (UnknownHostException) with 1 occurrences migrated to: https://gitea.lawyers.corp/internal/lawsuits ([https](https://gitea.lawyers.corp/internal/lawsuits) result UnknownHostException). * [ ] http://gitea.lawyers.corp/internal/lawsuits.git (UnknownHostException) with 1 occurrences migrated to: https://gitea.lawyers.corp/internal/lawsuits.git ([https](https://gitea.lawyers.corp/internal/lawsuits.git) result UnknownHostException). * [ ]78b77379c4(UnknownHostException) with 1 occurrences migrated to:78b77379c4([https](78b77379c4) result UnknownHostException). * [ ]70767b558d...78b77379c4(UnknownHostException) with 1 occurrences migrated to:70767b558d...78b77379c4([https](70767b558d...78b77379c4) result UnknownHostException). * [ ] http://http.proxy (UnknownHostException) with 2 occurrences migrated to: https://http.proxy ([https](https://http.proxy) result UnknownHostException). * [ ] http://https.proxy (UnknownHostException) with 2 occurrences migrated to: https://https.proxy ([https](https://https.proxy) result UnknownHostException). * [ ] http://server-host-doesnt-exist:1234 (UnknownHostException) with 1 occurrences migrated to: https://server-host-doesnt-exist:1234 ([https](https://server-host-doesnt-exist:1234) result UnknownHostException). * [ ] http://somegitserver/somegitrepo (UnknownHostException) with 6 occurrences migrated to: https://somegitserver/somegitrepo ([https](https://somegitserver/somegitrepo) result UnknownHostException). * [ ] http://somehost (UnknownHostException) with 8 occurrences migrated to: https://somehost ([https](https://somehost) result UnknownHostException). * [ ] http://user:password@localhost:8888 (UnknownHostException) with 1 occurrences migrated to: https://user:password@localhost:8888 ([https](https://user:password@localhost:8888) result UnknownHostException). * [ ] http://www.puppycrawl.com/dtds/suppressions_1_1.dtd (404) with 1 occurrences migrated to: https://www.puppycrawl.com/dtds/suppressions_1_1.dtd ([https](https://www.puppycrawl.com/dtds/suppressions_1_1.dtd) result 404). These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://EditorConfig.org with 1 occurrences migrated to: https://EditorConfig.org ([https](https://EditorConfig.org) result 200). * [ ] http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/iam-roles-for-amazon-ec2.html with 1 occurrences migrated to: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/iam-roles-for-amazon-ec2.html ([https](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/iam-roles-for-amazon-ec2.html) result 200). * [ ] http://docs.aws.amazon.com/codecommit/latest/userguide/welcome.html with 1 occurrences migrated to: https://docs.aws.amazon.com/codecommit/latest/userguide/welcome.html ([https](https://docs.aws.amazon.com/codecommit/latest/userguide/welcome.html) result 200). * [ ] http://docs.aws.amazon.com/general/latest/gr/signature-version-4.html with 2 occurrences migrated to: https://docs.aws.amazon.com/general/latest/gr/signature-version-4.html ([https](https://docs.aws.amazon.com/general/latest/gr/signature-version-4.html) result 200). * [ ] http://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/credentials.html with 1 occurrences migrated to: https://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/credentials.html ([https](https://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/credentials.html) result 200). * [ ] http://example.com/mike/diaspora with 3 occurrences migrated to: https://example.com/mike/diaspora ([https](https://example.com/mike/diaspora) result 200). * [ ] http://example.com/mike/diaspora.git with 3 occurrences migrated to: https://example.com/mike/diaspora.git ([https](https://example.com/mike/diaspora.git) result 200). * [ ]b6568db1bcwith 1 occurrences migrated to:b6568db1bc([https](b6568db1bc) result 200). * [ ]da1560886dwith 1 occurrences migrated to:da1560886d([https](da1560886d) result 200). * [ ] http://example.com/svn/ with 1 occurrences migrated to: https://example.com/svn/ ([https](https://example.com/svn/) result 200). * [ ] http://git.mydoc.io/?t=154711 with 1 occurrences migrated to: https://git.mydoc.io/?t=154711 ([https](https://git.mydoc.io/?t=154711) result 200). * [ ] http://serverfault.com/questions/377348/when-does-tmp-get-cleared/377349 with 1 occurrences migrated to: https://serverfault.com/questions/377348/when-does-tmp-get-cleared/377349 ([https](https://serverfault.com/questions/377348/when-does-tmp-get-cleared/377349) result 200). * [ ] http://subversion.apache.org/ with 2 occurrences migrated to: https://subversion.apache.org/ ([https](https://subversion.apache.org/) result 200). * [ ] http://svn.apache.org/repos/asf/subversion/trunk/contrib/hook-scripts/ with 5 occurrences migrated to: https://svn.apache.org/repos/asf/subversion/trunk/contrib/hook-scripts/ ([https](https://svn.apache.org/repos/asf/subversion/trunk/contrib/hook-scripts/) result 200). * [ ] http://svn.apache.org/repos/asf/subversion/trunk/tools/hook-scripts/ with 5 occurrences migrated to: https://svn.apache.org/repos/asf/subversion/trunk/tools/hook-scripts/ ([https](https://svn.apache.org/repos/asf/subversion/trunk/tools/hook-scripts/) result 200). * [ ] http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html with 2 occurrences migrated to: https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html ([https](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) result 200). * [ ] http://www.oracle.com/technetwork/java/javase/downloads/jce-6-download-429243.html with 2 occurrences migrated to: https://www.oracle.com/technetwork/java/javase/downloads/jce-6-download-429243.html ([https](https://www.oracle.com/technetwork/java/javase/downloads/jce-6-download-429243.html) result 200). * [ ] http://www.oracle.com/technetwork/java/javase/downloads/jce-7-download-432124.html with 2 occurrences migrated to: https://www.oracle.com/technetwork/java/javase/downloads/jce-7-download-432124.html ([https](https://www.oracle.com/technetwork/java/javase/downloads/jce-7-download-432124.html) result 200). * [ ] http://www.oracle.com/technetwork/java/javase/downloads/jce8-download-2133166.html with 2 occurrences migrated to: https://www.oracle.com/technetwork/java/javase/downloads/jce8-download-2133166.html ([https](https://www.oracle.com/technetwork/java/javase/downloads/jce8-download-2133166.html) result 200). * [ ] http://git.oschina.net/oschina/webhook with 1 occurrences migrated to: https://git.oschina.net/oschina/webhook ([https](https://git.oschina.net/oschina/webhook) result 301). * [ ] http://plugins.jetbrains.com/plugin/6546 with 2 occurrences migrated to: https://plugins.jetbrains.com/plugin/6546 ([https](https://plugins.jetbrains.com/plugin/6546) result 301). * [ ] http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSGettingStartedGuide/AWSCredentials.html with 1 occurrences migrated to: https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSGettingStartedGuide/AWSCredentials.html ([https](https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSGettingStartedGuide/AWSCredentials.html) result 302). * [ ] http://eclipse.org with 1 occurrences migrated to: https://eclipse.org ([https](https://eclipse.org) result 302). * [ ] http://eclipse.org/m2e/ with 2 occurrences migrated to: https://eclipse.org/m2e/ ([https](https://eclipse.org/m2e/) result 302). * [ ] http://www.danga.com/memcached/ with 1 occurrences migrated to: https://www.danga.com/memcached/ ([https](https://www.danga.com/memcached/) result 302). * [ ] http://www.springsource.com/developer/sts with 1 occurrences migrated to: https://www.springsource.com/developer/sts ([https](https://www.springsource.com/developer/sts) result 302). These URLs were intentionally ignored. * http://127.0.0.1:%s/test/endpoint with 1 occurrences * http://127.0.0.1:8200 with 1 occurrences * http://127.0.0.1:8200/v1/foo/bar/secret/ with 2 occurrences * http://127.0.0.1:8200/v1/secret/ with 9 occurrences * http://127.0.0.1:8200/v1/secret/data/ with 2 occurrences * http://localhost with 23 occurrences * http://localhost/ with 5 occurrences * http://localhost/path/ with 2 occurrences * http://localhost/test.git with 3 occurrences * http://localhost/test1.git with 1 occurrences * http://localhost/test2.git with 1 occurrences * http://localhost/value-test.git with 1 occurrences * http://localhost1/test.git with 1 occurrences * http://localhost1:8888/ with 1 occurrences * http://localhost2/test.git with 1 occurrences * http://localhost:8888 with 9 occurrences * http://localhost:8888/myapp/default with 1 occurrences * http://localhost:8889 with 3 occurrences * http://localhost:9999 with 9 occurrences
2.7 KiB
2.7 KiB
Contributing
Spring Cloud is released under the non-restrictive Apache 2.0 license, and follows a very standard Github development process, using Github tracker for issues and merging pull requests into master. If you want to contribute even something trivial please do not hesitate, but follow the guidelines below.
Sign the Contributor License Agreement
Before we accept a non-trivial patch or pull request we will need you to sign the Contributor License Agreement. Signing the contributor's agreement does not grant anyone commit rights to the main repository, but it does mean that we can accept your contributions, and you will get an author credit if we do. Active contributors might be asked to join the core team, and given the ability to merge pull requests.
Code of Conduct
This project adheres to the Contributor Covenant code of conduct. By participating, you are expected to uphold this code. Please report unacceptable behavior to spring-code-of-conduct@pivotal.io.
Code Conventions and Housekeeping
None of these is essential for a pull request, but they will all help. They can also be added after the original pull request but before a merge.
- Use the Spring Framework code format conventions. If you use Eclipse
you can import formatter settings using the
eclipse-code-formatter.xmlfile from the Spring Cloud Build project. If using IntelliJ, you can use the Eclipse Code Formatter Plugin to import the same file. - Make sure all new
.javafiles to have a simple Javadoc class comment with at least an@authortag identifying you, and preferably at least a paragraph on what the class is for. - Add the ASF license header comment to all new
.javafiles (copy from existing files in the project) - Add yourself as an
@authorto the .java files that you modify substantially (more than cosmetic changes). - Add some Javadocs and, if you change the namespace, some XSD doc elements.
- A few unit tests would help a lot as well -- someone has to do it.
- If no-one else is using your branch, please rebase it against the current master (or other target branch in the main project).
- When writing a commit message please follow these conventions,
if you are fixing an existing issue please add
Fixes gh-XXXXat the end of the commit message (where XXXX is the issue number).