From 93398e829a211657f696d7ee1724b5e79418170e Mon Sep 17 00:00:00 2001 From: Spencer Gibb Date: Mon, 1 Jun 2015 13:30:32 -0600 Subject: [PATCH 1/6] spring-cloud-starter for each module fixes gh-34 --- pom.xml | 40 +++++++- spring-cloud-consul-bus/pom.xml | 12 +++ spring-cloud-consul-config/pom.xml | 12 +++ spring-cloud-consul-core/pom.xml | 5 + spring-cloud-consul-discovery/pom.xml | 19 ++++ spring-cloud-consul-sample/pom.xml | 22 +++-- spring-cloud-starter-consul-bus/pom.xml | 44 +++++++++ .../main/resources/META-INF/spring.provides | 1 + spring-cloud-starter-consul-config/pom.xml | 44 +++++++++ .../main/resources/META-INF/spring.provides | 1 + spring-cloud-starter-consul-discovery/pom.xml | 92 +++++++++++++++++++ .../main/resources/META-INF/spring.provides | 1 + spring-cloud-starter-consul-ui/pom.xml | 40 ++++++++ .../main/resources/META-INF/spring.provides | 1 + spring-cloud-starter-consul/pom.xml | 40 ++++++++ .../main/resources/META-INF/spring.provides | 1 + 16 files changed, 360 insertions(+), 15 deletions(-) create mode 100644 spring-cloud-starter-consul-bus/pom.xml create mode 100644 spring-cloud-starter-consul-bus/src/main/resources/META-INF/spring.provides create mode 100644 spring-cloud-starter-consul-config/pom.xml create mode 100644 spring-cloud-starter-consul-config/src/main/resources/META-INF/spring.provides create mode 100644 spring-cloud-starter-consul-discovery/pom.xml create mode 100644 spring-cloud-starter-consul-discovery/src/main/resources/META-INF/spring.provides create mode 100644 spring-cloud-starter-consul-ui/pom.xml create mode 100644 spring-cloud-starter-consul-ui/src/main/resources/META-INF/spring.provides create mode 100644 spring-cloud-starter-consul/pom.xml create mode 100644 spring-cloud-starter-consul/src/main/resources/META-INF/spring.provides diff --git a/pom.xml b/pom.xml index 2f207b66..2cec6795 100644 --- a/pom.xml +++ b/pom.xml @@ -34,6 +34,11 @@ spring-cloud-consul-ui spring-cloud-consul-sample spring-cloud-consul-tests + spring-cloud-starter-consul-bus + spring-cloud-starter-consul-config + spring-cloud-starter-consul-discovery + spring-cloud-starter-consul-ui + spring-cloud-starter-consul docs @@ -70,27 +75,52 @@ org.springframework.cloud spring-cloud-consul-core - 1.0.0.BUILD-SNAPSHOT + ${project.version} org.springframework.cloud spring-cloud-consul-bus - 1.0.0.BUILD-SNAPSHOT + ${project.version} org.springframework.cloud spring-cloud-consul-config - 1.0.0.BUILD-SNAPSHOT + ${project.version} org.springframework.cloud spring-cloud-consul-discovery - 1.0.0.BUILD-SNAPSHOT + ${project.version} org.springframework.cloud spring-cloud-consul-ui - 1.0.0.BUILD-SNAPSHOT + ${project.version} + + + org.springframework.cloud + spring-cloud-starter-consul + ${project.version} + + + org.springframework.cloud + spring-cloud-starter-consul-bus + ${project.version} + + + org.springframework.cloud + spring-cloud-starter-consul-config + ${project.version} + + + org.springframework.cloud + spring-cloud-starter-consul-discovery + ${project.version} + + + org.springframework.cloud + spring-cloud-starter-consul-ui + ${project.version} org.springframework.cloud diff --git a/spring-cloud-consul-bus/pom.xml b/spring-cloud-consul-bus/pom.xml index dde261d6..9e9c833a 100644 --- a/spring-cloud-consul-bus/pom.xml +++ b/spring-cloud-consul-bus/pom.xml @@ -17,13 +17,25 @@ + + org.springframework.boot + spring-boot-starter-web + true + org.springframework.cloud spring-cloud-consul-core + true org.springframework.cloud spring-cloud-bus + true + + + com.ecwid.consul + consul-api + true org.projectlombok diff --git a/spring-cloud-consul-config/pom.xml b/spring-cloud-consul-config/pom.xml index 6d7791db..a66beee2 100644 --- a/spring-cloud-consul-config/pom.xml +++ b/spring-cloud-consul-config/pom.xml @@ -17,13 +17,25 @@ + + org.springframework.boot + spring-boot-starter-web + true + + + com.ecwid.consul + consul-api + true + org.springframework.cloud spring-cloud-consul-core + true org.springframework.cloud spring-cloud-context + true org.projectlombok diff --git a/spring-cloud-consul-core/pom.xml b/spring-cloud-consul-core/pom.xml index c8b43422..b9683ea5 100644 --- a/spring-cloud-consul-core/pom.xml +++ b/spring-cloud-consul-core/pom.xml @@ -20,23 +20,28 @@ org.springframework.boot spring-boot-starter-web + true org.springframework.boot spring-boot-starter-actuator + true org.springframework.cloud spring-cloud-commons + true com.ecwid.consul consul-api + true com.google.code.gson gson + true org.projectlombok diff --git a/spring-cloud-consul-discovery/pom.xml b/spring-cloud-consul-discovery/pom.xml index 6373c8be..e701cd9e 100644 --- a/spring-cloud-consul-discovery/pom.xml +++ b/spring-cloud-consul-discovery/pom.xml @@ -21,33 +21,50 @@ org.springframework.cloud spring-cloud-consul-core + + org.springframework.cloud + spring-cloud-commons + true + + + com.ecwid.consul + consul-api + true + org.springframework.cloud spring-cloud-netflix-core + true com.netflix.archaius archaius-core + true commons-configuration commons-configuration + true com.netflix.ribbon ribbon + true com.netflix.ribbon ribbon-core + true com.netflix.ribbon ribbon-httpclient + true com.netflix.ribbon ribbon-loadbalancer + true org.projectlombok @@ -63,10 +80,12 @@ joda-time joda-time + true org.springframework.boot spring-boot-starter-web + true diff --git a/spring-cloud-consul-sample/pom.xml b/spring-cloud-consul-sample/pom.xml index faeb4fdb..dd26dbaf 100644 --- a/spring-cloud-consul-sample/pom.xml +++ b/spring-cloud-consul-sample/pom.xml @@ -21,7 +21,7 @@ org.springframework.boot spring-boot-maven-plugin - 1.2.1.RELEASE + 1.2.3.RELEASE @@ -41,33 +41,35 @@ - - org.springframework.boot - spring-boot-starter-web - org.springframework.boot spring-boot-starter-actuator org.springframework.cloud - spring-cloud-consul-config + spring-cloud-starter-consul + + org.projectlombok lombok + + provided diff --git a/spring-cloud-starter-consul-bus/pom.xml b/spring-cloud-starter-consul-bus/pom.xml new file mode 100644 index 00000000..6c4dfd1b --- /dev/null +++ b/spring-cloud-starter-consul-bus/pom.xml @@ -0,0 +1,44 @@ + + + 4.0.0 + + org.springframework.cloud + spring-cloud-consul + 1.0.0.BUILD-SNAPSHOT + .. + + spring-cloud-starter-consul-bus + Spring Cloud Starter Consul Bus + Spring Cloud Starter Consul Bus + http://projects.spring.io/spring-cloud + + Pivotal Software, Inc. + http://www.spring.io + + + ${basedir}/../.. + + + + org.springframework.cloud + spring-cloud-consul-bus + + + org.springframework.boot + spring-boot-starter-web + + + org.springframework.cloud + spring-cloud-consul-core + + + org.springframework.cloud + spring-cloud-bus + + + com.ecwid.consul + consul-api + + + diff --git a/spring-cloud-starter-consul-bus/src/main/resources/META-INF/spring.provides b/spring-cloud-starter-consul-bus/src/main/resources/META-INF/spring.provides new file mode 100644 index 00000000..6583dfc2 --- /dev/null +++ b/spring-cloud-starter-consul-bus/src/main/resources/META-INF/spring.provides @@ -0,0 +1 @@ +provides: spring-cloud-consul-core, consul-api, spring-cloud-consul-bus \ No newline at end of file diff --git a/spring-cloud-starter-consul-config/pom.xml b/spring-cloud-starter-consul-config/pom.xml new file mode 100644 index 00000000..46bd2a0f --- /dev/null +++ b/spring-cloud-starter-consul-config/pom.xml @@ -0,0 +1,44 @@ + + + 4.0.0 + + org.springframework.cloud + spring-cloud-consul + 1.0.0.BUILD-SNAPSHOT + .. + + spring-cloud-starter-consul-config + Spring Cloud Starter Consul Config + Spring Cloud Starter Consul Config + http://projects.spring.io/spring-cloud + + Pivotal Software, Inc. + http://www.spring.io + + + ${basedir}/../.. + + + + org.springframework.cloud + spring-cloud-consul-config + + + org.springframework.boot + spring-boot-starter-web + + + com.ecwid.consul + consul-api + + + org.springframework.cloud + spring-cloud-consul-core + + + org.springframework.cloud + spring-cloud-context + + + diff --git a/spring-cloud-starter-consul-config/src/main/resources/META-INF/spring.provides b/spring-cloud-starter-consul-config/src/main/resources/META-INF/spring.provides new file mode 100644 index 00000000..3d862baa --- /dev/null +++ b/spring-cloud-starter-consul-config/src/main/resources/META-INF/spring.provides @@ -0,0 +1 @@ +provides: spring-cloud-consul-core, consul-api, spring-cloud-consul-config \ No newline at end of file diff --git a/spring-cloud-starter-consul-discovery/pom.xml b/spring-cloud-starter-consul-discovery/pom.xml new file mode 100644 index 00000000..1d730881 --- /dev/null +++ b/spring-cloud-starter-consul-discovery/pom.xml @@ -0,0 +1,92 @@ + + + 4.0.0 + + org.springframework.cloud + spring-cloud-consul + 1.0.0.BUILD-SNAPSHOT + .. + + spring-cloud-starter-consul-discovery + spring-cloud-starter-consul-discovery + Spring Cloud Starter Consul Discovery + http://projects.spring.io/spring-cloud + + Pivotal Software, Inc. + http://www.spring.io + + + ${basedir}/../.. + + + + org.springframework.cloud + spring-cloud-consul-discovery + + + org.springframework.boot + spring-boot-starter-web + + + org.springframework.cloud + spring-cloud-commons + + + com.ecwid.consul + consul-api + + + + com.google.code.gson + gson + + + org.springframework.cloud + spring-cloud-consul-core + + + org.springframework.cloud + spring-cloud-netflix-core + + + com.netflix.archaius + archaius-core + + + commons-configuration + commons-configuration + + + com.netflix.ribbon + ribbon + + + com.netflix.ribbon + ribbon-core + + + com.netflix.ribbon + ribbon-httpclient + + + com.netflix.ribbon + ribbon-loadbalancer + + + org.projectlombok + lombok + + provided + + + joda-time + joda-time + + + org.springframework.boot + spring-boot-starter-web + + + diff --git a/spring-cloud-starter-consul-discovery/src/main/resources/META-INF/spring.provides b/spring-cloud-starter-consul-discovery/src/main/resources/META-INF/spring.provides new file mode 100644 index 00000000..9952539f --- /dev/null +++ b/spring-cloud-starter-consul-discovery/src/main/resources/META-INF/spring.provides @@ -0,0 +1 @@ +provides: spring-cloud-consul-core, consul-api, spring-cloud-consul-discovery \ No newline at end of file diff --git a/spring-cloud-starter-consul-ui/pom.xml b/spring-cloud-starter-consul-ui/pom.xml new file mode 100644 index 00000000..485b7415 --- /dev/null +++ b/spring-cloud-starter-consul-ui/pom.xml @@ -0,0 +1,40 @@ + + + 4.0.0 + + org.springframework.cloud + spring-cloud-consul + 1.0.0.BUILD-SNAPSHOT + .. + + spring-cloud-starter-consul-ui + Spring Cloud Starter Consul UI + Spring Cloud Starter Consul UI + http://projects.spring.io/spring-cloud + + Pivotal Software, Inc. + http://www.spring.io + + + ${basedir}/../.. + + + + org.springframework.cloud + spring-cloud-consul-ui + + + org.springframework.cloud + spring-cloud-consul-core + + + org.springframework.boot + spring-boot-starter-web + + + org.springframework.cloud + spring-cloud-starter-zuul + + + diff --git a/spring-cloud-starter-consul-ui/src/main/resources/META-INF/spring.provides b/spring-cloud-starter-consul-ui/src/main/resources/META-INF/spring.provides new file mode 100644 index 00000000..9d157263 --- /dev/null +++ b/spring-cloud-starter-consul-ui/src/main/resources/META-INF/spring.provides @@ -0,0 +1 @@ +provides: spring-cloud-consul-core, consul-api, spring-cloud-consul-ui \ No newline at end of file diff --git a/spring-cloud-starter-consul/pom.xml b/spring-cloud-starter-consul/pom.xml new file mode 100644 index 00000000..4154bc6b --- /dev/null +++ b/spring-cloud-starter-consul/pom.xml @@ -0,0 +1,40 @@ + + + 4.0.0 + + org.springframework.cloud + spring-cloud-consul + 1.0.0.BUILD-SNAPSHOT + .. + + spring-cloud-starter-consul + Spring Cloud Starter Consul + Spring Cloud Starter Consul + http://projects.spring.io/spring-cloud + + Pivotal Software, Inc. + http://www.spring.io + + + ${basedir}/../.. + + + + org.springframework.cloud + spring-cloud-starter-consul-bus + + + org.springframework.cloud + spring-cloud-starter-consul-config + + + org.springframework.cloud + spring-cloud-starter-consul-discovery + + + org.springframework.cloud + spring-cloud-starter-consul-ui + + + diff --git a/spring-cloud-starter-consul/src/main/resources/META-INF/spring.provides b/spring-cloud-starter-consul/src/main/resources/META-INF/spring.provides new file mode 100644 index 00000000..281e1913 --- /dev/null +++ b/spring-cloud-starter-consul/src/main/resources/META-INF/spring.provides @@ -0,0 +1 @@ +provides: spring-cloud-consul-core, consul-api, spring-cloud-consul-bus, spring-cloud-consul-config, spring-cloud-consul-discovery, spring-cloud-consul-ui \ No newline at end of file From f2d77461b6dc6853920bb305c68876b0a978e48b Mon Sep 17 00:00:00 2001 From: Spencer Gibb Date: Mon, 1 Jun 2015 13:32:41 -0600 Subject: [PATCH 2/6] added actuator test dependency --- spring-cloud-consul-discovery/pom.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/spring-cloud-consul-discovery/pom.xml b/spring-cloud-consul-discovery/pom.xml index e701cd9e..2ffa3209 100644 --- a/spring-cloud-consul-discovery/pom.xml +++ b/spring-cloud-consul-discovery/pom.xml @@ -87,6 +87,11 @@ spring-boot-starter-web true + + org.springframework.boot + spring-boot-starter-actuator + true + From f5cc92f33ceaa24ae8ab150a6e9acd06d56dc7fb Mon Sep 17 00:00:00 2001 From: Spencer Gibb Date: Mon, 1 Jun 2015 13:36:56 -0600 Subject: [PATCH 3/6] remove s-c-consul-tests --- pom.xml | 1 - spring-cloud-consul-tests/pom.xml | 50 --------------- spring-cloud-consul-tests/run-server.sh | 1 - .../consul/sidecar/ZuulApplicationTests.java | 61 ------------------- .../src/test/resources/application.yml | 21 ------- .../src/test/resources/bootstrap.yml | 7 --- .../src/test/resources/health.json | 1 - 7 files changed, 142 deletions(-) delete mode 100644 spring-cloud-consul-tests/pom.xml delete mode 100755 spring-cloud-consul-tests/run-server.sh delete mode 100644 spring-cloud-consul-tests/src/test/java/org/springframework/cloud/consul/sidecar/ZuulApplicationTests.java delete mode 100644 spring-cloud-consul-tests/src/test/resources/application.yml delete mode 100644 spring-cloud-consul-tests/src/test/resources/bootstrap.yml delete mode 100644 spring-cloud-consul-tests/src/test/resources/health.json diff --git a/pom.xml b/pom.xml index 2cec6795..966539dc 100644 --- a/pom.xml +++ b/pom.xml @@ -33,7 +33,6 @@ spring-cloud-consul-bus spring-cloud-consul-ui spring-cloud-consul-sample - spring-cloud-consul-tests spring-cloud-starter-consul-bus spring-cloud-starter-consul-config spring-cloud-starter-consul-discovery diff --git a/spring-cloud-consul-tests/pom.xml b/spring-cloud-consul-tests/pom.xml deleted file mode 100644 index 13f9e267..00000000 --- a/spring-cloud-consul-tests/pom.xml +++ /dev/null @@ -1,50 +0,0 @@ - - - 4.0.0 - - spring-cloud-consul-tests - jar - Spring Cloud Consul Tests - Spring Cloud Consul Tests - - - org.springframework.cloud - spring-cloud-consul - 1.0.0.BUILD-SNAPSHOT - .. - - - - - org.springframework.boot - spring-boot-starter-web - - - org.springframework.boot - spring-boot-starter-actuator - - - org.springframework.cloud - spring-cloud-consul-config - - - org.springframework.cloud - spring-cloud-consul-discovery - - - org.projectlombok - lombok - - provided - - - org.springframework.boot - spring-boot-starter-test - test - - - - - diff --git a/spring-cloud-consul-tests/run-server.sh b/spring-cloud-consul-tests/run-server.sh deleted file mode 100755 index 8bacc042..00000000 --- a/spring-cloud-consul-tests/run-server.sh +++ /dev/null @@ -1 +0,0 @@ -python -m SimpleHTTPServer diff --git a/spring-cloud-consul-tests/src/test/java/org/springframework/cloud/consul/sidecar/ZuulApplicationTests.java b/spring-cloud-consul-tests/src/test/java/org/springframework/cloud/consul/sidecar/ZuulApplicationTests.java deleted file mode 100644 index 9662404d..00000000 --- a/spring-cloud-consul-tests/src/test/java/org/springframework/cloud/consul/sidecar/ZuulApplicationTests.java +++ /dev/null @@ -1,61 +0,0 @@ -/* - * Copyright 2013-2015 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.springframework.cloud.consul.sidecar; - -import org.junit.Ignore; -import org.junit.Test; -import org.junit.runner.RunWith; -import org.springframework.boot.SpringApplication; -import org.springframework.boot.actuate.metrics.repository.InMemoryMetricRepository; -import org.springframework.boot.autoconfigure.SpringBootApplication; -import org.springframework.boot.test.IntegrationTest; -import org.springframework.boot.test.SpringApplicationConfiguration; -import org.springframework.cloud.client.circuitbreaker.EnableCircuitBreaker; -import org.springframework.cloud.client.discovery.EnableDiscoveryClient; -import org.springframework.cloud.netflix.zuul.EnableZuulProxy; -import org.springframework.context.annotation.Bean; -import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; -import org.springframework.test.context.web.WebAppConfiguration; - -@RunWith(SpringJUnit4ClassRunner.class) -@SpringApplicationConfiguration(classes = ZuulApplicationTests.ZuulApplication.class) -@IntegrationTest("server.port=0") -@WebAppConfiguration -public class ZuulApplicationTests { - - @Test - @Ignore - public void contextLoads() { - } - - @SpringBootApplication - @EnableCircuitBreaker - @EnableDiscoveryClient - @EnableZuulProxy - public static class ZuulApplication { - - @Bean - public InMemoryMetricRepository inMemoryMetricRepository() { - return new InMemoryMetricRepository(); - } - - public static void main(String[] args) { - SpringApplication.run(ZuulApplication.class, args); - } - - } -} diff --git a/spring-cloud-consul-tests/src/test/resources/application.yml b/spring-cloud-consul-tests/src/test/resources/application.yml deleted file mode 100644 index ce295c8c..00000000 --- a/spring-cloud-consul-tests/src/test/resources/application.yml +++ /dev/null @@ -1,21 +0,0 @@ -server: - port: 5678 -spring: - application: - name: sidecarTest - -sidecar: - port: 8000 - health-uri: http://localhost:8000/src/test/resources/health.json - -ribbon: - ServerListRefreshInterval: 5000 - -endpoints: - refresh: - enabled: true - shutdown: - enabled: true - health: - sensitive: false - diff --git a/spring-cloud-consul-tests/src/test/resources/bootstrap.yml b/spring-cloud-consul-tests/src/test/resources/bootstrap.yml deleted file mode 100644 index bbd58928..00000000 --- a/spring-cloud-consul-tests/src/test/resources/bootstrap.yml +++ /dev/null @@ -1,7 +0,0 @@ -spring: - #application: - # name: sideCarTest - cloud: - config: - username: user - password: password diff --git a/spring-cloud-consul-tests/src/test/resources/health.json b/spring-cloud-consul-tests/src/test/resources/health.json deleted file mode 100644 index 41f3615e..00000000 --- a/spring-cloud-consul-tests/src/test/resources/health.json +++ /dev/null @@ -1 +0,0 @@ -{"status":"UP"} \ No newline at end of file From 6f1fe48448d1491fe06fcb0a530a489e4ba20b4d Mon Sep 17 00:00:00 2001 From: Spencer Gibb Date: Mon, 1 Jun 2015 20:19:47 -0600 Subject: [PATCH 4/6] add missing httpcore dependency fixes gh-37 --- pom.xml | 5 +++++ spring-cloud-consul-core/pom.xml | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/pom.xml b/pom.xml index 966539dc..5edbcde8 100644 --- a/pom.xml +++ b/pom.xml @@ -184,6 +184,11 @@ httpclient ${httpclient.version} + + org.apache.httpcomponents + httpcore + ${httpclient.version} + org.springframework.cloud spring-cloud-starter-zuul diff --git a/spring-cloud-consul-core/pom.xml b/spring-cloud-consul-core/pom.xml index b9683ea5..e805bdf4 100644 --- a/spring-cloud-consul-core/pom.xml +++ b/spring-cloud-consul-core/pom.xml @@ -43,6 +43,14 @@ gson true + + org.apache.httpcomponents + httpclient + + + org.apache.httpcomponents + httpcore + org.projectlombok lombok From d28e7f0230bc4dc1cf611385e7ebf57ae75910b0 Mon Sep 17 00:00:00 2001 From: Spencer Gibb Date: Mon, 1 Jun 2015 20:31:15 -0600 Subject: [PATCH 5/6] add missing httpcore dependency to starters --- spring-cloud-consul-core/pom.xml | 2 ++ spring-cloud-consul-discovery/pom.xml | 16 ++++++++++++++++ spring-cloud-starter-consul-bus/pom.xml | 13 +++++++++++++ spring-cloud-starter-consul-config/pom.xml | 13 +++++++++++++ spring-cloud-starter-consul-discovery/pom.xml | 8 ++++++++ 5 files changed, 52 insertions(+) diff --git a/spring-cloud-consul-core/pom.xml b/spring-cloud-consul-core/pom.xml index e805bdf4..d8482696 100644 --- a/spring-cloud-consul-core/pom.xml +++ b/spring-cloud-consul-core/pom.xml @@ -46,10 +46,12 @@ org.apache.httpcomponents httpclient + true org.apache.httpcomponents httpcore + true org.projectlombok diff --git a/spring-cloud-consul-discovery/pom.xml b/spring-cloud-consul-discovery/pom.xml index 2ffa3209..1b545d09 100644 --- a/spring-cloud-consul-discovery/pom.xml +++ b/spring-cloud-consul-discovery/pom.xml @@ -31,6 +31,22 @@ consul-api true + + + com.google.code.gson + gson + true + + + org.apache.httpcomponents + httpclient + true + + + org.apache.httpcomponents + httpcore + true + org.springframework.cloud spring-cloud-netflix-core diff --git a/spring-cloud-starter-consul-bus/pom.xml b/spring-cloud-starter-consul-bus/pom.xml index 6c4dfd1b..df0b18cd 100644 --- a/spring-cloud-starter-consul-bus/pom.xml +++ b/spring-cloud-starter-consul-bus/pom.xml @@ -40,5 +40,18 @@ com.ecwid.consul consul-api + + + com.google.code.gson + gson + + + org.apache.httpcomponents + httpclient + + + org.apache.httpcomponents + httpcore + diff --git a/spring-cloud-starter-consul-config/pom.xml b/spring-cloud-starter-consul-config/pom.xml index 46bd2a0f..fc37b904 100644 --- a/spring-cloud-starter-consul-config/pom.xml +++ b/spring-cloud-starter-consul-config/pom.xml @@ -32,6 +32,19 @@ com.ecwid.consul consul-api + + + com.google.code.gson + gson + + + org.apache.httpcomponents + httpclient + + + org.apache.httpcomponents + httpcore + org.springframework.cloud spring-cloud-consul-core diff --git a/spring-cloud-starter-consul-discovery/pom.xml b/spring-cloud-starter-consul-discovery/pom.xml index 1d730881..b40a1fe2 100644 --- a/spring-cloud-starter-consul-discovery/pom.xml +++ b/spring-cloud-starter-consul-discovery/pom.xml @@ -42,6 +42,14 @@ com.google.code.gson gson + + org.apache.httpcomponents + httpclient + + + org.apache.httpcomponents + httpcore + org.springframework.cloud spring-cloud-consul-core From e78dca0762dfff5f01df15945bb44f90396b0690 Mon Sep 17 00:00:00 2001 From: Spencer Gibb Date: Mon, 1 Jun 2015 21:00:47 -0600 Subject: [PATCH 6/6] move s-c-s-consul to s-c-s-consul-all, s-c-s-consul now contains common consul dependencies for each starter --- pom.xml | 8 +++- spring-cloud-consul-sample/pom.xml | 2 +- spring-cloud-starter-consul-all/pom.xml | 40 +++++++++++++++++++ .../main/resources/META-INF/spring.provides | 1 + spring-cloud-starter-consul-bus/pom.xml | 25 +----------- .../main/resources/META-INF/spring.provides | 2 +- spring-cloud-starter-consul-config/pom.xml | 25 +----------- .../main/resources/META-INF/spring.provides | 2 +- spring-cloud-starter-consul-discovery/pom.xml | 33 ++------------- .../main/resources/META-INF/spring.provides | 2 +- .../main/resources/META-INF/spring.provides | 2 +- spring-cloud-starter-consul/pom.xml | 25 +++++++++--- .../main/resources/META-INF/spring.provides | 2 +- 13 files changed, 81 insertions(+), 88 deletions(-) create mode 100644 spring-cloud-starter-consul-all/pom.xml create mode 100644 spring-cloud-starter-consul-all/src/main/resources/META-INF/spring.provides diff --git a/pom.xml b/pom.xml index 5edbcde8..5cfe84b8 100644 --- a/pom.xml +++ b/pom.xml @@ -33,11 +33,12 @@ spring-cloud-consul-bus spring-cloud-consul-ui spring-cloud-consul-sample + spring-cloud-starter-consul spring-cloud-starter-consul-bus spring-cloud-starter-consul-config spring-cloud-starter-consul-discovery spring-cloud-starter-consul-ui - spring-cloud-starter-consul + spring-cloud-starter-consul-all docs @@ -121,6 +122,11 @@ spring-cloud-starter-consul-ui ${project.version} + + org.springframework.cloud + spring-cloud-starter-consul-all + ${project.version} + org.springframework.cloud spring-cloud-commons diff --git a/spring-cloud-consul-sample/pom.xml b/spring-cloud-consul-sample/pom.xml index dd26dbaf..048c28b4 100644 --- a/spring-cloud-consul-sample/pom.xml +++ b/spring-cloud-consul-sample/pom.xml @@ -47,7 +47,7 @@ org.springframework.cloud - spring-cloud-starter-consul + spring-cloud-starter-consul-all - - com.google.code.gson - gson - - - org.apache.httpcomponents - httpclient - - - org.apache.httpcomponents - httpcore - diff --git a/spring-cloud-starter-consul-bus/src/main/resources/META-INF/spring.provides b/spring-cloud-starter-consul-bus/src/main/resources/META-INF/spring.provides index 6583dfc2..7e37bc1f 100644 --- a/spring-cloud-starter-consul-bus/src/main/resources/META-INF/spring.provides +++ b/spring-cloud-starter-consul-bus/src/main/resources/META-INF/spring.provides @@ -1 +1 @@ -provides: spring-cloud-consul-core, consul-api, spring-cloud-consul-bus \ No newline at end of file +provides: spring-cloud-consul-bus \ No newline at end of file diff --git a/spring-cloud-starter-consul-config/pom.xml b/spring-cloud-starter-consul-config/pom.xml index fc37b904..543068dd 100644 --- a/spring-cloud-starter-consul-config/pom.xml +++ b/spring-cloud-starter-consul-config/pom.xml @@ -22,32 +22,11 @@ org.springframework.cloud - spring-cloud-consul-config - - - org.springframework.boot - spring-boot-starter-web - - - com.ecwid.consul - consul-api - - - - com.google.code.gson - gson - - - org.apache.httpcomponents - httpclient - - - org.apache.httpcomponents - httpcore + spring-cloud-starter-consul org.springframework.cloud - spring-cloud-consul-core + spring-cloud-consul-config org.springframework.cloud diff --git a/spring-cloud-starter-consul-config/src/main/resources/META-INF/spring.provides b/spring-cloud-starter-consul-config/src/main/resources/META-INF/spring.provides index 3d862baa..76b15afb 100644 --- a/spring-cloud-starter-consul-config/src/main/resources/META-INF/spring.provides +++ b/spring-cloud-starter-consul-config/src/main/resources/META-INF/spring.provides @@ -1 +1 @@ -provides: spring-cloud-consul-core, consul-api, spring-cloud-consul-config \ No newline at end of file +provides: spring-cloud-consul-config \ No newline at end of file diff --git a/spring-cloud-starter-consul-discovery/pom.xml b/spring-cloud-starter-consul-discovery/pom.xml index b40a1fe2..675c9e88 100644 --- a/spring-cloud-starter-consul-discovery/pom.xml +++ b/spring-cloud-starter-consul-discovery/pom.xml @@ -21,39 +21,14 @@ ${basedir}/../.. + + org.springframework.cloud + spring-cloud-starter-consul + org.springframework.cloud spring-cloud-consul-discovery - - org.springframework.boot - spring-boot-starter-web - - - org.springframework.cloud - spring-cloud-commons - - - com.ecwid.consul - consul-api - - - - com.google.code.gson - gson - - - org.apache.httpcomponents - httpclient - - - org.apache.httpcomponents - httpcore - - - org.springframework.cloud - spring-cloud-consul-core - org.springframework.cloud spring-cloud-netflix-core diff --git a/spring-cloud-starter-consul-discovery/src/main/resources/META-INF/spring.provides b/spring-cloud-starter-consul-discovery/src/main/resources/META-INF/spring.provides index 9952539f..85fed12c 100644 --- a/spring-cloud-starter-consul-discovery/src/main/resources/META-INF/spring.provides +++ b/spring-cloud-starter-consul-discovery/src/main/resources/META-INF/spring.provides @@ -1 +1 @@ -provides: spring-cloud-consul-core, consul-api, spring-cloud-consul-discovery \ No newline at end of file +provides: spring-cloud-consul-discovery \ No newline at end of file diff --git a/spring-cloud-starter-consul-ui/src/main/resources/META-INF/spring.provides b/spring-cloud-starter-consul-ui/src/main/resources/META-INF/spring.provides index 9d157263..e5fe9b5e 100644 --- a/spring-cloud-starter-consul-ui/src/main/resources/META-INF/spring.provides +++ b/spring-cloud-starter-consul-ui/src/main/resources/META-INF/spring.provides @@ -1 +1 @@ -provides: spring-cloud-consul-core, consul-api, spring-cloud-consul-ui \ No newline at end of file +provides: spring-cloud-consul-ui \ No newline at end of file diff --git a/spring-cloud-starter-consul/pom.xml b/spring-cloud-starter-consul/pom.xml index 4154bc6b..e4b497b9 100644 --- a/spring-cloud-starter-consul/pom.xml +++ b/spring-cloud-starter-consul/pom.xml @@ -21,20 +21,33 @@ - org.springframework.cloud - spring-cloud-starter-consul-bus + org.springframework.boot + spring-boot-starter-web org.springframework.cloud - spring-cloud-starter-consul-config + spring-cloud-commons org.springframework.cloud - spring-cloud-starter-consul-discovery + spring-cloud-consul-core - org.springframework.cloud - spring-cloud-starter-consul-ui + com.ecwid.consul + consul-api + + + + com.google.code.gson + gson + + + org.apache.httpcomponents + httpclient + + + org.apache.httpcomponents + httpcore diff --git a/spring-cloud-starter-consul/src/main/resources/META-INF/spring.provides b/spring-cloud-starter-consul/src/main/resources/META-INF/spring.provides index 281e1913..174eee93 100644 --- a/spring-cloud-starter-consul/src/main/resources/META-INF/spring.provides +++ b/spring-cloud-starter-consul/src/main/resources/META-INF/spring.provides @@ -1 +1 @@ -provides: spring-cloud-consul-core, consul-api, spring-cloud-consul-bus, spring-cloud-consul-config, spring-cloud-consul-discovery, spring-cloud-consul-ui \ No newline at end of file +provides: spring-cloud-consul-core, consul-api \ No newline at end of file