diff --git a/pom.xml b/pom.xml index 9f930c77..cb532da3 100644 --- a/pom.xml +++ b/pom.xml @@ -14,12 +14,13 @@ org.springframework.cloud spring-cloud-build - 2.2.3.RELEASE + 2.2.4.BUILD-SNAPSHOT + 2.10.5 2.2.2.BUILD-SNAPSHOT 2.2.3.BUILD-SNAPSHOT 2.2.3.BUILD-SNAPSHOT @@ -171,6 +172,11 @@ + + joda-time + joda-time + ${joda-time.version} + diff --git a/spring-cloud-consul-core/pom.xml b/spring-cloud-consul-core/pom.xml index 2a9fb534..0fe15561 100644 --- a/spring-cloud-consul-core/pom.xml +++ b/spring-cloud-consul-core/pom.xml @@ -32,6 +32,10 @@ spring-boot-starter-actuator true + + org.springframework.boot + spring-boot-starter-validation + org.springframework.cloud spring-cloud-commons @@ -74,14 +78,6 @@ httpcore true - - org.apache.httpcomponents - httpclient - - - org.apache.httpcomponents - httpcore - org.projectlombok lombok diff --git a/spring-cloud-consul-core/src/main/java/org/springframework/cloud/consul/ConsulAutoConfiguration.java b/spring-cloud-consul-core/src/main/java/org/springframework/cloud/consul/ConsulAutoConfiguration.java index da6d2d86..ed388c70 100644 --- a/spring-cloud-consul-core/src/main/java/org/springframework/cloud/consul/ConsulAutoConfiguration.java +++ b/spring-cloud-consul-core/src/main/java/org/springframework/cloud/consul/ConsulAutoConfiguration.java @@ -20,7 +20,7 @@ import com.ecwid.consul.transport.TLSConfig; import com.ecwid.consul.v1.ConsulClient; import org.aspectj.lang.annotation.Aspect; -import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnEnabledEndpoint; +import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnAvailableEndpoint; import org.springframework.boot.actuate.autoconfigure.health.ConditionalOnEnabledHealthIndicator; import org.springframework.boot.actuate.endpoint.annotation.Endpoint; import org.springframework.boot.autoconfigure.aop.AopAutoConfiguration; @@ -74,7 +74,7 @@ public class ConsulAutoConfiguration { @Bean @ConditionalOnMissingBean - @ConditionalOnEnabledEndpoint + @ConditionalOnAvailableEndpoint public ConsulEndpoint consulEndpoint(ConsulClient consulClient) { return new ConsulEndpoint(consulClient); } diff --git a/spring-cloud-consul-discovery/src/test/java/org/springframework/cloud/consul/serviceregistry/ConsulAutoServiceRegistrationRetryTests.java b/spring-cloud-consul-discovery/src/test/java/org/springframework/cloud/consul/serviceregistry/ConsulAutoServiceRegistrationRetryTests.java index d1b4c3a5..66bcdc85 100644 --- a/spring-cloud-consul-discovery/src/test/java/org/springframework/cloud/consul/serviceregistry/ConsulAutoServiceRegistrationRetryTests.java +++ b/spring-cloud-consul-discovery/src/test/java/org/springframework/cloud/consul/serviceregistry/ConsulAutoServiceRegistrationRetryTests.java @@ -27,7 +27,7 @@ import org.springframework.boot.SpringBootConfiguration; import org.springframework.boot.autoconfigure.EnableAutoConfiguration; import org.springframework.boot.autoconfigure.ImportAutoConfiguration; import org.springframework.boot.builder.SpringApplicationBuilder; -import org.springframework.boot.test.rule.OutputCapture; +import org.springframework.boot.test.system.OutputCaptureRule; import org.springframework.cloud.client.serviceregistry.AutoServiceRegistrationConfiguration; import org.springframework.cloud.consul.ConsulAutoConfiguration; import org.springframework.context.ConfigurableApplicationContext; @@ -45,7 +45,7 @@ public class ConsulAutoServiceRegistrationRetryTests { public ExpectedException exception = ExpectedException.none(); @Rule - public OutputCapture output = new OutputCapture(); + public OutputCaptureRule output = new OutputCaptureRule(); @Test public void testRetry() { diff --git a/spring-cloud-consul-discovery/src/test/java/org/springframework/cloud/consul/serviceregistry/ConsulServiceRegistryCheckTtlTests.java b/spring-cloud-consul-discovery/src/test/java/org/springframework/cloud/consul/serviceregistry/ConsulServiceRegistryCheckTtlTests.java index 2f881783..993e3f79 100644 --- a/spring-cloud-consul-discovery/src/test/java/org/springframework/cloud/consul/serviceregistry/ConsulServiceRegistryCheckTtlTests.java +++ b/spring-cloud-consul-discovery/src/test/java/org/springframework/cloud/consul/serviceregistry/ConsulServiceRegistryCheckTtlTests.java @@ -88,11 +88,14 @@ public class ConsulServiceRegistryCheckTtlTests { .getDeclaredField("serviceHeartbeats"); serviceHeartbeatsField.setAccessible(true); Map serviceHeartbeats = (Map) serviceHeartbeatsField.get(this.ttlScheduler); - assertThat(serviceHeartbeats.keySet().contains(this.registration.getInstanceId())) - .as("Service with heartbeat check not registered in TTL scheduler") - .isTrue(); - assertThat(serviceHeartbeats.keySet().contains(httpRegistration.getInstanceId())) - .as("Service with HTTP check registered in TTL scheduler").isFalse(); + assertThat(serviceHeartbeats.keySet() + .contains(this.registration.getInstanceId())).as( + "Service with heartbeat check not registered in TTL scheduler") + .isTrue(); + assertThat( + serviceHeartbeats.keySet().contains(httpRegistration.getInstanceId())) + .as("Service with HTTP check registered in TTL scheduler") + .isFalse(); } finally { this.consulServiceRegistry.deregister(httpRegistration);