From 080ac0f2f48877030c1e2968a9c41eaf9373e961 Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Mon, 12 Nov 2018 23:56:08 +0100 Subject: [PATCH] Gradle plugin no longer requires the artifact ids to be set for external contract downloading without this change there's a difference between Maven and Gradle plugin usage. If you want to use a custom stubdownloaderbuilder, you need to set a artifact id of a dependency with contracts. That shouldn't be mandatory with this change we no longer require it fixes gh-794 --- .../contract/verifier/plugin/GradleContractsDownloader.groovy | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/spring-cloud-contract-tools/spring-cloud-contract-gradle-plugin/src/main/groovy/org/springframework/cloud/contract/verifier/plugin/GradleContractsDownloader.groovy b/spring-cloud-contract-tools/spring-cloud-contract-gradle-plugin/src/main/groovy/org/springframework/cloud/contract/verifier/plugin/GradleContractsDownloader.groovy index 29c3efc7a9..5b3bdc81ef 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-gradle-plugin/src/main/groovy/org/springframework/cloud/contract/verifier/plugin/GradleContractsDownloader.groovy +++ b/spring-cloud-contract-tools/spring-cloud-contract-gradle-plugin/src/main/groovy/org/springframework/cloud/contract/verifier/plugin/GradleContractsDownloader.groovy @@ -64,9 +64,7 @@ class GradleContractsDownloader { } private boolean shouldDownloadContracts(ContractVerifierExtension extension) { - return [StubRunnerProperties.StubsMode.LOCAL, StubRunnerProperties.StubsMode.REMOTE].any { - it == extension.contractsMode } && (StringUtils.hasText(extension.contractDependency.artifactId) || - StringUtils.hasText(extension.contractDependency.stringNotation)) + return extension.contractsMode != StubRunnerProperties.StubsMode.CLASSPATH } protected ContractDownloader contractDownloader(ContractVerifierExtension extension, StubConfiguration configuration) {