From 2d5c2dd9312f75fa2c4a5a862f1d680a6885e0b3 Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Tue, 23 Oct 2018 22:53:23 +0200 Subject: [PATCH] Fixes missing casting; fixes gh-764 --- pom.xml | 4 ++-- spring-cloud-contract-dependencies/pom.xml | 2 +- .../cloud/contract/verifier/builder/MethodBodyBuilder.groovy | 2 +- .../builder/MockMvcMethodBodyBuilderWithMatchersSpec.groovy | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pom.xml b/pom.xml index 9fae3c4ed8..e80b818f83 100644 --- a/pom.xml +++ b/pom.xml @@ -7,7 +7,7 @@ org.springframework.cloud spring-cloud-build - 2.0.4.BUILD-SNAPSHOT + 2.0.5.BUILD-SNAPSHOT @@ -26,7 +26,7 @@ 2.17 3.5.13 0.0.9 - 2.0.4.RELEASE + 2.0.5.BUILD-SNAPSHOT 2.0.0.BUILD-SNAPSHOT Elmhurst.BUILD-SNAPSHOT 2.0.0.BUILD-SNAPSHOT diff --git a/spring-cloud-contract-dependencies/pom.xml b/spring-cloud-contract-dependencies/pom.xml index 3327570bf9..b5557061c0 100644 --- a/spring-cloud-contract-dependencies/pom.xml +++ b/spring-cloud-contract-dependencies/pom.xml @@ -5,7 +5,7 @@ spring-cloud-dependencies-parent org.springframework.cloud - 2.0.4.BUILD-SNAPSHOT + 2.0.5.BUILD-SNAPSHOT spring-cloud-contract-dependencies diff --git a/spring-cloud-contract-verifier/src/main/groovy/org/springframework/cloud/contract/verifier/builder/MethodBodyBuilder.groovy b/spring-cloud-contract-verifier/src/main/groovy/org/springframework/cloud/contract/verifier/builder/MethodBodyBuilder.groovy index 7c26e8626a..f58c555c66 100644 --- a/spring-cloud-contract-verifier/src/main/groovy/org/springframework/cloud/contract/verifier/builder/MethodBodyBuilder.groovy +++ b/spring-cloud-contract-verifier/src/main/groovy/org/springframework/cloud/contract/verifier/builder/MethodBodyBuilder.groovy @@ -492,7 +492,7 @@ abstract class MethodBodyBuilder { protected void methodForNullCheck(BodyMatcher bodyMatcher, BlockBuilder bb) { String quotedAndEscaptedPath = quotedAndEscaped(bodyMatcher.path()) - String method = "assertThat(parsedJson.read(${quotedAndEscaptedPath})).isNull()" + String method = "assertThat((Object) parsedJson.read(${quotedAndEscaptedPath})).isNull()" bb.addLine(postProcessJsonPathCall(method)) addColonIfRequired(bb) } diff --git a/spring-cloud-contract-verifier/src/test/groovy/org/springframework/cloud/contract/verifier/builder/MockMvcMethodBodyBuilderWithMatchersSpec.groovy b/spring-cloud-contract-verifier/src/test/groovy/org/springframework/cloud/contract/verifier/builder/MockMvcMethodBodyBuilderWithMatchersSpec.groovy index ce7b49fa2d..1ea995b393 100644 --- a/spring-cloud-contract-verifier/src/test/groovy/org/springframework/cloud/contract/verifier/builder/MockMvcMethodBodyBuilderWithMatchersSpec.groovy +++ b/spring-cloud-contract-verifier/src/test/groovy/org/springframework/cloud/contract/verifier/builder/MockMvcMethodBodyBuilderWithMatchersSpec.groovy @@ -189,7 +189,7 @@ class MockMvcMethodBodyBuilderWithMatchersSpec extends Specification implements test.contains('assertThat((java.lang.Iterable) parsedJson.read("' + rootElement + '.valueWithMaxEmpty", java.util.Collection.class)).as("' + rootElement + '.valueWithMaxEmpty").hasSizeLessThanOrEqualTo(0)') test.contains('assertThatValueIsANumber(parsedJson.read("' + rootElement + '.duck")') test.contains('assertThat(parsedJson.read("' + rootElement + '''.['key'].['complex.key']", String.class)).isEqualTo("foo")''') - test.contains('assertThat(parsedJson.read("' + rootElement + '.nullValue")).isNull()') + test.contains('assertThat((Object) parsedJson.read("' + rootElement + '.nullValue")).isNull()') !test.contains('cursor') and: try {