diff --git a/spring-cloud-contract-maven-plugin/checkstyle.html b/spring-cloud-contract-maven-plugin/checkstyle.html index 2e34120e25..ef1001aa29 100644 --- a/spring-cloud-contract-maven-plugin/checkstyle.html +++ b/spring-cloud-contract-maven-plugin/checkstyle.html @@ -348,12 +348,12 @@ org/springframework/cloud/contract/maven/verifier/stubrunner/LocalStubRunner.java 0 0 -10 +9 org/springframework/cloud/contract/maven/verifier/stubrunner/RemoteStubRunner.java 0 0 -19 +20

Rules

@@ -1740,697 +1740,697 @@ - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + + + + + + + - + - + - - - - - - - + - + + + + + + + - + - - - - - - - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + + + + + + + + + + + + + - - - - - - - - - - - - - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + -
javadoc JavadocStyle First sentence should end with a period.46
44
 Error sizes LineLength Line is longer than 80 characters (found 83).47
45
 Error sizes LineLength Line is longer than 80 characters (found 135).50
48
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance).53
51
 Error javadoc JavadocVariable Missing a Javadoc comment.53
51
 Error sizes LineLength Line is longer than 80 characters (found 148).56
54
 Error javadoc JavadocVariable Missing a Javadoc comment.56
54
 Error sizes LineLength Line is longer than 80 characters (found 96).59
57
 Error javadoc JavadocVariable Missing a Javadoc comment.59
57
 Error javadoc JavadocVariable Missing a Javadoc comment.62
60
 Error javadoc JavadocVariable Missing a Javadoc comment.65
63
 Error javadoc JavadocVariable Missing a Javadoc comment.68
66
 Error javadoc JavadocVariable Missing a Javadoc comment.71
69
 Error javadoc JavadocVariable Missing a Javadoc comment.74
72
 Error javadoc JavadocVariable Missing a Javadoc comment.77
75
 Error javadoc JavadocStyle First sentence should end with a period.80
78
 Error javadoc JavadocStyle First sentence should end with a period.86
84
 Error javadoc JavadocStyle First sentence should end with a period.92
90
 Error javadoc JavadocStyle First sentence should end with a period.98
96
 Error sizes LineLength Line is longer than 80 characters (found 86).105
103
 Error sizes LineLength Line is longer than 80 characters (found 99).108
106
 Error javadoc JavadocStyle First sentence should end with a period.111
109
 Error sizes LineLength Line is longer than 80 characters (found 91).112
110
 Error javadoc JavadocVariable Missing a Javadoc comment.117
115
 Error sizes LineLength Line is longer than 80 characters (found 92).120
118
 Error javadoc JavadocVariable Missing a Javadoc comment.120
118
 Error javadoc JavadocVariable Missing a Javadoc comment.123
121
 Error javadoc JavadocVariable Missing a Javadoc comment.126
124
 Error sizes LineLength Line is longer than 80 characters (found 84).130
128
 Error sizes LineLength Line is longer than 80 characters (found 88).131
129
 Error javadoc JavadocVariable Missing a Javadoc comment.137
135
 Error sizes LineLength Line is longer than 80 characters (found 89).141
139
 Error sizes LineLength Line is longer than 80 characters (found 87).142
140
 Error javadoc JavadocStyle Extra HTML tag found: </p>144
142
 Error sizes LineLength Line is longer than 80 characters (found 94).145
143
 Error javadoc JavadocStyle First sentence should end with a period.151
149
 Error sizes LineLength Line is longer than 80 characters (found 92).158
156
 Error sizes LineLength Line is longer than 80 characters (found 93).157
 ErrorsizesLineLengthLine is longer than 80 characters (found 93). 159
 Error sizes LineLengthLine is longer than 80 characters (found 93).Line is longer than 80 characters (found 89). 161
 ErrorsizesLineLengthLine is longer than 80 characters (found 89).163
 Error sizes LineLength Line is longer than 80 characters (found 93).170
168
 Error sizes LineLength Line is longer than 80 characters (found 89).171
169
 Error javadoc JavadocStyle Extra HTML tag found: </p>171
 ErrorjavadocJavadocStyleExtra HTML tag found: </p> 173
 Error javadoc JavadocStyle Extra HTML tag found: </p> 175
 ErrorjavadocJavadocStyleExtra HTML tag found: </p>177
 Error sizes LineLength Line is longer than 80 characters (found 91).178
176
 Error javadoc JavadocStyle First sentence should end with a period.209
207
 Error sizes LineLength Line is longer than 80 characters (found 92).210
208
 Error sizes LineLength Line is longer than 80 characters (found 83).214
212
 Error javadoc JavadocStyle First sentence should end with a period.218
216
 Error sizes LineLength Line is longer than 80 characters (found 94).219
217
 Error javadoc JavadocStyle First sentence should end with a period.225
223
 Error sizes LineLength Line is longer than 80 characters (found 86).227
225
 Error javadoc JavadocVariable Missing a Javadoc comment.232
230
 Error javadoc JavadocMethod Missing a Javadoc comment.234
232
 Error sizes LineLength Line is longer than 80 characters (found 91).235
233
 Error misc FinalParameters Parameter aetherStubDownloaderFactory should be final.235
233
 Error coding HiddenField 'aetherStubDownloaderFactory' hides a field.235
233
 Error sizes LineLength Line is longer than 80 characters (found 83).239
237
 Error design DesignForExtension Class 'GenerateTestsMojo' looks like designed for extension (can be subclassed), but the method 'execute' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenerateTestsMojo' final or making the method 'execute' static/final/abstract/empty, or adding allowed annotation for the method.239
237
 Error javadoc JavadocMethod Missing a Javadoc comment.239
237
 Error blocks NeedBraces 'if' construct must use '{}'s.241
239
 Error sizes LineLength Line is longer than 80 characters (found 137).243
241
 Error blocks NeedBraces 'if' construct must use '{}'s.245
243
 Error sizes LineLength Line is longer than 80 characters (found 117).247
245
 Error sizes LineLength Line is longer than 80 characters (found 86).248
246
 Error blocks NeedBraces 'if' construct must use '{}'s.249
247
 Error sizes LineLength Line is longer than 80 characters (found 110).251
249
 Error sizes LineLength Line is longer than 80 characters (found 82).252
250
 Error sizes LineLength Line is longer than 80 characters (found 128).256
254
 Error sizes LineLength Line is longer than 80 characters (found 103).257
255
 Error sizes LineLength Line is longer than 80 characters (found 84).259
257
 Error coding HiddenField 'contractsDirectory' hides a field.259
257
 Error sizes LineLength Line is longer than 80 characters (found 105).260
258
 Error sizes LineLength Line is longer than 80 characters (found 95).261
259
 Error sizes LineLength Line is longer than 80 characters (found 100).262
260
 Error sizes LineLength Line is longer than 80 characters (found 93).263
261
 Error sizes LineLength Line is longer than 80 characters (found 102).264
262
 Error sizes LineLength Line is longer than 80 characters (found 102).267
265
 Error sizes LineLength Line is longer than 80 characters (found 106).270
268
 Error sizes LineLength Line is longer than 80 characters (found 102).273
271
 Error sizes LineLength Line is longer than 80 characters (found 88).274
 ErrorsizesLineLengthLine is longer than 80 characters (found 101).275
 ErrorsizesLineLengthLine is longer than 80 characters (found 101). 276
 Error sizes LineLengthLine is longer than 80 characters (found 101).277
 ErrorsizesLineLengthLine is longer than 80 characters (found 101).278
 ErrorsizesLineLength Line is longer than 80 characters (found 90).284
282
 Error blocks RightCurly '}' at column 3 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).285
283
 Error sizes LineLength Line is longer than 80 characters (found 108).288
286
 Error javadoc JavadocMethod Missing a Javadoc comment.294
292
 Error misc FinalParameters Parameter config should be final.294
292
 Error misc FinalParameters Parameter contractsDirectory should be final.295
293
 Error coding HiddenField 'contractsDirectory' hides a field.295
293
 Error javadoc JavadocMethod Missing a Javadoc comment.316
314
 Error misc FinalParameters Parameter contractsDirectory should be final.316
314
 Error coding HiddenField 'contractsDirectory' hides a field.316
314
 Error blocks RightCurly '}' at column 3 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).319
317
 Error design DesignForExtension Class 'GenerateTestsMojo' looks like designed for extension (can be subclassed), but the method 'mappingsToMap' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenerateTestsMojo' final or making the method 'mappingsToMap' static/final/abstract/empty, or adding allowed annotation for the method.325
323
 Error javadoc JavadocMethod Missing a Javadoc comment.325
323
 Error sizes LineLength Line is longer than 80 characters (found 94).331
329
 Error design DesignForExtension Class 'GenerateTestsMojo' looks like designed for extension (can be subclassed), but the method 'getExcludedFiles' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenerateTestsMojo' final or making the method 'getExcludedFiles' static/final/abstract/empty, or adding allowed annotation for the method.336
334
 Error javadoc JavadocMethod Missing a Javadoc comment.336
334
 Error design DesignForExtension Class 'GenerateTestsMojo' looks like designed for extension (can be subclassed), but the method 'setExcludedFiles' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenerateTestsMojo' final or making the method 'setExcludedFiles' static/final/abstract/empty, or adding allowed annotation for the method.340
338
 Error javadoc JavadocMethod Missing a Javadoc comment.340
338
 Error misc FinalParameters Parameter excludedFiles should be final.340
338
 Error coding HiddenField 'excludedFiles' hides a field.340
338
 Error design DesignForExtension Class 'GenerateTestsMojo' looks like designed for extension (can be subclassed), but the method 'getIgnoredFiles' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenerateTestsMojo' final or making the method 'getIgnoredFiles' static/final/abstract/empty, or adding allowed annotation for the method.344
342
 Error javadoc JavadocMethod Missing a Javadoc comment.344
342
 Error design DesignForExtension Class 'GenerateTestsMojo' looks like designed for extension (can be subclassed), but the method 'setIgnoredFiles' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenerateTestsMojo' final or making the method 'setIgnoredFiles' static/final/abstract/empty, or adding allowed annotation for the method.348
346
 Error javadoc JavadocMethod Missing a Javadoc comment.348
346
 Error misc FinalParameters Parameter ignoredFiles should be final.348
346
 Error coding HiddenField 'ignoredFiles' hides a field.348
346
 Error design DesignForExtension Class 'GenerateTestsMojo' looks like designed for extension (can be subclassed), but the method 'isAssertJsonSize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenerateTestsMojo' final or making the method 'isAssertJsonSize' static/final/abstract/empty, or adding allowed annotation for the method.352
350
 Error javadoc JavadocMethod Missing a Javadoc comment.352
350
 Error design DesignForExtension Class 'GenerateTestsMojo' looks like designed for extension (can be subclassed), but the method 'setAssertJsonSize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenerateTestsMojo' final or making the method 'setAssertJsonSize' static/final/abstract/empty, or adding allowed annotation for the method.356
354
 Error javadoc JavadocMethod Missing a Javadoc comment.356
354
 Error misc FinalParameters Parameter assertJsonSize should be final.356
354
 Error coding HiddenField 'assertJsonSize' hides a field.356
+354

org/springframework/cloud/contract/maven/verifier/ManifestCreator.java

@@ -3724,58 +3724,52 @@ - - - - - - - + - + - + - + - + - + - + - + @@ -3784,12 +3778,18 @@

org/springframework/cloud/contract/maven/verifier/stubrunner/RemoteStubRunner.java

 Error javadocJavadocPackageMissing package-info.java file.
 Errorjavadoc JavadocType Missing a Javadoc comment. 26
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 29
 Error javadoc JavadocVariable Missing a Javadoc comment. 29
 Error naming ConstantName Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 29
 Error sizes LineLength Line is longer than 80 characters (found 85). 31
 Error design DesignForExtension Class 'LocalStubRunner' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LocalStubRunner' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. 31
 Error javadoc JavadocMethod Missing a Javadoc comment. 31
 Error misc FinalParameters Parameter options should be final. 31
 Error sizes LineLength
- + + + + + + + diff --git a/spring-cloud-contract-maven-plugin/checkstyle.rss b/spring-cloud-contract-maven-plugin/checkstyle.rss index e82c96df90..a30dcd33a7 100644 --- a/spring-cloud-contract-maven-plugin/checkstyle.rss +++ b/spring-cloud-contract-maven-plugin/checkstyle.rss @@ -130,7 +130,7 @@ under the License. @@ -158,7 +158,7 @@ under the License. @@ -181,7 +181,7 @@ under the License. 0 diff --git a/spring-cloud-contract.xml b/spring-cloud-contract.xml index b75f65a655..786762b245 100644 --- a/spring-cloud-contract.xml +++ b/spring-cloud-contract.xml @@ -4,7 +4,7 @@ Spring Cloud Contract -2018-11-08 +2018-11-06
Severity Category Rule Message Line
 ErrorjavadocJavadocPackageMissing package-info.java file.
 Error javadoc
- org/springframework/cloud/contract/maven/verifier/RunMojo.java + org/springframework/cloud/contract/maven/verifier/stubrunner/RemoteStubRunner.java 0 @@ -139,7 +139,7 @@ under the License. 0 - 46 + 20
- org/springframework/cloud/contract/maven/verifier/stubrunner/RemoteStubRunner.java + org/springframework/cloud/contract/maven/verifier/RunMojo.java 0 @@ -167,7 +167,7 @@ under the License. 0 - 19 + 46
- 10 + 9