diff --git a/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/pom.xml b/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/pom.xml index 7bcfe20c18..d1eff3dac4 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/pom.xml +++ b/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/pom.xml @@ -189,6 +189,42 @@ maven-checkstyle-plugin + + + + + org.eclipse.m2e + lifecycle-mapping + 1.0.0 + + + + + + + org.apache.maven.plugins + + + maven-plugin-plugin + + + [3.5,) + + + descriptor + helpmojo + + + + + + + + + + + + diff --git a/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/ConvertMojo.java b/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/ConvertMojo.java index 487f569a53..7469d9f88a 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/ConvertMojo.java +++ b/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/ConvertMojo.java @@ -20,8 +20,6 @@ import java.io.File; import java.util.HashMap; import java.util.Map; -import javax.inject.Inject; - import org.apache.maven.execution.MavenSession; import org.apache.maven.model.Dependency; import org.apache.maven.plugin.AbstractMojo; @@ -34,7 +32,6 @@ import org.apache.maven.project.MavenProject; import org.apache.maven.shared.filtering.MavenResourcesFiltering; import org.eclipse.aether.RepositorySystemSession; -import org.springframework.cloud.contract.maven.verifier.stubrunner.AetherStubDownloaderFactory; import org.springframework.cloud.contract.stubrunner.spring.StubRunnerProperties; import org.springframework.cloud.contract.verifier.config.ContractVerifierConfigProperties; import org.springframework.cloud.contract.verifier.converter.RecursiveFilesConverter; @@ -57,8 +54,6 @@ public class ConvertMojo extends AbstractMojo { static final String CONTRACTS_PATH = "/contracts"; static final String ORIGINAL_PATH = "/original"; - private final AetherStubDownloaderFactory aetherStubDownloaderFactory; - @Parameter(defaultValue = "${repositorySystemSession}", readonly = true) private RepositorySystemSession repoSession; @@ -186,11 +181,7 @@ public class ConvertMojo extends AbstractMojo { @Component(role = MavenResourcesFiltering.class, hint = "default") private MavenResourcesFiltering mavenResourcesFiltering; - @Inject - public ConvertMojo(AetherStubDownloaderFactory aetherStubDownloaderFactory) { - this.aetherStubDownloaderFactory = aetherStubDownloaderFactory; - } - + @Override public void execute() throws MojoExecutionException { if (this.skip) { getLog().info(String.format( diff --git a/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/GenerateTestsMojo.java b/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/GenerateTestsMojo.java index a1441e613c..f596bc4087 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/GenerateTestsMojo.java +++ b/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/GenerateTestsMojo.java @@ -21,8 +21,6 @@ import java.util.HashMap; import java.util.List; import java.util.Map; -import javax.inject.Inject; - import org.apache.maven.model.Dependency; import org.apache.maven.model.Resource; import org.apache.maven.plugin.AbstractMojo; @@ -35,7 +33,6 @@ import org.apache.maven.plugins.annotations.ResolutionScope; import org.apache.maven.project.MavenProject; import org.eclipse.aether.RepositorySystemSession; -import org.springframework.cloud.contract.maven.verifier.stubrunner.AetherStubDownloaderFactory; import org.springframework.cloud.contract.spec.ContractVerifierException; import org.springframework.cloud.contract.stubrunner.spring.StubRunnerProperties; import org.springframework.cloud.contract.verifier.TestGenerator; @@ -53,8 +50,6 @@ import org.springframework.cloud.contract.verifier.config.TestMode; requiresDependencyResolution = ResolutionScope.TEST) public class GenerateTestsMojo extends AbstractMojo { - private final AetherStubDownloaderFactory aetherStubDownloaderFactory; - @Parameter(defaultValue = "${repositorySystemSession}", readonly = true) private RepositorySystemSession repoSession; @@ -234,11 +229,7 @@ public class GenerateTestsMojo extends AbstractMojo { @Parameter(property = "contractsProperties") private Map contractsProperties = new HashMap<>(); - @Inject - public GenerateTestsMojo(AetherStubDownloaderFactory aetherStubDownloaderFactory) { - this.aetherStubDownloaderFactory = aetherStubDownloaderFactory; - } - + @Override public void execute() throws MojoExecutionException, MojoFailureException { if (this.skip || this.mavenTestSkip || this.skipTests) { if (this.skip) { diff --git a/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/PushStubsToScmMojo.java b/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/PushStubsToScmMojo.java index 65e4a67c2e..f41046940b 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/PushStubsToScmMojo.java +++ b/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/PushStubsToScmMojo.java @@ -37,7 +37,6 @@ import org.springframework.util.StringUtils; * * @author Marcin Grzejszczak */ -@SuppressWarnings("FieldCanBeLocal") @Mojo(name = "pushStubsToScm") public class PushStubsToScmMojo extends AbstractMojo { @@ -105,6 +104,7 @@ public class PushStubsToScmMojo extends AbstractMojo { @Parameter(property = "contractsProperties") private Map contractsProperties = new HashMap<>(); + @Override public void execute() { if (this.skip || this.taskSkip) { getLog().info( diff --git a/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/RunMojo.java b/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/RunMojo.java index 5e85751daa..6e902aa555 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/RunMojo.java +++ b/spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/src/main/java/org/springframework/cloud/contract/maven/verifier/RunMojo.java @@ -44,7 +44,6 @@ import org.springframework.util.StringUtils; * * @author Mariusz Smykula */ -@SuppressWarnings("FieldCanBeLocal") @Mojo(name = "run", requiresProject = false, requiresDependencyResolution = ResolutionScope.RUNTIME) public class RunMojo extends AbstractMojo { @@ -124,6 +123,7 @@ public class RunMojo extends AbstractMojo { this.remoteStubRunner = remoteStubRunner; } + @Override public void execute() throws MojoExecutionException, MojoFailureException { if (this.skip || this.skipTestOnly) { getLog().info(