From 90172436be6590732c2ec70a1e98ce6716fd3c11 Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Fri, 16 Jul 2021 18:02:16 +0200 Subject: [PATCH] Downgraded pact to 4.1.23 cause 4.2 requires java11 --- pom.xml | 2 +- .../spec/pact/MatchingRulesConverter.java | 8 ++++---- .../verifier/spec/pact/MessagePactCreator.java | 2 +- .../spec/pact/MessagingSCContractCreator.java | 14 +++++++------- .../pact/RequestResponseSCContractCreator.java | 18 +++++++++--------- .../spec/pact/ValueGeneratorConverter.java | 2 +- .../spec/pact/PactContractConverterSpec.groovy | 2 +- .../contracts/grouped/shouldWorkWithBeer.json | 2 +- .../contracts/shouldConvertAllGenerators.json | 2 +- .../contracts/shouldMarkClientAsFraud.json | 2 +- .../contracts/shouldMarkClientAsNotFraud.json | 2 +- .../contracts/shouldReturnFraudStats.json | 2 +- .../shouldSendMessageWhenBookReturned.json | 2 +- .../shouldSendMessageWhenMessageReceived.json | 2 +- .../shouldVerifyWhenBookWasDeleted.json | 2 +- 15 files changed, 32 insertions(+), 32 deletions(-) diff --git a/pom.xml b/pom.xml index 12d0b39cac..dc578e7be8 100644 --- a/pom.xml +++ b/pom.xml @@ -25,7 +25,7 @@ 3.11.0 - 4.2.7 + 4.1.23 0.0.9 3.1.0-SNAPSHOT 3.1.0-SNAPSHOT diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/MatchingRulesConverter.java b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/MatchingRulesConverter.java index f655129f20..21d7b4d8c8 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/MatchingRulesConverter.java +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/MatchingRulesConverter.java @@ -16,9 +16,9 @@ package org.springframework.cloud.contract.verifier.spec.pact; +import au.com.dius.pact.core.model.matchingrules.Category; import au.com.dius.pact.core.model.matchingrules.DateMatcher; import au.com.dius.pact.core.model.matchingrules.EqualsMatcher; -import au.com.dius.pact.core.model.matchingrules.MatchingRuleCategory; import au.com.dius.pact.core.model.matchingrules.MaxTypeMatcher; import au.com.dius.pact.core.model.matchingrules.MinMaxTypeMatcher; import au.com.dius.pact.core.model.matchingrules.MinTypeMatcher; @@ -43,12 +43,12 @@ final class MatchingRulesConverter { private MatchingRulesConverter() { } - static MatchingRuleCategory matchingRulesForBody(BodyMatchers bodyMatchers) { + static Category matchingRulesForBody(BodyMatchers bodyMatchers) { return matchingRulesFor("body", bodyMatchers); } - private static MatchingRuleCategory matchingRulesFor(String categoryName, BodyMatchers bodyMatchers) { - MatchingRuleCategory category = new MatchingRuleCategory(categoryName); + private static Category matchingRulesFor(String categoryName, BodyMatchers bodyMatchers) { + Category category = new Category(categoryName); bodyMatchers.matchers().forEach((b) -> { String key = getMatcherKey(b.path()); MatchingType matchingType = b.matchingType(); diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/MessagePactCreator.java b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/MessagePactCreator.java index 3b26007cc4..10e3aae3a5 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/MessagePactCreator.java +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/MessagePactCreator.java @@ -51,7 +51,7 @@ class MessagePactCreator { return null; } Names names = NamingUtil.name(contracts.get(0)); - MessagePactBuilder pactBuilder = new MessagePactBuilder().consumer(names.getConsumer()) + MessagePactBuilder pactBuilder = MessagePactBuilder.consumer(names.getConsumer()) .hasPactWith(names.getProducer()); for (Contract contract : contracts) { diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/MessagingSCContractCreator.java b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/MessagingSCContractCreator.java index 7ac77f2891..f97c299f24 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/MessagingSCContractCreator.java +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/MessagingSCContractCreator.java @@ -21,9 +21,9 @@ import java.util.Collections; import java.util.List; import java.util.stream.Collectors; +import au.com.dius.pact.core.model.matchingrules.Category; import au.com.dius.pact.core.model.matchingrules.DateMatcher; import au.com.dius.pact.core.model.matchingrules.MatchingRule; -import au.com.dius.pact.core.model.matchingrules.MatchingRuleCategory; import au.com.dius.pact.core.model.matchingrules.MaxTypeMatcher; import au.com.dius.pact.core.model.matchingrules.MinMaxTypeMatcher; import au.com.dius.pact.core.model.matchingrules.MinTypeMatcher; @@ -70,13 +70,13 @@ class MessagingSCContractCreator { contract.outputMessage((outputMessage) -> { if (message.getContents().isPresent()) { outputMessage.body(BodyConverter.toSCCBody(message)); - MatchingRuleCategory bodyRules = message.getMatchingRules().rulesForCategory("body"); + Category bodyRules = message.getMatchingRules().rulesForCategory("body"); if (bodyRules != null && !bodyRules.getMatchingRules().isEmpty()) { outputMessage.bodyMatchers((responseBodyMatchers) -> outputMessageBodyMatchers(message, bodyRules, responseBodyMatchers)); } } - if (!message.getMetadata().isEmpty()) { + if (!message.getMetaData().isEmpty()) { outputMessage.headers((headers) -> outputMessageHeaders(message, headers)); } String dest = findDestination(message); @@ -88,7 +88,7 @@ class MessagingSCContractCreator { } private void outputMessageHeaders(Message message, Headers headers) { - message.getMetadata().forEach((key, value) -> { + message.getMetaData().forEach((key, value) -> { String matchingRuleGroup = value.toString(); if (key.equalsIgnoreCase("contentType")) { headers.messagingContentType(matchingRuleGroup); @@ -99,7 +99,7 @@ class MessagingSCContractCreator { }); } - private void outputMessageBodyMatchers(Message message, MatchingRuleCategory bodyRules, + private void outputMessageBodyMatchers(Message message, Category bodyRules, ResponseBodyMatchers responseBodyMatchers) { bodyRules.getMatchingRules().forEach((matchingRuleKey, matchingRuleGroup) -> { if (matchingRuleGroup.getRuleLogic() != RuleLogic.AND) { @@ -127,8 +127,8 @@ class MessagingSCContractCreator { } private String findDestination(Message message) { - return message.getMetadata().get(DESTINATION_KEY) != null - ? message.getMetadata().get(DESTINATION_KEY).toString() : ""; + return message.getMetaData().get(DESTINATION_KEY) != null + ? message.getMetaData().get(DESTINATION_KEY).toString() : ""; } void applyJsonPathToResponseBodyMatchers(MatchingRule matchingRule, String key, diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/RequestResponseSCContractCreator.java b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/RequestResponseSCContractCreator.java index d642230c1e..056d2421a2 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/RequestResponseSCContractCreator.java +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/RequestResponseSCContractCreator.java @@ -30,9 +30,9 @@ import au.com.dius.pact.core.model.Request; import au.com.dius.pact.core.model.RequestResponseInteraction; import au.com.dius.pact.core.model.RequestResponsePact; import au.com.dius.pact.core.model.Response; +import au.com.dius.pact.core.model.matchingrules.Category; import au.com.dius.pact.core.model.matchingrules.DateMatcher; import au.com.dius.pact.core.model.matchingrules.MatchingRule; -import au.com.dius.pact.core.model.matchingrules.MatchingRuleCategory; import au.com.dius.pact.core.model.matchingrules.MatchingRuleGroup; import au.com.dius.pact.core.model.matchingrules.MaxTypeMatcher; import au.com.dius.pact.core.model.matchingrules.MinMaxTypeMatcher; @@ -92,7 +92,7 @@ class RequestResponseSCContractCreator { if (pactRequest.getBody().getState() == OptionalBody.State.PRESENT) { mapRequestBody(contractRequest, pactRequest); } - MatchingRuleCategory bodyRules = pactRequest.getMatchingRules().rulesForCategory("body"); + Category bodyRules = pactRequest.getMatchingRules().rulesForCategory("body"); if (!bodyRules.getMatchingRules().isEmpty()) { mapRequestBodyRules(contractRequest, bodyRules); } @@ -111,7 +111,7 @@ class RequestResponseSCContractCreator { mapResponseBody(contractResponse, pactResponse); } - MatchingRuleCategory bodyRules = pactResponse.getMatchingRules().rulesForCategory("body"); + Category bodyRules = pactResponse.getMatchingRules().rulesForCategory("body"); if (!bodyRules.getMatchingRules().isEmpty()) { mapResponseBodyRules(contractResponse, pactResponse, bodyRules); } @@ -126,7 +126,7 @@ class RequestResponseSCContractCreator { } private void mapResponseBodyRules(org.springframework.cloud.contract.spec.internal.Response contractResponse, - Response pactResponse, MatchingRuleCategory bodyRules) { + Response pactResponse, Category bodyRules) { contractResponse.bodyMatchers((bodyMatchers) -> { bodyRules.getMatchingRules().forEach((key, matchindRuleGroup) -> { if (matchindRuleGroup.getRuleLogic() != RuleLogic.AND) { @@ -210,7 +210,7 @@ class RequestResponseSCContractCreator { } private void mapRequestBodyRules(org.springframework.cloud.contract.spec.internal.Request contractRequest, - MatchingRuleCategory bodyRules) { + Category bodyRules) { contractRequest.bodyMatchers((bodyMatchers) -> { bodyRules.getMatchingRules().forEach((key, matchingRuleGroup) -> { if (matchingRuleGroup.getRuleLogic() != RuleLogic.AND) { @@ -267,7 +267,7 @@ class RequestResponseSCContractCreator { private void mapRequestCookies(org.springframework.cloud.contract.spec.internal.Request contractRequest, Request pactRequest) { - MatchingRuleCategory headerRules = pactRequest.getMatchingRules().rulesForCategory("header"); + Category headerRules = pactRequest.getMatchingRules().rulesForCategory("header"); String[] splitCookiesHeader = pactRequest.getHeaders().get("Cookie").get(0).split(";"); Map foundCookies = Stream.of(splitCookiesHeader).map((cookieHeader) -> cookieHeader.split("=")) .collect(Collectors.toMap(splittedCookieHeader -> splittedCookieHeader[0], @@ -300,7 +300,7 @@ class RequestResponseSCContractCreator { private void mapResponseCookies(org.springframework.cloud.contract.spec.internal.Response contractResponse, Response pactResponse) { - MatchingRuleCategory headerRules = pactResponse.getMatchingRules().rulesForCategory("header"); + Category headerRules = pactResponse.getMatchingRules().rulesForCategory("header"); String[] splitCookiesHeader = pactResponse.getHeaders().get("Cookie").get(0).split(";"); Map foundCookies = Stream.of(splitCookiesHeader).map((cookieHeader) -> cookieHeader.split("=")) .collect(Collectors.toMap(splittedCookieHeader -> splittedCookieHeader[0], @@ -345,7 +345,7 @@ class RequestResponseSCContractCreator { private void mapRequestHeaders(org.springframework.cloud.contract.spec.internal.Request contractRequest, Request pactRequest) { - MatchingRuleCategory headerRules = pactRequest.getMatchingRules().rulesForCategory("header"); + Category headerRules = pactRequest.getMatchingRules().rulesForCategory("header"); contractRequest.headers((headers) -> pactRequest.getHeaders().forEach((key, values) -> { if (key.equalsIgnoreCase("Cookie")) { return; @@ -379,7 +379,7 @@ class RequestResponseSCContractCreator { private void mapResponseHeaders(org.springframework.cloud.contract.spec.internal.Response contractResponse, Response pactResponse) { - MatchingRuleCategory headerRules = pactResponse.getMatchingRules().rulesForCategory("header"); + Category headerRules = pactResponse.getMatchingRules().rulesForCategory("header"); contractResponse.headers((headers) -> pactResponse.getHeaders().forEach((key, values) -> { if (key.equalsIgnoreCase("Cookie")) { return; diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/ValueGeneratorConverter.java b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/ValueGeneratorConverter.java index bc09d73e84..fb6833e5d1 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/ValueGeneratorConverter.java +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/verifier/spec/pact/ValueGeneratorConverter.java @@ -133,7 +133,7 @@ final class ValueGeneratorConverter { "We currently don't support a generator of type " + generator.getClass().getSimpleName()); } else { - Object generatedValue = generator.generate(new HashMap<>(), null); + Object generatedValue = generator.generate(new HashMap<>()); return dslPropertyProvider.apply(pattern, generatedValue); } } diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/groovy/org/springframework/cloud/contract/verifier/spec/pact/PactContractConverterSpec.groovy b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/groovy/org/springframework/cloud/contract/verifier/spec/pact/PactContractConverterSpec.groovy index 0bbeff09ae..1b1e54aebf 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/groovy/org/springframework/cloud/contract/verifier/spec/pact/PactContractConverterSpec.groovy +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/groovy/org/springframework/cloud/contract/verifier/spec/pact/PactContractConverterSpec.groovy @@ -347,7 +347,7 @@ class PactContractConverterSpec extends Specification { ], "metadata": { "pact-jvm": { - "version": "4.2.7" + "version": "4.1.23" } } } diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/grouped/shouldWorkWithBeer.json b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/grouped/shouldWorkWithBeer.json index f7eb25ac2b..6a9cd2948c 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/grouped/shouldWorkWithBeer.json +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/grouped/shouldWorkWithBeer.json @@ -147,7 +147,7 @@ ], "metadata": { "pact-jvm": { - "version": "4.2.7" + "version": "4.1.23" } } } diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldConvertAllGenerators.json b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldConvertAllGenerators.json index 2ef331119e..b79b029468 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldConvertAllGenerators.json +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldConvertAllGenerators.json @@ -274,7 +274,7 @@ "version": "3.0.0" }, "pact-jvm": { - "version": "4.2.7" + "version": "4.1.23" } } } diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldMarkClientAsFraud.json b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldMarkClientAsFraud.json index 8842b92da8..7eb6829485 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldMarkClientAsFraud.json +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldMarkClientAsFraud.json @@ -98,7 +98,7 @@ "version": "3.0.0" }, "pact-jvm": { - "version": "4.2.7" + "version": "4.1.23" } } } diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldMarkClientAsNotFraud.json b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldMarkClientAsNotFraud.json index 1bcf442ace..eeae11aa72 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldMarkClientAsNotFraud.json +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldMarkClientAsNotFraud.json @@ -90,7 +90,7 @@ "version": "3.0.0" }, "pact-jvm": { - "version": "4.2.7" + "version": "4.1.23" } } } diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldReturnFraudStats.json b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldReturnFraudStats.json index 694f872512..c81ff44d42 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldReturnFraudStats.json +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldReturnFraudStats.json @@ -70,7 +70,7 @@ "version": "3.0.0" }, "pact-jvm": { - "version": "4.2.7" + "version": "4.1.23" } } } diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldSendMessageWhenBookReturned.json b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldSendMessageWhenBookReturned.json index 44b2179098..cd4846274d 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldSendMessageWhenBookReturned.json +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldSendMessageWhenBookReturned.json @@ -39,7 +39,7 @@ "version": "3.0.0" }, "pact-jvm": { - "version": "4.2.7" + "version": "4.1.23" } } } diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldSendMessageWhenMessageReceived.json b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldSendMessageWhenMessageReceived.json index 6d476405d1..6d75e88009 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldSendMessageWhenMessageReceived.json +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldSendMessageWhenMessageReceived.json @@ -38,7 +38,7 @@ "version": "3.0.0" }, "pact-jvm": { - "version": "4.2.7" + "version": "4.1.23" } } } diff --git a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldVerifyWhenBookWasDeleted.json b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldVerifyWhenBookWasDeleted.json index c8359cf289..2d468810b2 100644 --- a/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldVerifyWhenBookWasDeleted.json +++ b/spring-cloud-contract-tools/spring-cloud-contract-pact/src/test/resources/contracts/shouldVerifyWhenBookWasDeleted.json @@ -22,7 +22,7 @@ "version": "3.0.0" }, "pact-jvm": { - "version": "4.2.7" + "version": "4.1.23" } } }