SpringCloud/spring-cloud-contract
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Select value of an anyOf() property at random (#1599)

Browse Source 
The current implementation of `anyOf()` always only selects the first value
when generating a property. It means that other possible enum values are always
ignored when producing a value for the property.

This changes the behaviour so that the value is picked at random from any of
the provided values. It could be considered a breaking changes because of the
change of behaviour although it shouldn't be from the contract perspective.

Fixes #1424

Co-authored-by: Sylvain Guillope <sguillope@atlassian.com>
This commit is contained in:
Sylvain Guillope
2021-02-01 23:43:20 +11:00
committed by GitHub
parent b647833e44
commit e852141ce4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
specs/spring-cloud-contract-spec-java/src/main/java/org/springframework/cloud/contract/spec/internal/PatternValueDslProperty.java
View File

@@ -168,7 +168,7 @@ abstract class PatternValueDslProperty<T extends DslProperty> implements RegexCr
@Override
public T anyOf(String... values) {
return createAndValidateProperty(RegexPatterns.anyOf(values), values[0]);
return createAndValidateProperty(RegexPatterns.anyOf(values), values[this.random.nextInt(values.length)]);
}
}