From 2e5c670a28a654b3d05d91239b5c12477c4e8616 Mon Sep 17 00:00:00 2001 From: Oleg Zhurakousky Date: Mon, 13 Jul 2020 14:21:02 +0200 Subject: [PATCH] Add condition to reset content-type only if it isd not already set Polish some of the POMs to address missing dependencies Temporary disconnect gcp background sample until errors are fixed --- .../integration/LocalServerTestSupport.java | 2 +- .../catalog/SimpleFunctionRegistry.java | 2 +- .../function-sample-aws-custom/pom.xml | 8 ----- .../function-sample-gcp-background/pom.xml | 30 ++++++++++++++++++- .../function-sample-supplier-exporter/pom.xml | 10 ------- spring-cloud-function-samples/pom.xml | 2 +- 6 files changed, 32 insertions(+), 22 deletions(-) diff --git a/spring-cloud-function-adapters/spring-cloud-function-adapter-gcp/src/test/java/org/springframework/cloud/function/adapter/gcp/integration/LocalServerTestSupport.java b/spring-cloud-function-adapters/spring-cloud-function-adapter-gcp/src/test/java/org/springframework/cloud/function/adapter/gcp/integration/LocalServerTestSupport.java index 246a886df..ea5bd3acd 100644 --- a/spring-cloud-function-adapters/spring-cloud-function-adapter-gcp/src/test/java/org/springframework/cloud/function/adapter/gcp/integration/LocalServerTestSupport.java +++ b/spring-cloud-function-adapters/spring-cloud-function-adapter-gcp/src/test/java/org/springframework/cloud/function/adapter/gcp/integration/LocalServerTestSupport.java @@ -59,7 +59,7 @@ final public class LocalServerTestSupport { private static final String SERVER_READY_STRING = "Started ServerConnector"; - private static AtomicInteger nextPort = new AtomicInteger(8080); + private static AtomicInteger nextPort = new AtomicInteger(55555); private LocalServerTestSupport() { } diff --git a/spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/catalog/SimpleFunctionRegistry.java b/spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/catalog/SimpleFunctionRegistry.java index 9ae21c61e..295356678 100644 --- a/spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/catalog/SimpleFunctionRegistry.java +++ b/spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/catalog/SimpleFunctionRegistry.java @@ -686,7 +686,7 @@ public class SimpleFunctionRegistry implements FunctionRegistry, FunctionInspect // Set the contentType header to the value of accept for "legacy" reasons. But, do not set the // contentType header to the value of accept if it is a wildcard type, as this doesn't make sense. // This also applies to the else branch below. - if (acceptedContentType.isConcrete()) { + if (acceptedContentType.isConcrete() && !headersMap.containsKey(MessageHeaders.CONTENT_TYPE)) { headersMap.put(MessageHeaders.CONTENT_TYPE, acceptedContentType); } } diff --git a/spring-cloud-function-samples/function-sample-aws-custom/pom.xml b/spring-cloud-function-samples/function-sample-aws-custom/pom.xml index 885b36502..2df2ec87e 100644 --- a/spring-cloud-function-samples/function-sample-aws-custom/pom.xml +++ b/spring-cloud-function-samples/function-sample-aws-custom/pom.xml @@ -33,14 +33,6 @@ org.springframework.boot spring-boot-starter-json - - io.netty - netty-codec-http2 - - - io.netty - netty-transport-native-epoll - org.hibernate.validator hibernate-validator diff --git a/spring-cloud-function-samples/function-sample-gcp-background/pom.xml b/spring-cloud-function-samples/function-sample-gcp-background/pom.xml index b1f14b2f4..12c2efd63 100644 --- a/spring-cloud-function-samples/function-sample-gcp-background/pom.xml +++ b/spring-cloud-function-samples/function-sample-gcp-background/pom.xml @@ -31,7 +31,6 @@ maven-deploy-plugin - 2.8.2 true @@ -62,4 +61,33 @@ + + + spring-snapshots + Spring Snapshots + https://repo.spring.io/libs-snapshot-local + + true + + + false + + + + spring-milestones + Spring Milestones + https://repo.spring.io/libs-milestone-local + + false + + + + spring-releases + Spring Releases + https://repo.spring.io/release + + false + + + diff --git a/spring-cloud-function-samples/function-sample-supplier-exporter/pom.xml b/spring-cloud-function-samples/function-sample-supplier-exporter/pom.xml index 4a8ea4880..f546fb89f 100644 --- a/spring-cloud-function-samples/function-sample-supplier-exporter/pom.xml +++ b/spring-cloud-function-samples/function-sample-supplier-exporter/pom.xml @@ -28,16 +28,6 @@ org.springframework.boot spring-boot-starter-webflux - - - io.netty - netty-transport-native-epoll - - - io.netty - netty-codec-http2 - - org.springframework.cloud diff --git a/spring-cloud-function-samples/pom.xml b/spring-cloud-function-samples/pom.xml index 87c0330f7..80f429222 100644 --- a/spring-cloud-function-samples/pom.xml +++ b/spring-cloud-function-samples/pom.xml @@ -23,7 +23,7 @@ function-sample-azure function-sample-spring-integration--> function-sample-gcp-http - function-sample-gcp-background +