SpringCloud/spring-cloud-function
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-1230 Ensure header names are case insensitive

Browse Source 
Resolves #1230
This commit is contained in:
Oleg Zhurakousky
2025-04-02 13:56:27 +02:00
parent dbdc35cedf
commit 6a90ba22a6
2 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-cloud-function-adapters/spring-cloud-function-serverless-web/src/main/java/org/springframework/cloud/function/serverless/web/ServerlessHttpServletRequest.java
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright 2023-2023 the original author or authors. * Copyright 2023-2025 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -727,7 +727,7 @@ public class ServerlessHttpServletRequest implements HttpServletRequest {
} }
public void setHeader(String name, @Nullable String value) { public void setHeader(String name, @Nullable String value) {
this.headers.set(name, value); this.headers.add(name, value);
} }
public void addHeader(String name, @Nullable String value) { public void addHeader(String name, @Nullable String value) {

13
spring-cloud-function-adapters/spring-cloud-function-serverless-web/src/test/java/org/springframework/cloud/function/serverless/web/RequestResponseTests.java
View File

@@ -29,6 +29,7 @@ import org.springframework.cloud.function.test.app.Pet;
import org.springframework.cloud.function.test.app.PetStoreSpringAppConfig; import org.springframework.cloud.function.test.app.PetStoreSpringAppConfig;
import org.springframework.cloud.function.test.app.PetStoreSpringAppConfig.AnotherFilter; import org.springframework.cloud.function.test.app.PetStoreSpringAppConfig.AnotherFilter;
import org.springframework.cloud.function.test.app.PetStoreSpringAppConfig.SimpleFilter; import org.springframework.cloud.function.test.app.PetStoreSpringAppConfig.SimpleFilter;
import org.springframework.http.HttpHeaders;
import org.springframework.http.HttpStatus; import org.springframework.http.HttpStatus;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
@@ -57,6 +58,18 @@ public class RequestResponseTests {
this.mvc.stop(); this.mvc.stop();
} }
@Test
public void validateCaseInsensitiveHeaders() throws Exception {
ServerlessHttpServletRequest request = new ServerlessHttpServletRequest(null, "GET", "/index");
request.setHeader("User-Agent", "iOS");
request.setHeader("uSer-Agent", "FOO");
request.setContentType("application/json");
request.setHeader("CoNteNt-tYpe", "text/plain");
assertThat(request.getHeader("content-TYPE")).isEqualTo("application/json");
assertThat(request.getHeader("user-agenT")).isEqualTo("iOS");
}
@Test @Test
public void validateFreemarker() throws Exception { public void validateFreemarker() throws Exception {
HttpServletRequest request = new ServerlessHttpServletRequest(null, "GET", "/index"); HttpServletRequest request = new ServerlessHttpServletRequest(null, "GET", "/index");