From 87187692aed513ec532176c7b86faefcae513feb Mon Sep 17 00:00:00 2001 From: Spencer Gibb Date: Fri, 28 Aug 2020 10:45:59 -0400 Subject: [PATCH] Re-enables RoutingBrokerTests Also updates comments on `.route("uppercase")` as this is now required for `FunctionRSocketMessageHandler` --- .../cloud/function/rsocket/RoutingBrokerTests.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/spring-cloud-function-rsocket/src/test/java/org/springframework/cloud/function/rsocket/RoutingBrokerTests.java b/spring-cloud-function-rsocket/src/test/java/org/springframework/cloud/function/rsocket/RoutingBrokerTests.java index ca1d16389..2d92678df 100644 --- a/spring-cloud-function-rsocket/src/test/java/org/springframework/cloud/function/rsocket/RoutingBrokerTests.java +++ b/spring-cloud-function-rsocket/src/test/java/org/springframework/cloud/function/rsocket/RoutingBrokerTests.java @@ -20,7 +20,6 @@ import java.util.function.Function; import io.rsocket.routing.client.spring.RoutingMetadata; import org.junit.jupiter.api.AfterEach; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import reactor.core.publisher.Mono; import reactor.test.StepVerifier; @@ -40,7 +39,6 @@ import org.springframework.util.SocketUtils; * @author Oleg Zhurakousky * @since 3.1 */ -@Disabled public class RoutingBrokerTests { ConfigurableApplicationContext functionContext; @@ -64,7 +62,8 @@ public class RoutingBrokerTests { public void testRoutingWithProperty() throws Exception { this.setup(true); RSocketRequester requester = clientContext.getBean(RSocketRequester.class); - Mono result = requester.route("uppercase") // used to find a messagemapping, so unused here + // route(uppercase) used to find function, must match io.rsocket.routing.client.address entry + Mono result = requester.route("uppercase") // auto creates metadata .data("\"hello\"") .retrieveMono(String.class); @@ -81,7 +80,7 @@ public class RoutingBrokerTests { this.setup(false); RSocketRequester requester = clientContext.getBean(RSocketRequester.class); RoutingMetadata metadata = clientContext.getBean(RoutingMetadata.class); - Mono result = requester.route("uppercase") // used to find a messagemapping, so unused here + Mono result = requester.route("uppercase") // used to find function .metadata(metadata.address("samplefn")) .data("\"hello\"") .retrieveMono(String.class);