From f2193c95d5ca6650027cddd34c0939e0809267d6 Mon Sep 17 00:00:00 2001 From: ue85540 Date: Fri, 5 Nov 2021 09:53:26 +0100 Subject: [PATCH] Performance improvements Avoid generating strings and implicit toString() calls that will be garbage most of the time. --- .../cloud/function/grpc/MessageHandlingHelper.java | 2 +- .../compiler/config/FunctionProxyApplicationListener.java | 2 +- .../cloud/function/context/catalog/SimpleFunctionRegistry.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-cloud-function-adapters/spring-cloud-function-grpc/src/main/java/org/springframework/cloud/function/grpc/MessageHandlingHelper.java b/spring-cloud-function-adapters/spring-cloud-function-grpc/src/main/java/org/springframework/cloud/function/grpc/MessageHandlingHelper.java index 530147056..caadb6e92 100644 --- a/spring-cloud-function-adapters/spring-cloud-function-grpc/src/main/java/org/springframework/cloud/function/grpc/MessageHandlingHelper.java +++ b/spring-cloud-function-adapters/spring-cloud-function-grpc/src/main/java/org/springframework/cloud/function/grpc/MessageHandlingHelper.java @@ -354,7 +354,7 @@ public class MessageHandlingHelper implements Smar functionDefinition = (String) headers.get(FunctionProperties.FUNCTION_DEFINITION); } FunctionInvocationWrapper function = this.functionCatalog.lookup(functionDefinition, "application/json"); - Assert.notNull(function, "Failed to lookup function " + funcProperties.getDefinition()); + Assert.notNull(function, () -> "Failed to lookup function " + funcProperties.getDefinition()); return function; } } diff --git a/spring-cloud-function-compiler/src/main/java/org/springframework/cloud/function/compiler/config/FunctionProxyApplicationListener.java b/spring-cloud-function-compiler/src/main/java/org/springframework/cloud/function/compiler/config/FunctionProxyApplicationListener.java index 47540bd55..1d93c74b0 100644 --- a/spring-cloud-function-compiler/src/main/java/org/springframework/cloud/function/compiler/config/FunctionProxyApplicationListener.java +++ b/spring-cloud-function-compiler/src/main/java/org/springframework/cloud/function/compiler/config/FunctionProxyApplicationListener.java @@ -92,7 +92,7 @@ public class FunctionProxyApplicationListener String type = (properties.get("type") != null) ? properties.get("type") : "function"; String lambda = properties.get("lambda"); - Assert.notNull(lambda, String.format( + Assert.notNull(lambda, () -> String.format( "The 'lambda' property is required for compiling Function: %s", name)); String inputType = properties.get("inputType"); diff --git a/spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/catalog/SimpleFunctionRegistry.java b/spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/catalog/SimpleFunctionRegistry.java index 4d54b9ac3..eadbdf65f 100644 --- a/spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/catalog/SimpleFunctionRegistry.java +++ b/spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/catalog/SimpleFunctionRegistry.java @@ -1040,7 +1040,7 @@ public class SimpleFunctionRegistry implements FunctionRegistry, FunctionInspect if (this.isWrapConvertedInputInMessage(convertedInput)) { convertedInput = MessageBuilder.withPayload(convertedInput).build(); } - Assert.notNull(convertedInput, "Failed to convert input: " + input + " to " + type); + Assert.notNull(convertedInput, () -> "Failed to convert input: " + input + " to " + type); return convertedInput; }