Only expose Publisher via FunctionCatalog

Flux.from() is cheap and can be used to marshal the inputs everywhere
internally. With this change users ought to be able to register any
function of any Publisher type.
This commit is contained in:
Dave Syer
2018-05-01 11:46:29 -04:00
parent fb04324ac9
commit b59b43ddc5
14 changed files with 81 additions and 59 deletions

View File

@@ -16,17 +16,24 @@
package org.springframework.cloud.function.adapter.openwhisk;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import java.util.Map;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.reactivestreams.Publisher;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RequestBody;
import org.springframework.web.bind.annotation.RestController;
import reactor.core.publisher.Flux;
import java.util.*;
import reactor.core.publisher.Flux;
/**
* @author Mark Fisher
@@ -55,15 +62,15 @@ public class OpenWhiskActionHandler extends OpenWhiskFunctionInitializer {
Object input = convertEvent(request.getValue());
Object result = NO_INPUT_PROVIDED;
if(input !=null ) {
Flux<?> output = apply(extract(input));
Publisher<?> output = apply(extract(input));
result = result(input, output);
}
return serializeBody(result);
}
private Object result(Object input, Flux<?> output) {
private Object result(Object input, Publisher<?> output) {
List<Object> result = new ArrayList<>();
for (Object value : output.toIterable()) {
for (Object value : Flux.from(output).toIterable()) {
result.add(value);
}
if (isSingleValue(input) && result.size() == 1) {

View File

@@ -23,6 +23,7 @@ import java.util.function.Supplier;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.reactivestreams.Publisher;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.cloud.function.context.FunctionCatalog;
@@ -39,11 +40,11 @@ public class OpenWhiskFunctionInitializer {
private static Log logger = LogFactory.getLog(OpenWhiskFunctionInitializer.class);
private Function<Flux<?>, Flux<?>> function;
private Function<Publisher<?>, Publisher<?>> function;
private Consumer<Flux<?>> consumer;
private Consumer<Publisher<?>> consumer;
private Supplier<Flux<?>> supplier;
private Supplier<Publisher<?>> supplier;
private AtomicBoolean initialized = new AtomicBoolean();
@@ -86,7 +87,7 @@ public class OpenWhiskFunctionInitializer {
: (this.consumer != null ? this.consumer : this.supplier);
}
protected Flux<?> apply(Flux<?> input) {
protected Publisher<?> apply(Publisher<?> input) {
if (this.function != null) {
return function.apply(input);
}