SpringCloud/spring-cloud-function
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Unncessary warning for multiple functions found

Browse Source 
Currently we show a warning for multiple functions found even when there
are no functions found and spring.cloud.function.definition is not set.

Resolves https://github.com/spring-cloud/spring-cloud-function/issues/1011
This commit is contained in:
Soby Chacko
2023-03-09 16:19:39 -05:00
parent 69e29e347d
commit dda6d3cb21
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/catalog/BeanFactoryAwareFunctionRegistry.java
View File

@@ -53,6 +53,7 @@ import org.springframework.core.convert.ConversionService;
import org.springframework.lang.Nullable;
import org.springframework.messaging.Message;
import org.springframework.messaging.converter.CompositeMessageConverter;
import org.springframework.util.CollectionUtils;
import org.springframework.util.StringUtils;
/**
@@ -126,8 +127,10 @@ public class BeanFactoryAwareFunctionRegistry extends SimpleFunctionRegistry imp
.filter(name -> !RoutingFunction.FUNCTION_NAME.equals(name))
.filter(name -> !RoutingFunction.DEFAULT_ROUTE_HANDLER.equals(name))
.collect(Collectors.toList());
logger.warn("Multiple functional beans were found " + functionalBeans + ", thus can't determine default function definition. Please "
if (!CollectionUtils.isEmpty(functionalBeans) && functionalBeans.size() > 1) {
logger.warn("Multiple functional beans were found " + functionalBeans + ", thus can't determine default function definition. Please "
+ "use 'spring.cloud.function.definition' property to explicitly define it. ");
}
}
if (!isFunctionDefinitionEligible(functionDefinition)) {
return null;