Turned on checkstyle

spring-cloud-function-adapters/spring-cloud-function-adapter-azure/src/main/java/org/springframework/cloud/function/adapter/azure/AzureSpringBootRequestHandler.java

@@ -1,11 +1,11 @@
 /*
- * Copyright 2017 the original author or authors.
+ * Copyright 2012-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- * http://www.apache.org/licenses/LICENSE-2.0
+ *      http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -24,12 +24,12 @@ import java.util.function.Function;
 
 import com.microsoft.azure.functions.ExecutionContext;
 import com.microsoft.azure.functions.OutputBinding;
-
 import org.reactivestreams.Publisher;
-
 import reactor.core.publisher.Flux;
 
 /**
+ * @param <I> input type
+ * @param <O> result type
  * @author Soby Chacko
  */
 public class AzureSpringBootRequestHandler<I, O> extends AzureSpringFunctionInitializer {
@@ -118,4 +118,5 @@ public class AzureSpringBootRequestHandler<I, O> extends AzureSpringFunctionInit
 	protected O convertOutput(Object output) {
 		return (O) output;
 	}
+
 }

spring-cloud-function-adapters/spring-cloud-function-adapter-azure/src/main/java/org/springframework/cloud/function/adapter/azure/AzureSpringFunctionInitializer.java

@@ -1,11 +1,11 @@
 /*
- * Copyright 2017 the original author or authors.
+ * Copyright 2012-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- * http://www.apache.org/licenses/LICENSE-2.0
+ *      http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -29,7 +29,6 @@ import java.util.function.Function;
 import java.util.jar.Manifest;
 
 import com.microsoft.azure.functions.ExecutionContext;
-
 import org.reactivestreams.Publisher;
 
 import org.springframework.beans.factory.annotation.Autowired;
@@ -46,20 +45,20 @@ import org.springframework.util.ClassUtils;
  */
 public class AzureSpringFunctionInitializer implements Closeable {
 
+	private volatile static ConfigurableApplicationContext context;
+
+	private final Class<?> configurationClass;
+
 	private volatile Function<Publisher<?>, Publisher<?>> function;
 
 	private AtomicBoolean initialized = new AtomicBoolean();
 
-	private final Class<?> configurationClass;
-
 	@Autowired(required = false)
 	private volatile FunctionCatalog catalog;
 
 	@Autowired(required = false)
 	private volatile FunctionInspector inspector;
 
-	private volatile static ConfigurableApplicationContext context;
-
 	public AzureSpringFunctionInitializer(Class<?> configurationClass) {
 		this.configurationClass = configurationClass == null ? getClass()
 				: configurationClass;
@@ -69,6 +68,55 @@ public class AzureSpringFunctionInitializer implements Closeable {
 		this(getStartClass());
 	}
 
+	private static Class<?> getStartClass() {
+		ClassLoader classLoader = org.springframework.cloud.function.adapter.azure.AzureSpringFunctionInitializer.class
+				.getClassLoader();
+		if (System.getenv("MAIN_CLASS") != null) {
+			return ClassUtils.resolveClassName(System.getenv("MAIN_CLASS"), classLoader);
+		}
+		try {
+			Class<?> result = getStartClass(
+					Collections.list(classLoader.getResources("META-INF/MANIFEST.MF")));
+			if (result == null) {
+				result = getStartClass(Collections
+						.list(classLoader.getResources("meta-inf/manifest.mf")));
+			}
+			return result;
+		}
+		catch (Exception ex) {
+			return null;
+		}
+	}
+
+	private static Class<?> getStartClass(List<URL> list) {
+		for (URL url : list) {
+			try {
+				InputStream inputStream = url.openStream();
+				try {
+					Manifest manifest = new Manifest(inputStream);
+					String startClass = manifest.getMainAttributes()
+							.getValue("Main-Class");
+					if (startClass != null) {
+						Class<?> aClass = ClassUtils.forName(startClass,
+								org.springframework.cloud.function.adapter.azure.AzureSpringFunctionInitializer.class
+										.getClassLoader());
+						SpringBootApplication declaredAnnotation = aClass
+								.getDeclaredAnnotation(SpringBootApplication.class);
+						if (declaredAnnotation != null) {
+							return aClass;
+						}
+					}
+				}
+				finally {
+					inputStream.close();
+				}
+			}
+			catch (Exception ex) {
+			}
+		}
+		return null;
+	}
+
 	@Override
 	public void close() throws IOException {
 		if (AzureSpringFunctionInitializer.context != null) {
@@ -132,7 +180,7 @@ public class AzureSpringFunctionInitializer implements Closeable {
 	}
 
 	private SpringApplication springApplication() {
-		Class<?> sourceClass = configurationClass;
+		Class<?> sourceClass = this.configurationClass;
 		SpringApplication application = new org.springframework.cloud.function.context.FunctionalSpringApplication(
 				sourceClass);
 		application.setWebApplicationType(WebApplicationType.NONE);
@@ -144,7 +192,8 @@ public class AzureSpringFunctionInitializer implements Closeable {
 			return true;
 		}
 		if (this.inspector != null) {
-			return Collection.class.isAssignableFrom(inspector.getInputType(function));
+			return Collection.class
+					.isAssignableFrom(this.inspector.getInputType(function));
 		}
 		return ((Collection<?>) input).size() <= 1;
 	}
@@ -154,7 +203,8 @@ public class AzureSpringFunctionInitializer implements Closeable {
 			return true;
 		}
 		if (this.inspector != null) {
-			return Collection.class.isAssignableFrom(inspector.getOutputType(function));
+			return Collection.class
+					.isAssignableFrom(this.inspector.getOutputType(function));
 		}
 		return ((Collection<?>) output).size() <= 1;
 	}
@@ -174,64 +224,16 @@ public class AzureSpringFunctionInitializer implements Closeable {
 		throw new IllegalStateException("No function defined with name=" + name);
 	}
 
-	private static Class<?> getStartClass() {
-		ClassLoader classLoader = org.springframework.cloud.function.adapter.azure.AzureSpringFunctionInitializer.class
-				.getClassLoader();
-		if (System.getenv("MAIN_CLASS") != null) {
-			return ClassUtils.resolveClassName(System.getenv("MAIN_CLASS"), classLoader);
-		}
-		try {
-			Class<?> result = getStartClass(
-					Collections.list(classLoader.getResources("META-INF/MANIFEST.MF")));
-			if (result == null) {
-				result = getStartClass(Collections
-						.list(classLoader.getResources("meta-inf/manifest.mf")));
-			}
-			return result;
-		}
-		catch (Exception ex) {
-			return null;
-		}
-	}
-
-	private static Class<?> getStartClass(List<URL> list) {
-		for (URL url : list) {
-			try {
-				InputStream inputStream = url.openStream();
-				try {
-					Manifest manifest = new Manifest(inputStream);
-					String startClass = manifest.getMainAttributes()
-							.getValue("Main-Class");
-					if (startClass != null) {
-						Class<?> aClass = ClassUtils.forName(startClass,
-								org.springframework.cloud.function.adapter.azure.AzureSpringFunctionInitializer.class
-										.getClassLoader());
-						SpringBootApplication declaredAnnotation = aClass
-								.getDeclaredAnnotation(SpringBootApplication.class);
-						if (declaredAnnotation != null) {
-							return aClass;
-						}
-					}
-				}
-				finally {
-					inputStream.close();
-				}
-			}
-			catch (Exception ex) {
-			}
-		}
-		return null;
-	}
-
 	public Function<Publisher<?>, Publisher<?>> getFunction() {
-		return function;
+		return this.function;
 	}
 
 	public FunctionCatalog getCatalog() {
-		return catalog;
+		return this.catalog;
 	}
 
 	public FunctionInspector getInspector() {
-		return inspector;
+		return this.inspector;
 	}
+
 }

spring-cloud-function-adapters/spring-cloud-function-adapter-azure/src/test/java/org/springframework/cloud/function/adapter/azure/AzureSpringBootRequestHandlerTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2018 the original author or authors.
+ * Copyright 2012-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@ import java.util.stream.Collectors;
 
 import org.junit.After;
 import org.junit.Test;
+import reactor.core.publisher.Flux;
 
 import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
 import org.springframework.context.annotation.Bean;
@@ -31,8 +32,6 @@ import org.springframework.context.annotation.Configuration;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-import reactor.core.publisher.Flux;
-
 /**
  * @author Dave Syer
  *
@@ -114,50 +113,60 @@ public class AzureSpringBootRequestHandlerTests {
 
 	@After
 	public void close() throws IOException {
-		if (handler != null)
-			handler.close();
+		if (this.handler != null) {
+			this.handler.close();
+		}
 	}
 
 	@Configuration
 	protected static class BareConfig {
+
 		@Bean
 		public Function<Flux<Foo>, Flux<Bar>> function() {
 			return foos -> foos.map(foo -> new Bar(foo.getValue().toUpperCase()));
 		}
+
 	}
 
 	@Configuration
 	@EnableAutoConfiguration
 	protected static class AutoConfig {
+
 		@Bean
 		public Function<Foo, Bar> uppercase() {
 			return foo -> new Bar(foo.getValue().toUpperCase());
 		}
+
 	}
 
 	@Configuration
 	@EnableAutoConfiguration
 	protected static class ListConfig {
+
 		@Bean
 		public Function<List<Foo>, List<Bar>> uppercase() {
 			return foos -> foos.stream().map(foo -> new Bar(foo.getValue().toUpperCase()))
 					.collect(Collectors.toList());
 		}
+
 	}
 
 	@Configuration
 	@EnableAutoConfiguration
 	protected static class CollectConfig {
+
 		@Bean
 		public Function<List<Foo>, Bar> uppercase() {
 			return foos -> new Bar(foos.stream().map(foo -> foo.getValue().toUpperCase())
 					.collect(Collectors.joining(",")));
 		}
+
 	}
 
 	@Configuration
 	@EnableAutoConfiguration
 	protected static class MultiConfig {
+
 		@Bean
 		public Function<Foo, Bar> uppercase() {
 			return foo -> new Bar(foo.getValue().toUpperCase());
@@ -167,6 +176,7 @@ public class AzureSpringBootRequestHandlerTests {
 		public Function<Bar, Foo> lowercase() {
 			return bar -> new Foo(bar.getValue().toLowerCase());
 		}
+
 	}
 
 }
@@ -178,25 +188,26 @@ class Foo {
 	Foo() {
 	}
 
-	public String lowercase() {
-		return value.toLowerCase();
-	}
-
 	public Foo(String value) {
 		this.value = value;
 	}
 
+	public String lowercase() {
+		return this.value.toLowerCase();
+	}
+
 	public String uppercase() {
-		return value.toUpperCase();
+		return this.value.toUpperCase();
 	}
 
 	public String getValue() {
-		return value;
+		return this.value;
 	}
 
 	public void setValue(String value) {
 		this.value = value;
 	}
+
 }
 
 class Bar {
@@ -211,11 +222,11 @@ class Bar {
 	}
 
 	public String getValue() {
-		return value;
+		return this.value;
 	}
 
 	public void setValue(String value) {
 		this.value = value;
 	}
 
-}
+}

spring-cloud-function-adapters/spring-cloud-function-adapter-azure/src/test/java/org/springframework/cloud/function/adapter/azure/AzureSpringFunctionInitializerTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2017 the original author or authors.
+ * Copyright 2012-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,6 +20,7 @@ import java.util.function.Function;
 
 import org.junit.After;
 import org.junit.Test;
+import reactor.core.publisher.Flux;
 
 import org.springframework.boot.SpringBootConfiguration;
 import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
@@ -31,8 +32,6 @@ import org.springframework.context.support.GenericApplicationContext;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-import reactor.core.publisher.Flux;
-
 /**
  * @author Dave Syer
  *
@@ -50,8 +49,9 @@ public class AzureSpringFunctionInitializerTests {
 
 	@After
 	public void close() throws IOException {
-		if (handler != null)
-			handler.close();
+		if (this.handler != null) {
+			this.handler.close();
+		}
 	}
 
 	@Test
@@ -84,18 +84,22 @@ public class AzureSpringFunctionInitializerTests {
 	@SpringBootConfiguration
 	@EnableAutoConfiguration
 	protected static class BareConfig {
+
 		@Bean
 		public Function<Foo, Bar> function() {
 			return foo -> new Bar(foo.getValue().toUpperCase());
 		}
+
 	}
 
 	@SpringBootConfiguration
 	protected static class FunctionConfig implements Function<Foo, Bar> {
+
 		@Override
 		public Bar apply(Foo foo) {
 			return new Bar(foo.getValue().toUpperCase());
 		}
+
 	}
 
 	@SpringBootConfiguration
@@ -113,5 +117,7 @@ public class AzureSpringFunctionInitializerTests {
 							"uppercase")
 									.type(FunctionType.from(Foo.class).to(Bar.class)));
 		}
+
 	}
+
 }

spring-cloud-function-adapters/spring-cloud-function-adapter-azure/src/test/java/org/springframework/cloud/function/adapter/azure/TestExecutionContext.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2018 the original author or authors.
+ * Copyright 2012-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -22,6 +22,7 @@ import java.util.logging.Logger;
 import com.microsoft.azure.functions.ExecutionContext;
 
 public class TestExecutionContext implements ExecutionContext {
+
 	private String name;
 
 	public TestExecutionContext(String name) {
@@ -40,6 +41,7 @@ public class TestExecutionContext implements ExecutionContext {
 
 	@Override
 	public String getFunctionName() {
-		return name;
+		return this.name;
 	}
-}
+
+}