From d585f5155738f82a9137f65180dc2f5139959df0 Mon Sep 17 00:00:00 2001
From: SpaceFox <ujueseo.yeou@gmail.com>
Date: Tue, 24 Mar 2020 12:21:47 +0100
Subject: [PATCH] Adds filter naming convention documentation

fixes gh-1859
fixes gh-1636
---
 docs/src/main/asciidoc/spring-cloud-gateway.adoc | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/docs/src/main/asciidoc/spring-cloud-gateway.adoc b/docs/src/main/asciidoc/spring-cloud-gateway.adoc
index 5ecc9b8f..db693e30 100644
--- a/docs/src/main/asciidoc/spring-cloud-gateway.adoc
+++ b/docs/src/main/asciidoc/spring-cloud-gateway.adoc
@@ -2601,7 +2601,7 @@ public class PreGatewayFilterFactory extends AbstractGatewayFilterFactory<PreGat
 			//request before calling chain.filter
 			ServerHttpRequest.Builder builder = exchange.getRequest().mutate();
 			//use builder to manipulate the request
-			return chain.filter(exchange.mutate().request(request).build());
+			return chain.filter(exchange.mutate().request(builder.build()).build());
 		};
 	}
 
@@ -2640,6 +2640,19 @@ public class PostGatewayFilterFactory extends AbstractGatewayFilterFactory<PostG
 ----
 ====
 
+==== Naming Custom Filters And References In Configuration
+
+Custom filters class names should end in `GatewayFilterFactory`.
+
+For example, to reference a filter named `Something` in configuration files, the filter
+must be in a class named `SomethingGatewayFilterFactory`.
+
+WARNING: It is possible to create a gateway filter named without the
+`GatewayFilterFactory` suffix, such as `class AnotherThing`. This filter could be
+referenced as `AnotherThing` in configuration files. This is **not** a supported naming
+convention and this syntax may be removed in future releases. Please update the filter
+name to be compliant.
+
 === Writing Custom Global Filters
 
 To write a custom global filter, you must implement `GlobalFilter` interface.