From 36dcaf32171cb07fdf328a410ce92f6b64c2cda3 Mon Sep 17 00:00:00 2001 From: Spencer Gibb Date: Tue, 10 Oct 2017 12:16:56 -0400 Subject: [PATCH] Add warning if Spring MVC is on the classpath. fixes gh-80 --- ...ewayClassPathWarningAutoConfiguration.java | 19 +++++++++++++++++++ .../main/resources/META-INF/spring.factories | 1 + 2 files changed, 20 insertions(+) create mode 100644 spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/config/GatewayClassPathWarningAutoConfiguration.java diff --git a/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/config/GatewayClassPathWarningAutoConfiguration.java b/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/config/GatewayClassPathWarningAutoConfiguration.java new file mode 100644 index 00000000..6a8e583d --- /dev/null +++ b/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/config/GatewayClassPathWarningAutoConfiguration.java @@ -0,0 +1,19 @@ +package org.springframework.cloud.gateway.config; + +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; +import org.springframework.boot.autoconfigure.condition.ConditionalOnClass; +import org.springframework.context.annotation.Configuration; + +@Configuration +@ConditionalOnClass(name = "org.springframework.web.servlet.DispatcherServlet") +public class GatewayClassPathWarningAutoConfiguration { + + private static final Log log = LogFactory.getLog(GatewayClassPathWarningAutoConfiguration.class); + private static final String BORDER = "\n\n**********************************************************\n\n"; + + public GatewayClassPathWarningAutoConfiguration() { + log.warn(BORDER+"Spring MVC found on classpath, which is incompatible with Spring Cloud Gateway at this time. "+ + "Please remove spring-boot-starter-web dependency."+BORDER); + } +} diff --git a/spring-cloud-gateway-core/src/main/resources/META-INF/spring.factories b/spring-cloud-gateway-core/src/main/resources/META-INF/spring.factories index f255ea7b..f831db65 100644 --- a/spring-cloud-gateway-core/src/main/resources/META-INF/spring.factories +++ b/spring-cloud-gateway-core/src/main/resources/META-INF/spring.factories @@ -1,5 +1,6 @@ # Auto Configure org.springframework.boot.autoconfigure.EnableAutoConfiguration=\ org.springframework.cloud.gateway.config.GatewayAutoConfiguration,\ +org.springframework.cloud.gateway.config.GatewayClassPathWarningAutoConfiguration,\ org.springframework.cloud.gateway.config.GatewayLoadBalancerClientAutoConfiguration,\ org.springframework.cloud.gateway.config.GatewayRedisAutoConfiguration