From 47595a7e3a6fd9da19664c4facd639bd363324d7 Mon Sep 17 00:00:00 2001 From: Olga MaciaszekSharma Date: Fri, 2 Jul 2021 19:05:35 +0200 Subject: [PATCH] Reformat. --- .../config/GatewayRedisAutoConfiguration.java | 3 +-- .../filter/headers/ForwardedHeadersFilter.java | 3 ++- .../filter/headers/ForwardedHeadersFilterTests.java | 12 ++++++++---- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/config/GatewayRedisAutoConfiguration.java b/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/config/GatewayRedisAutoConfiguration.java index 78ee06ad..e912d1c9 100644 --- a/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/config/GatewayRedisAutoConfiguration.java +++ b/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/config/GatewayRedisAutoConfiguration.java @@ -44,8 +44,7 @@ import org.springframework.web.reactive.DispatcherHandler; @AutoConfigureBefore(GatewayAutoConfiguration.class) @ConditionalOnBean(ReactiveRedisTemplate.class) @ConditionalOnClass({ RedisTemplate.class, DispatcherHandler.class }) -@ConditionalOnProperty(name = "spring.cloud.gateway.redis.enabled", - matchIfMissing = true) +@ConditionalOnProperty(name = "spring.cloud.gateway.redis.enabled", matchIfMissing = true) class GatewayRedisAutoConfiguration { @Bean diff --git a/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/headers/ForwardedHeadersFilter.java b/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/headers/ForwardedHeadersFilter.java index ab00f643..04592e28 100644 --- a/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/headers/ForwardedHeadersFilter.java +++ b/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/headers/ForwardedHeadersFilter.java @@ -125,7 +125,8 @@ public class ForwardedHeadersFilter implements HttpHeadersFilter, Ordered { String forValue; if (remoteAddress.isUnresolved()) { forValue = remoteAddress.getHostName(); - } else { + } + else { InetAddress address = remoteAddress.getAddress(); forValue = remoteAddress.getAddress().getHostAddress(); if (address instanceof Inet6Address) { diff --git a/spring-cloud-gateway-server/src/test/java/org/springframework/cloud/gateway/filter/headers/ForwardedHeadersFilterTests.java b/spring-cloud-gateway-server/src/test/java/org/springframework/cloud/gateway/filter/headers/ForwardedHeadersFilterTests.java index 677077e7..4d6b0104 100644 --- a/spring-cloud-gateway-server/src/test/java/org/springframework/cloud/gateway/filter/headers/ForwardedHeadersFilterTests.java +++ b/spring-cloud-gateway-server/src/test/java/org/springframework/cloud/gateway/filter/headers/ForwardedHeadersFilterTests.java @@ -134,21 +134,25 @@ public class ForwardedHeadersFilterTests { @Test public void correctIPv6RemoteAddressMapping() throws UnknownHostException { MockServerHttpRequest request = MockServerHttpRequest.get("http://localhost/get") - .remoteAddress(new InetSocketAddress(InetAddress.getByName("2001:db8:cafe:0:0:0:0:17"), 80)) + .remoteAddress(new InetSocketAddress( + InetAddress.getByName("2001:db8:cafe:0:0:0:0:17"), 80)) .header(HttpHeaders.HOST, "myhost").build(); ForwardedHeadersFilter filter = new ForwardedHeadersFilter(); - HttpHeaders headers = filter.filter(request.getHeaders(), MockServerWebExchange.from(request)); + HttpHeaders headers = filter.filter(request.getHeaders(), + MockServerWebExchange.from(request)); assertThat(headers.get(FORWARDED_HEADER)).hasSize(1); - List forwardeds = ForwardedHeadersFilter.parse(headers.get(FORWARDED_HEADER)); + List forwardeds = ForwardedHeadersFilter + .parse(headers.get(FORWARDED_HEADER)); assertThat(forwardeds).hasSize(1); Forwarded forwarded = forwardeds.get(0); - assertThat(forwarded.getValues()).containsEntry("for", "\"[2001:db8:cafe:0:0:0:0:17]:80\""); + assertThat(forwarded.getValues()).containsEntry("for", + "\"[2001:db8:cafe:0:0:0:0:17]:80\""); } @Test