From da8feee32e574387f71b7a1a5a383fbf0f961835 Mon Sep 17 00:00:00 2001
From: Spencer Gibb <spencer@gibb.us>
Date: Thu, 7 Feb 2019 15:25:06 -0500
Subject: [PATCH 1/2] Disables jmx for test

---
 .../GatewayNoLoadBalancerClientAutoConfigurationTests.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spring-cloud-gateway-core/src/test/java/org/springframework/cloud/gateway/config/GatewayNoLoadBalancerClientAutoConfigurationTests.java b/spring-cloud-gateway-core/src/test/java/org/springframework/cloud/gateway/config/GatewayNoLoadBalancerClientAutoConfigurationTests.java
index fe613369..2ca9df93 100644
--- a/spring-cloud-gateway-core/src/test/java/org/springframework/cloud/gateway/config/GatewayNoLoadBalancerClientAutoConfigurationTests.java
+++ b/spring-cloud-gateway-core/src/test/java/org/springframework/cloud/gateway/config/GatewayNoLoadBalancerClientAutoConfigurationTests.java
@@ -51,7 +51,7 @@ public class GatewayNoLoadBalancerClientAutoConfigurationTests {
 	@Test
 	public void noLoadBalancerClientReportsError() {
 		try (ConfigurableApplicationContext context = new SpringApplication(Config.class)
-				.run("--server.port="+port)) {
+				.run("--server.port="+port, "--spring.jmx.enabled=false")) {
 			WebTestClient client = WebTestClient.bindToServer().baseUrl("http://localhost:" + port).build();
 			client.get()
 					.header(HttpHeaders.HOST, "www.lbfail.org")

From 8fd35c55b1e2175d0cf77f83394fed52a26aeb2f Mon Sep 17 00:00:00 2001
From: Alex Simons <alexsimons9999@gmail.com>
Date: Wed, 13 Feb 2019 09:05:19 -0600
Subject: [PATCH 2/2] Revisited documentation about writing a custom global
 pre/post-filter (#836)

* Added documentation about writing a custom global pre/post-filter

* Removed unnecessary words about GlobalFilter.

* Added back removed section title
---
 .../main/asciidoc/spring-cloud-gateway.adoc   | 33 ++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/docs/src/main/asciidoc/spring-cloud-gateway.adoc b/docs/src/main/asciidoc/spring-cloud-gateway.adoc
index dd397b13..f7d731d1 100644
--- a/docs/src/main/asciidoc/spring-cloud-gateway.adoc
+++ b/docs/src/main/asciidoc/spring-cloud-gateway.adoc
@@ -1387,7 +1387,38 @@ public class PostGatewayFilterFactory extends AbstractGatewayFilterFactory<PostG
 
 === Writing Custom Global Filters
 
-TODO: document writing Custom Global Filters
+In order to write a custom global filter, you will need to implement `GlobalFilter` interface. This will apply the filter to all requests.
+
+Example of how to set up a Global Pre and Post filter, respectively
+
+[source,java]
+----
+@Bean
+public GlobalFilter customGlobalFilter() {
+    return (exchange, chain) -> exchange.getPrincipal()
+        .map(Principal::getName)
+        .defaultIfEmpty("Default User")
+        .map(userName -> {
+          //adds header to proxied request
+          exchange.getRequest().mutate().header("CUSTOM-REQUEST-HEADER", userName).build();
+          return exchange;
+        })
+        .flatMap(chain::filter);
+}
+
+@Bean
+public GlobalFilter customGlobalPostFilter() {
+    return (exchange, chain) -> chain.filter(exchange)
+        .then(Mono.just(exchange))
+        .map(serverWebExchange -> {
+          //adds header to response
+          serverWebExchange.getResponse().getHeaders().set("CUSTOM-RESPONSE-HEADER",
+              HttpStatus.OK.equals(serverWebExchange.getResponse().getStatusCode()) ? "It worked": "It did not work");
+          return serverWebExchange;
+        })
+        .then();
+}
+---
 
 === Writing Custom Route Locators and Writers