diff --git a/docs/pom.xml b/docs/pom.xml
index da589be4..2b418984 100644
--- a/docs/pom.xml
+++ b/docs/pom.xml
@@ -6,7 +6,7 @@
org.springframework.cloud
spring-cloud-gateway
- 4.0.3-SNAPSHOT
+ 4.0.4-SNAPSHOT
spring-cloud-gateway-docs
jar
diff --git a/pom.xml b/pom.xml
index 7fc73b4f..7b587f9b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -6,7 +6,7 @@
org.springframework.cloud
spring-cloud-gateway
- 4.0.3-SNAPSHOT
+ 4.0.4-SNAPSHOT
pom
Spring Cloud Gateway
diff --git a/spring-cloud-gateway-dependencies/pom.xml b/spring-cloud-gateway-dependencies/pom.xml
index a8636c3a..4c26e126 100644
--- a/spring-cloud-gateway-dependencies/pom.xml
+++ b/spring-cloud-gateway-dependencies/pom.xml
@@ -11,7 +11,7 @@
spring-cloud-gateway-dependencies
- 4.0.3-SNAPSHOT
+ 4.0.4-SNAPSHOT
pom
spring-cloud-gateway-dependencies
diff --git a/spring-cloud-gateway-integration-tests/grpc/pom.xml b/spring-cloud-gateway-integration-tests/grpc/pom.xml
index 88767a5f..98f76dd0 100644
--- a/spring-cloud-gateway-integration-tests/grpc/pom.xml
+++ b/spring-cloud-gateway-integration-tests/grpc/pom.xml
@@ -17,7 +17,7 @@
org.springframework.cloud
spring-cloud-gateway-integration-tests
- 4.0.3-SNAPSHOT
+ 4.0.4-SNAPSHOT
..
diff --git a/spring-cloud-gateway-integration-tests/http2/pom.xml b/spring-cloud-gateway-integration-tests/http2/pom.xml
index 66954306..51d83745 100644
--- a/spring-cloud-gateway-integration-tests/http2/pom.xml
+++ b/spring-cloud-gateway-integration-tests/http2/pom.xml
@@ -16,7 +16,7 @@
org.springframework.cloud
spring-cloud-gateway-integration-tests
- 4.0.3-SNAPSHOT
+ 4.0.4-SNAPSHOT
..
diff --git a/spring-cloud-gateway-integration-tests/mvc-failure-analyzer/pom.xml b/spring-cloud-gateway-integration-tests/mvc-failure-analyzer/pom.xml
index 0c28db6e..c1a55a43 100644
--- a/spring-cloud-gateway-integration-tests/mvc-failure-analyzer/pom.xml
+++ b/spring-cloud-gateway-integration-tests/mvc-failure-analyzer/pom.xml
@@ -16,7 +16,7 @@
org.springframework.cloud
spring-cloud-gateway-integration-tests
- 4.0.3-SNAPSHOT
+ 4.0.4-SNAPSHOT
..
diff --git a/spring-cloud-gateway-integration-tests/pom.xml b/spring-cloud-gateway-integration-tests/pom.xml
index 18a0d38a..970327de 100644
--- a/spring-cloud-gateway-integration-tests/pom.xml
+++ b/spring-cloud-gateway-integration-tests/pom.xml
@@ -16,7 +16,7 @@
org.springframework.cloud
spring-cloud-gateway
- 4.0.3-SNAPSHOT
+ 4.0.4-SNAPSHOT
..
diff --git a/spring-cloud-gateway-mvc/pom.xml b/spring-cloud-gateway-mvc/pom.xml
index 31cd52c1..97eb510e 100644
--- a/spring-cloud-gateway-mvc/pom.xml
+++ b/spring-cloud-gateway-mvc/pom.xml
@@ -11,7 +11,7 @@
org.springframework.cloud
spring-cloud-gateway
- 4.0.3-SNAPSHOT
+ 4.0.4-SNAPSHOT
..
diff --git a/spring-cloud-gateway-sample/pom.xml b/spring-cloud-gateway-sample/pom.xml
index 97554a3f..d1fb913e 100644
--- a/spring-cloud-gateway-sample/pom.xml
+++ b/spring-cloud-gateway-sample/pom.xml
@@ -16,7 +16,7 @@
org.springframework.cloud
spring-cloud-gateway
- 4.0.3-SNAPSHOT
+ 4.0.4-SNAPSHOT
..
diff --git a/spring-cloud-gateway-server/pom.xml b/spring-cloud-gateway-server/pom.xml
index b0d81592..0134d282 100644
--- a/spring-cloud-gateway-server/pom.xml
+++ b/spring-cloud-gateway-server/pom.xml
@@ -7,7 +7,7 @@
org.springframework.cloud
spring-cloud-gateway
- 4.0.3-SNAPSHOT
+ 4.0.4-SNAPSHOT
..
spring-cloud-gateway-server
diff --git a/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/headers/observation/ObservedResponseHttpHeadersFilter.java b/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/headers/observation/ObservedResponseHttpHeadersFilter.java
index 135bd560..1902b6e5 100644
--- a/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/headers/observation/ObservedResponseHttpHeadersFilter.java
+++ b/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/headers/observation/ObservedResponseHttpHeadersFilter.java
@@ -44,13 +44,15 @@ public class ObservedResponseHttpHeadersFilter implements HttpHeadersFilter {
if (childObservation == null) {
return input;
}
- GatewayContext context = (GatewayContext) childObservation.getContext();
- if (log.isDebugEnabled()) {
- log.debug("Will instrument the response");
- }
- context.setResponse(exchange.getResponse());
- if (log.isDebugEnabled()) {
- log.debug("The response was handled for observation " + childObservation);
+ Observation.Context childObservationContext = childObservation.getContext();
+ if (childObservationContext instanceof GatewayContext context) {
+ if (log.isDebugEnabled()) {
+ log.debug("Will instrument the response");
+ }
+ context.setResponse(exchange.getResponse());
+ if (log.isDebugEnabled()) {
+ log.debug("The response was handled for observation " + childObservation);
+ }
}
childObservation.stop();
exchange.getAttributes().put(OBSERVATION_STOPPED, "true");
diff --git a/spring-cloud-gateway-server/src/test/java/org/springframework/cloud/gateway/filter/headers/observation/ObservedResponseHttpHeadersFilterTests.java b/spring-cloud-gateway-server/src/test/java/org/springframework/cloud/gateway/filter/headers/observation/ObservedResponseHttpHeadersFilterTests.java
new file mode 100644
index 00000000..64ba0135
--- /dev/null
+++ b/spring-cloud-gateway-server/src/test/java/org/springframework/cloud/gateway/filter/headers/observation/ObservedResponseHttpHeadersFilterTests.java
@@ -0,0 +1,42 @@
+/*
+ * Copyright 2013-2022 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.cloud.gateway.filter.headers.observation;
+
+import io.micrometer.observation.Observation;
+import org.junit.jupiter.api.Test;
+
+import org.springframework.cloud.gateway.support.ServerWebExchangeUtils;
+import org.springframework.http.HttpHeaders;
+import org.springframework.mock.http.server.reactive.MockServerHttpRequest;
+import org.springframework.mock.web.server.MockServerWebExchange;
+import org.springframework.web.server.ServerWebExchange;
+
+import static org.assertj.core.api.BDDAssertions.thenNoException;
+
+class ObservedResponseHttpHeadersFilterTests {
+
+ @Test
+ void shouldDoNothingWhenObservationIsNoOp() {
+ MockServerHttpRequest request = MockServerHttpRequest.get("/get").build();
+ ServerWebExchange exchange = MockServerWebExchange.from(request);
+ exchange.getAttributes().put(ServerWebExchangeUtils.GATEWAY_OBSERVATION_ATTR, Observation.NOOP);
+ ObservedResponseHttpHeadersFilter filter = new ObservedResponseHttpHeadersFilter();
+
+ thenNoException().isThrownBy(() -> filter.filter(new HttpHeaders(), exchange));
+ }
+
+}
diff --git a/spring-cloud-gateway-webflux/pom.xml b/spring-cloud-gateway-webflux/pom.xml
index 092ef82d..6a327e65 100644
--- a/spring-cloud-gateway-webflux/pom.xml
+++ b/spring-cloud-gateway-webflux/pom.xml
@@ -11,7 +11,7 @@
org.springframework.cloud
spring-cloud-gateway
- 4.0.3-SNAPSHOT
+ 4.0.4-SNAPSHOT
..
diff --git a/spring-cloud-starter-gateway/pom.xml b/spring-cloud-starter-gateway/pom.xml
index b81fe367..c336304a 100644
--- a/spring-cloud-starter-gateway/pom.xml
+++ b/spring-cloud-starter-gateway/pom.xml
@@ -6,7 +6,7 @@
org.springframework.cloud
spring-cloud-gateway
- 4.0.3-SNAPSHOT
+ 4.0.4-SNAPSHOT
..
spring-cloud-starter-gateway