From efdb355b885b8ffb5d9f0b925d6e8723c8265b26 Mon Sep 17 00:00:00 2001
From: Spencer Gibb <spencer@gibb.us>
Date: Fri, 14 Apr 2017 21:38:52 -0600
Subject: [PATCH] Adds some rate limiter todos

---
 .../filter/factory/RequestRateLimiterWebFilterFactory.java  | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/filter/factory/RequestRateLimiterWebFilterFactory.java b/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/filter/factory/RequestRateLimiterWebFilterFactory.java
index ffb56fea..adb91712 100644
--- a/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/filter/factory/RequestRateLimiterWebFilterFactory.java
+++ b/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/filter/factory/RequestRateLimiterWebFilterFactory.java
@@ -55,7 +55,9 @@ public class RequestRateLimiterWebFilterFactory implements WebFilterFactory {
 		int capacity = 5 * replenishRate;
 
 		return (exchange, chain) -> {
-			boolean allowed = isAllowed(replenishRate, capacity, "me"); //TODO: get user from request
+			// exchange.getPrincipal().flatMap(principal -> {})
+			//TODO: get user from request, maybe a KeyResolutionStrategy.resolve(exchange). Lookup strategy bean via arg
+			boolean allowed = isAllowed(replenishRate, capacity, "me");
 
 			if (allowed) {
 				return chain.filter(exchange);
@@ -65,6 +67,8 @@ public class RequestRateLimiterWebFilterFactory implements WebFilterFactory {
 		};
 	}
 
+	//TODO: move to interface
+	//TODO: use tuple args except for id
 	/* for testing */ boolean isAllowed(int replenishRate, int capacity, String id) {
 		boolean allowed = false;