From 243ab13f90359f6c91a50cb339b925d23bd38b2c Mon Sep 17 00:00:00 2001 From: erabii Date: Fri, 28 Oct 2022 23:49:02 +0300 Subject: [PATCH] move a tiny class to a record (#1122) --- .../DiscoveryServerController.java | 51 +------------------ 1 file changed, 2 insertions(+), 49 deletions(-) diff --git a/spring-cloud-kubernetes-controllers/spring-cloud-kubernetes-discoveryserver/src/main/java/org/springframewok/cloud/kubernetes/discoveryserver/DiscoveryServerController.java b/spring-cloud-kubernetes-controllers/spring-cloud-kubernetes-discoveryserver/src/main/java/org/springframewok/cloud/kubernetes/discoveryserver/DiscoveryServerController.java index 612a361a..d7453096 100644 --- a/spring-cloud-kubernetes-controllers/spring-cloud-kubernetes-discoveryserver/src/main/java/org/springframewok/cloud/kubernetes/discoveryserver/DiscoveryServerController.java +++ b/spring-cloud-kubernetes-controllers/spring-cloud-kubernetes-discoveryserver/src/main/java/org/springframewok/cloud/kubernetes/discoveryserver/DiscoveryServerController.java @@ -17,7 +17,6 @@ package org.springframewok.cloud.kubernetes.discoveryserver; import java.util.List; -import java.util.Objects; import reactor.core.publisher.Flux; import reactor.core.publisher.Mono; @@ -34,7 +33,7 @@ import org.springframework.web.bind.annotation.RestController; @RestController public class DiscoveryServerController { - private KubernetesInformerReactiveDiscoveryClient reactiveDiscoveryClient; + private final KubernetesInformerReactiveDiscoveryClient reactiveDiscoveryClient; public DiscoveryServerController(KubernetesInformerReactiveDiscoveryClient reactiveDiscoveryClient) { this.reactiveDiscoveryClient = reactiveDiscoveryClient; @@ -57,53 +56,7 @@ public class DiscoveryServerController { .filter(serviceInstance -> serviceInstance.getInstanceId().equals(instanceId)).singleOrEmpty(); } - public static class Service { - - private String name; - - private List serviceInstances; - - public Service() { - } - - public Service(String name, List serviceInstances) { - this.name = name; - this.serviceInstances = serviceInstances; - } - - public String getName() { - return name; - } - - public void setName(String name) { - this.name = name; - } - - public List getServiceInstances() { - return serviceInstances; - } - - public void setServiceInstances(List serviceInstances) { - this.serviceInstances = serviceInstances; - } - - @Override - public boolean equals(Object o) { - if (this == o) { - return true; - } - if (o == null || getClass() != o.getClass()) { - return false; - } - Service service = (Service) o; - return Objects.equals(getName(), service.getName()) - && Objects.equals(getServiceInstances(), service.getServiceInstances()); - } - - @Override - public int hashCode() { - return Objects.hash(getName(), getServiceInstances()); - } + private record Service(String name, List serviceInstances) { }