From 3eab7fa49a339ac7193a596d99243965bdaa3478 Mon Sep 17 00:00:00 2001 From: Gytis Trikleris Date: Thu, 24 May 2018 19:28:12 +0200 Subject: [PATCH] KubernetesLock#unlock() --- .../springframework/cloud/kubernetes/lock/KubernetesLock.java | 3 +-- .../cloud/kubernetes/lock/KubernetesLockTest.java | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/spring-cloud-kubernetes-lock/src/main/java/org/springframework/cloud/kubernetes/lock/KubernetesLock.java b/spring-cloud-kubernetes-lock/src/main/java/org/springframework/cloud/kubernetes/lock/KubernetesLock.java index d6b78759..0119f247 100644 --- a/spring-cloud-kubernetes-lock/src/main/java/org/springframework/cloud/kubernetes/lock/KubernetesLock.java +++ b/spring-cloud-kubernetes-lock/src/main/java/org/springframework/cloud/kubernetes/lock/KubernetesLock.java @@ -84,8 +84,7 @@ public class KubernetesLock implements Lock { @Override public void unlock() { - // TODO delete configmap for this lock - // TODO consider only allowing lock release only from the same application and/or thread + repository.delete(name); } @Override diff --git a/spring-cloud-kubernetes-lock/src/test/java/org/springframework/cloud/kubernetes/lock/KubernetesLockTest.java b/spring-cloud-kubernetes-lock/src/test/java/org/springframework/cloud/kubernetes/lock/KubernetesLockTest.java index 7cb623ee..2e6f6da0 100644 --- a/spring-cloud-kubernetes-lock/src/test/java/org/springframework/cloud/kubernetes/lock/KubernetesLockTest.java +++ b/spring-cloud-kubernetes-lock/src/test/java/org/springframework/cloud/kubernetes/lock/KubernetesLockTest.java @@ -148,7 +148,9 @@ public class KubernetesLockTest { @Test public void shouldUnlock() { + lock.unlock(); + verify(repository).delete(NAME); } @Test(expected = UnsupportedOperationException.class)