From f2cd42b17fa27bfb19e669e4ba3f9cfe65659fab Mon Sep 17 00:00:00 2001 From: Ryan Baxter Date: Mon, 8 Feb 2021 16:54:55 -0500 Subject: [PATCH] Fixing namespace condition. Fixes #732 --- .../client/discovery/KubernetesInformerDiscoveryClient.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-cloud-kubernetes-client-discovery/src/main/java/org/springframework/cloud/kubernetes/client/discovery/KubernetesInformerDiscoveryClient.java b/spring-cloud-kubernetes-client-discovery/src/main/java/org/springframework/cloud/kubernetes/client/discovery/KubernetesInformerDiscoveryClient.java index 920c872c..bf47b9c2 100644 --- a/spring-cloud-kubernetes-client-discovery/src/main/java/org/springframework/cloud/kubernetes/client/discovery/KubernetesInformerDiscoveryClient.java +++ b/spring-cloud-kubernetes-client-discovery/src/main/java/org/springframework/cloud/kubernetes/client/discovery/KubernetesInformerDiscoveryClient.java @@ -83,7 +83,7 @@ public class KubernetesInformerDiscoveryClient implements DiscoveryClient, Initi public List getInstances(String serviceId) { Assert.notNull(serviceId, "[Assertion failed] - the object argument must not be null"); - if (StringUtils.hasText(namespace) && !properties.isAllNamespaces()) { + if (!StringUtils.hasText(namespace) && !properties.isAllNamespaces()) { log.warn("Namespace is null or empty, this may cause issues looking up services"); }