From 3455489f479c697d6153cfb413bddf4157ce013e Mon Sep 17 00:00:00 2001 From: Spencer Gibb Date: Fri, 17 Jan 2020 17:58:31 -0500 Subject: [PATCH] Migrates deprecations --- .../archaius/ArchaiusAutoConfiguration.java | 4 ++-- .../http/RestTemplateTransportClientFactory.java | 4 ++-- .../EurekaServiceRegistryTests.java | 4 ++-- .../server/RefreshablePeerEurekaNodesTests.java | 4 ++-- .../hystrix/stream/HystrixStreamTaskTests.java | 8 ++++---- .../hystrix/HystrixAutoConfiguration.java | 12 ++++++------ .../HttpClientStatusCodeExceptionTest.java | 2 +- .../okhttp/OkHttpStatusCodeExceptionTest.java | 2 +- .../netflix/ribbon/RibbonAutoConfiguration.java | 1 + .../netflix/ribbon/SpringClientFactory.java | 2 +- ...bonClientPreprocessorOverridesRetryTests.java | 16 +++++++++------- .../netflix/ribbon/RibbonInterceptorTests.java | 2 +- .../RibbonLoadBalancedRetryFactoryTests.java | 12 +++++------- .../ribbon/RibbonLoadBalancerClientTests.java | 11 +++++------ .../RibbonLoadBalancingHttpClientTests.java | 6 +++--- .../SpringRetryEnabledOkHttpClientTests.java | 4 ++-- .../stream/HystrixStreamAggregatorTests.java | 4 ++-- .../netflix/zuul/ZuulProxyAutoConfiguration.java | 6 +++--- .../ContextPathZuulProxyApplicationTests.java | 3 ++- .../cloud/netflix/zuul/FiltersEndpointTests.java | 3 ++- .../zuul/RetryableZuulProxyApplicationTests.java | 3 ++- .../zuul/SimpleZuulProxyApplicationTests.java | 3 ++- .../filters/CustomHostRoutingFilterTests.java | 3 ++- .../zuul/filters/SimpleRouteLocatorTests.java | 4 ++-- ...atternServiceRouteMapperIntegrationTests.java | 3 ++- .../HttpClientRibbonCommandFactoryTest.java | 4 ++-- .../HttpClientRibbonCommandIntegrationTests.java | 3 ++- .../okhttp/OkHttpRibbonCommandFactoryTest.java | 4 ++-- .../OkHttpRibbonCommandIntegrationTests.java | 3 ++- .../RestClientRibbonCommandIntegrationTests.java | 4 ++-- .../ZuulApacheHttpClientConfigurationTests.java | 2 +- 31 files changed, 77 insertions(+), 69 deletions(-) diff --git a/spring-cloud-netflix-archaius/src/main/java/org/springframework/cloud/netflix/archaius/ArchaiusAutoConfiguration.java b/spring-cloud-netflix-archaius/src/main/java/org/springframework/cloud/netflix/archaius/ArchaiusAutoConfiguration.java index 043057371..dbabdee59 100644 --- a/spring-cloud-netflix-archaius/src/main/java/org/springframework/cloud/netflix/archaius/ArchaiusAutoConfiguration.java +++ b/spring-cloud-netflix-archaius/src/main/java/org/springframework/cloud/netflix/archaius/ArchaiusAutoConfiguration.java @@ -41,7 +41,7 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.springframework.beans.factory.annotation.Autowired; -import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnEnabledEndpoint; +import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnAvailableEndpoint; import org.springframework.boot.actuate.health.Health; import org.springframework.boot.autoconfigure.AutoConfigureOrder; import org.springframework.boot.autoconfigure.condition.ConditionalOnClass; @@ -202,7 +202,7 @@ public class ArchaiusAutoConfiguration { protected static class ArchaiusEndpointConfiguration { @Bean - @ConditionalOnEnabledEndpoint + @ConditionalOnAvailableEndpoint protected ArchaiusEndpoint archaiusEndpoint() { return new ArchaiusEndpoint(); } diff --git a/spring-cloud-netflix-eureka-client/src/main/java/org/springframework/cloud/netflix/eureka/http/RestTemplateTransportClientFactory.java b/spring-cloud-netflix-eureka-client/src/main/java/org/springframework/cloud/netflix/eureka/http/RestTemplateTransportClientFactory.java index 5a02aa42a..af33bee0b 100644 --- a/spring-cloud-netflix-eureka-client/src/main/java/org/springframework/cloud/netflix/eureka/http/RestTemplateTransportClientFactory.java +++ b/spring-cloud-netflix-eureka-client/src/main/java/org/springframework/cloud/netflix/eureka/http/RestTemplateTransportClientFactory.java @@ -39,7 +39,7 @@ import com.netflix.discovery.shared.transport.EurekaHttpClient; import com.netflix.discovery.shared.transport.TransportClientFactory; import org.springframework.http.HttpStatus; -import org.springframework.http.client.support.BasicAuthorizationInterceptor; +import org.springframework.http.client.support.BasicAuthenticationInterceptor; import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter; import org.springframework.web.client.DefaultResponseErrorHandler; import org.springframework.web.client.RestTemplate; @@ -66,7 +66,7 @@ public class RestTemplateTransportClientFactory implements TransportClientFactor if (serviceURI.getUserInfo() != null) { String[] credentials = serviceURI.getUserInfo().split(":"); if (credentials.length == 2) { - restTemplate.getInterceptors().add(new BasicAuthorizationInterceptor( + restTemplate.getInterceptors().add(new BasicAuthenticationInterceptor( credentials[0], credentials[1])); } } diff --git a/spring-cloud-netflix-eureka-client/src/test/java/org/springframework/cloud/netflix/eureka/serviceregistry/EurekaServiceRegistryTests.java b/spring-cloud-netflix-eureka-client/src/test/java/org/springframework/cloud/netflix/eureka/serviceregistry/EurekaServiceRegistryTests.java index 87c0b20b9..8aff6c64e 100644 --- a/spring-cloud-netflix-eureka-client/src/test/java/org/springframework/cloud/netflix/eureka/serviceregistry/EurekaServiceRegistryTests.java +++ b/spring-cloud-netflix-eureka-client/src/test/java/org/springframework/cloud/netflix/eureka/serviceregistry/EurekaServiceRegistryTests.java @@ -34,7 +34,7 @@ import static com.netflix.appinfo.InstanceInfo.InstanceStatus.OUT_OF_SERVICE; import static com.netflix.appinfo.InstanceInfo.InstanceStatus.UNKNOWN; import static org.assertj.core.api.Assertions.assertThat; import static org.mockito.Mockito.mock; -import static org.mockito.Mockito.verifyZeroInteractions; +import static org.mockito.Mockito.verifyNoInteractions; import static org.mockito.Mockito.when; /** @@ -62,7 +62,7 @@ public class EurekaServiceRegistryTests { registry.deregister(registration); - verifyZeroInteractions(eurekaClient); + verifyNoInteractions(eurekaClient); } @Test diff --git a/spring-cloud-netflix-eureka-server/src/test/java/org/springframework/cloud/netflix/eureka/server/RefreshablePeerEurekaNodesTests.java b/spring-cloud-netflix-eureka-server/src/test/java/org/springframework/cloud/netflix/eureka/server/RefreshablePeerEurekaNodesTests.java index 0fa5ba8c3..b7f0d1c0d 100644 --- a/spring-cloud-netflix-eureka-server/src/test/java/org/springframework/cloud/netflix/eureka/server/RefreshablePeerEurekaNodesTests.java +++ b/spring-cloud-netflix-eureka-server/src/test/java/org/springframework/cloud/netflix/eureka/server/RefreshablePeerEurekaNodesTests.java @@ -47,7 +47,7 @@ import org.springframework.http.ResponseEntity; import org.springframework.test.context.junit4.SpringRunner; import static org.assertj.core.api.Assertions.assertThat; -import static org.mockito.Matchers.anyListOf; +import static org.mockito.ArgumentMatchers.anyList; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.never; import static org.mockito.Mockito.spy; @@ -179,7 +179,7 @@ public class RefreshablePeerEurekaNodesTests { mock.onApplicationEvent(new EnvironmentChangeEvent( Collections.singleton("some.irrelevant.property"))); - verify(mock, never()).updatePeerEurekaNodes(anyListOf(String.class)); + verify(mock, never()).updatePeerEurekaNodes(anyList()); } @Test diff --git a/spring-cloud-netflix-hystrix-stream/src/test/java/org/springframework/cloud/netflix/hystrix/stream/HystrixStreamTaskTests.java b/spring-cloud-netflix-hystrix-stream/src/test/java/org/springframework/cloud/netflix/hystrix/stream/HystrixStreamTaskTests.java index 17c2bb7c8..42f968451 100644 --- a/spring-cloud-netflix-hystrix-stream/src/test/java/org/springframework/cloud/netflix/hystrix/stream/HystrixStreamTaskTests.java +++ b/spring-cloud-netflix-hystrix-stream/src/test/java/org/springframework/cloud/netflix/hystrix/stream/HystrixStreamTaskTests.java @@ -26,7 +26,7 @@ import org.junit.runner.RunWith; import org.mockito.InjectMocks; import org.mockito.Mock; import org.mockito.Spy; -import org.mockito.runners.MockitoJUnitRunner; +import org.mockito.junit.MockitoJUnitRunner; import org.springframework.cloud.client.discovery.DiscoveryClient; import org.springframework.cloud.client.serviceregistry.Registration; @@ -35,9 +35,9 @@ import org.springframework.messaging.Message; import org.springframework.messaging.MessageChannel; import static org.assertj.core.api.Assertions.assertThat; +import static org.mockito.ArgumentMatchers.any; import static org.mockito.BDDMockito.then; -import static org.mockito.Matchers.any; -import static org.mockito.Mockito.verifyZeroInteractions; +import static org.mockito.Mockito.verifyNoInteractions; /** * @author Marcin Grzejszczak @@ -67,7 +67,7 @@ public class HystrixStreamTaskTests { public void should_not_send_metrics_when_they_are_empty() throws Exception { this.hystrixStreamTask.sendMetrics(); - verifyZeroInteractions(this.outboundChannel); + verifyNoInteractions(this.outboundChannel); } @Test diff --git a/spring-cloud-netflix-hystrix/src/main/java/org/springframework/cloud/netflix/hystrix/HystrixAutoConfiguration.java b/spring-cloud-netflix-hystrix/src/main/java/org/springframework/cloud/netflix/hystrix/HystrixAutoConfiguration.java index 49c9379c4..311bd4ae0 100644 --- a/spring-cloud-netflix-hystrix/src/main/java/org/springframework/cloud/netflix/hystrix/HystrixAutoConfiguration.java +++ b/spring-cloud-netflix-hystrix/src/main/java/org/springframework/cloud/netflix/hystrix/HystrixAutoConfiguration.java @@ -26,9 +26,9 @@ import org.reactivestreams.Publisher; import rx.Observable; import rx.RxReactiveStreams; -import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnEnabledEndpoint; +import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnAvailableEndpoint; import org.springframework.boot.actuate.autoconfigure.health.ConditionalOnEnabledHealthIndicator; -import org.springframework.boot.actuate.autoconfigure.health.HealthIndicatorAutoConfiguration; +import org.springframework.boot.actuate.autoconfigure.health.HealthContributorAutoConfiguration; import org.springframework.boot.actuate.health.HealthIndicator; import org.springframework.boot.autoconfigure.AutoConfigureAfter; import org.springframework.boot.autoconfigure.condition.ConditionalOnBean; @@ -52,8 +52,8 @@ import static org.springframework.boot.autoconfigure.condition.ConditionalOnWebA */ @Configuration(proxyBeanMethods = false) @ConditionalOnClass({ Hystrix.class, HealthIndicator.class, - HealthIndicatorAutoConfiguration.class }) -@AutoConfigureAfter({ HealthIndicatorAutoConfiguration.class }) + HealthContributorAutoConfiguration.class }) +@AutoConfigureAfter({ HealthContributorAutoConfiguration.class }) public class HystrixAutoConfiguration { @Bean @@ -87,7 +87,7 @@ public class HystrixAutoConfiguration { protected static class HystrixServletAutoConfiguration { @Bean - @ConditionalOnEnabledEndpoint + @ConditionalOnAvailableEndpoint public HystrixStreamEndpoint hystrixStreamEndpoint(HystrixProperties properties) { return new HystrixStreamEndpoint(properties.getConfig()); } @@ -108,7 +108,7 @@ public class HystrixAutoConfiguration { protected static class HystrixWebfluxManagementContextConfiguration { @Bean - @ConditionalOnEnabledEndpoint + @ConditionalOnAvailableEndpoint public HystrixWebfluxEndpoint hystrixWebfluxController() { Observable serializedDashboardData = HystrixDashboardStream .getInstance().observe() diff --git a/spring-cloud-netflix-hystrix/src/test/java/org/springframework/cloud/netflix/ribbon/apache/HttpClientStatusCodeExceptionTest.java b/spring-cloud-netflix-hystrix/src/test/java/org/springframework/cloud/netflix/ribbon/apache/HttpClientStatusCodeExceptionTest.java index 40d98bfa4..8a5778754 100644 --- a/spring-cloud-netflix-hystrix/src/test/java/org/springframework/cloud/netflix/ribbon/apache/HttpClientStatusCodeExceptionTest.java +++ b/spring-cloud-netflix-hystrix/src/test/java/org/springframework/cloud/netflix/ribbon/apache/HttpClientStatusCodeExceptionTest.java @@ -31,7 +31,7 @@ import org.apache.http.message.BasicStatusLine; import org.apache.http.util.EntityUtils; import org.junit.Test; import org.junit.runner.RunWith; -import org.mockito.runners.MockitoJUnitRunner; +import org.mockito.junit.MockitoJUnitRunner; import static org.assertj.core.api.Assertions.assertThat; import static org.mockito.Mockito.doReturn; diff --git a/spring-cloud-netflix-hystrix/src/test/java/org/springframework/cloud/netflix/ribbon/okhttp/OkHttpStatusCodeExceptionTest.java b/spring-cloud-netflix-hystrix/src/test/java/org/springframework/cloud/netflix/ribbon/okhttp/OkHttpStatusCodeExceptionTest.java index d24ac6029..31a231462 100644 --- a/spring-cloud-netflix-hystrix/src/test/java/org/springframework/cloud/netflix/ribbon/okhttp/OkHttpStatusCodeExceptionTest.java +++ b/spring-cloud-netflix-hystrix/src/test/java/org/springframework/cloud/netflix/ribbon/okhttp/OkHttpStatusCodeExceptionTest.java @@ -26,7 +26,7 @@ import okhttp3.Response; import okhttp3.ResponseBody; import org.junit.Test; import org.junit.runner.RunWith; -import org.mockito.runners.MockitoJUnitRunner; +import org.mockito.junit.MockitoJUnitRunner; import static org.assertj.core.api.Assertions.assertThat; diff --git a/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/RibbonAutoConfiguration.java b/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/RibbonAutoConfiguration.java index 5082b4680..3755b8750 100644 --- a/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/RibbonAutoConfiguration.java +++ b/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/RibbonAutoConfiguration.java @@ -182,6 +182,7 @@ public class RibbonAutoConfiguration { } + @SuppressWarnings("deprecation") @ConditionalOnClass(AsyncRestTemplate.class) static class AsyncRestTemplatePresent { diff --git a/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/SpringClientFactory.java b/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/SpringClientFactory.java index 257b3ae3a..f0b6b7c0e 100644 --- a/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/SpringClientFactory.java +++ b/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/SpringClientFactory.java @@ -102,7 +102,7 @@ public class SpringClientFactory extends NamedContextFactory