diff --git a/spring-cloud-netflix-eureka-client/src/main/java/org/springframework/cloud/netflix/eureka/EurekaClientAutoConfiguration.java b/spring-cloud-netflix-eureka-client/src/main/java/org/springframework/cloud/netflix/eureka/EurekaClientAutoConfiguration.java index 3557179f7..8378efc81 100644 --- a/spring-cloud-netflix-eureka-client/src/main/java/org/springframework/cloud/netflix/eureka/EurekaClientAutoConfiguration.java +++ b/spring-cloud-netflix-eureka-client/src/main/java/org/springframework/cloud/netflix/eureka/EurekaClientAutoConfiguration.java @@ -26,7 +26,6 @@ import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Value; import org.springframework.boot.autoconfigure.AutoConfigureAfter; import org.springframework.boot.autoconfigure.AutoConfigureBefore; -import org.springframework.boot.autoconfigure.condition.AllNestedConditions; import org.springframework.boot.autoconfigure.condition.AnyNestedCondition; import org.springframework.boot.autoconfigure.condition.ConditionalOnBean; import org.springframework.boot.autoconfigure.condition.ConditionalOnClass; @@ -204,7 +203,8 @@ public class EurekaClientAutoConfiguration { @Target({ ElementType.TYPE, ElementType.METHOD }) @Retention(RetentionPolicy.RUNTIME) @Documented - @Conditional(OnRefreshScopeCondition.class) + @ConditionalOnClass(RefreshScope.class) + @ConditionalOnBean(RefreshAutoConfiguration.class) @interface ConditionalOnRefreshScope { } @@ -219,24 +219,10 @@ public class EurekaClientAutoConfiguration { static class MissingClass { } - @ConditionalOnClass(RefreshScope.class) @ConditionalOnMissingBean(RefreshAutoConfiguration.class) static class MissingScope { } } - private static class OnRefreshScopeCondition extends AllNestedConditions { - - public OnRefreshScopeCondition() { - super(ConfigurationPhase.REGISTER_BEAN); - } - - @ConditionalOnClass(RefreshScope.class) - @ConditionalOnBean(RefreshAutoConfiguration.class) - static class FoundScope { - } - - } - } diff --git a/spring-cloud-netflix-eureka-client/src/test/java/org/springframework/cloud/netflix/eureka/EurekaClientAutoConfigurationTests.java b/spring-cloud-netflix-eureka-client/src/test/java/org/springframework/cloud/netflix/eureka/EurekaClientAutoConfigurationTests.java index 6c21cb62d..465d393f8 100644 --- a/spring-cloud-netflix-eureka-client/src/test/java/org/springframework/cloud/netflix/eureka/EurekaClientAutoConfigurationTests.java +++ b/spring-cloud-netflix-eureka-client/src/test/java/org/springframework/cloud/netflix/eureka/EurekaClientAutoConfigurationTests.java @@ -18,7 +18,6 @@ package org.springframework.cloud.netflix.eureka; import org.junit.After; import org.junit.Test; -import org.mockito.Matchers; import org.mockito.Mockito; import org.springframework.aop.scope.ScopedProxyFactoryBean; import org.springframework.boot.autoconfigure.PropertyPlaceholderAutoConfiguration; @@ -32,7 +31,6 @@ import org.springframework.context.annotation.Configuration; import org.springframework.context.annotation.Import; import com.netflix.discovery.shared.transport.jersey.EurekaJerseyClient; -import com.sun.jersey.api.client.filter.HTTPBasicAuthFilter; import com.sun.jersey.client.apache4.ApacheHttpClient4; import static org.junit.Assert.assertEquals; @@ -114,8 +112,8 @@ public class EurekaClientAutoConfigurationTests { EnvironmentTestUtils.addEnvironment(this.context, "server.port=8989", "eureka.client.serviceUrl.defaultZone=http://user:foo@example.com:80/eureka"); setupContext(MockClientConfiguration.class); - //ApacheHttpClient4 http = this.context.getBean(ApacheHttpClient4.class); - //Mockito.verify(http).addFilter(Matchers.any(HTTPBasicAuthFilter.class)); + // ApacheHttpClient4 http = this.context.getBean(ApacheHttpClient4.class); + // Mockito.verify(http).addFilter(Matchers.any(HTTPBasicAuthFilter.class)); } private void testNonSecurePort(String propName) {