From 9c24024bc9c1e9e740360dc0bcdc4097b23be090 Mon Sep 17 00:00:00 2001 From: Ryan Baxter Date: Tue, 3 Sep 2019 16:17:32 -0400 Subject: [PATCH] Updating readme with note about building spring-cloud-netflix-hystrix-contract. Fixes #3497 --- docs/README.adoc | 4 ++++ docs/src/main/asciidoc/README.adoc | 3 +++ .../RefreshablePeerEurekaNodesWithCustomFiltersTests.java | 8 +++----- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/docs/README.adoc b/docs/README.adoc index cdeb4d8f5..9bbecde45 100644 --- a/docs/README.adoc +++ b/docs/README.adoc @@ -143,6 +143,9 @@ from the `file` menu. +NOTE: To build the module `spring-cloud-netflix-hystrix-contract` along with the entire Netflix project run the +`build.sh` script in the `scripts` directory. + == Contributing :spring-cloud-build-branch: master @@ -278,6 +281,7 @@ $ touch .springformat ==== Intellij IDEA In order to setup Intellij you should import our coding conventions, inspection profiles and set up the checkstyle plugin. +The following files can be found in the https://github.com/spring-cloud/spring-cloud-build/tree/master/spring-cloud-build-tools[Spring Cloud Build] project. .spring-cloud-build-tools/ ---- diff --git a/docs/src/main/asciidoc/README.adoc b/docs/src/main/asciidoc/README.adoc index 92e6fd166..e538d455b 100644 --- a/docs/src/main/asciidoc/README.adoc +++ b/docs/src/main/asciidoc/README.adoc @@ -21,6 +21,9 @@ include::maintenance-mode.adoc[] include::https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/master/docs/src/main/asciidoc/building-jdk8.adoc[] +NOTE: To build the module `spring-cloud-netflix-hystrix-contract` along with the entire Netflix project run the +`build.sh` script in the `scripts` directory. + == Contributing include::https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/master/docs/src/main/asciidoc/contributing.adoc[] diff --git a/spring-cloud-netflix-eureka-server/src/test/java/org/springframework/cloud/netflix/eureka/server/RefreshablePeerEurekaNodesWithCustomFiltersTests.java b/spring-cloud-netflix-eureka-server/src/test/java/org/springframework/cloud/netflix/eureka/server/RefreshablePeerEurekaNodesWithCustomFiltersTests.java index 5ffaea112..8f624fc19 100644 --- a/spring-cloud-netflix-eureka-server/src/test/java/org/springframework/cloud/netflix/eureka/server/RefreshablePeerEurekaNodesWithCustomFiltersTests.java +++ b/spring-cloud-netflix-eureka-server/src/test/java/org/springframework/cloud/netflix/eureka/server/RefreshablePeerEurekaNodesWithCustomFiltersTests.java @@ -42,11 +42,9 @@ import static org.assertj.core.api.Assertions.assertThat; * @author Yuxin Bai */ @RunWith(SpringRunner.class) -@SpringBootTest( - classes = RefreshablePeerEurekaNodesWithCustomFiltersTests.Application.class, - webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT, - value = { "spring.application.name=eureka", "server.contextPath=/context", - "management.security.enabled=false" }) +@SpringBootTest(classes = RefreshablePeerEurekaNodesWithCustomFiltersTests.Application.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT, value = { + "spring.application.name=eureka", "server.contextPath=/context", + "management.security.enabled=false" }) public class RefreshablePeerEurekaNodesWithCustomFiltersTests { @Autowired