From 076df775638067e0c69993cdd2c631511f07d935 Mon Sep 17 00:00:00 2001 From: Igor Suhorukov Date: Mon, 5 Feb 2018 04:09:09 +0300 Subject: [PATCH] Optimize thread safe code and replace the synchronized class "StringBuffer" by an unsynchronized one "StringBuilder". (#2704) --- .../netflix/eureka/server/EurekaDashboardProperties.java | 2 +- .../cloud/netflix/ribbon/RibbonLoadBalancerClient.java | 2 +- .../cloud/netflix/ribbon/support/RibbonCommandContext.java | 2 +- .../cloud/netflix/zuul/filters/ZuulProperties.java | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/spring-cloud-netflix-eureka-server/src/main/java/org/springframework/cloud/netflix/eureka/server/EurekaDashboardProperties.java b/spring-cloud-netflix-eureka-server/src/main/java/org/springframework/cloud/netflix/eureka/server/EurekaDashboardProperties.java index bf96d493..a6f0b8d6 100644 --- a/spring-cloud-netflix-eureka-server/src/main/java/org/springframework/cloud/netflix/eureka/server/EurekaDashboardProperties.java +++ b/spring-cloud-netflix-eureka-server/src/main/java/org/springframework/cloud/netflix/eureka/server/EurekaDashboardProperties.java @@ -70,7 +70,7 @@ public class EurekaDashboardProperties { @Override public String toString() { - final StringBuffer sb = new StringBuffer("EurekaDashboardProperties{"); + final StringBuilder sb = new StringBuilder("EurekaDashboardProperties{"); sb.append("path='").append(path).append('\''); sb.append(", enabled=").append(enabled); sb.append('}'); diff --git a/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/RibbonLoadBalancerClient.java b/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/RibbonLoadBalancerClient.java index d2d2e2d5..45bffa5e 100644 --- a/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/RibbonLoadBalancerClient.java +++ b/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/RibbonLoadBalancerClient.java @@ -201,7 +201,7 @@ public class RibbonLoadBalancerClient implements LoadBalancerClient { @Override public String toString() { - final StringBuffer sb = new StringBuffer("RibbonServer{"); + final StringBuilder sb = new StringBuilder("RibbonServer{"); sb.append("serviceId='").append(serviceId).append('\''); sb.append(", server=").append(server); sb.append(", secure=").append(secure); diff --git a/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/support/RibbonCommandContext.java b/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/support/RibbonCommandContext.java index acc99900..05796e60 100644 --- a/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/support/RibbonCommandContext.java +++ b/spring-cloud-netflix-ribbon/src/main/java/org/springframework/cloud/netflix/ribbon/support/RibbonCommandContext.java @@ -198,7 +198,7 @@ public class RibbonCommandContext { @Override public String toString() { - final StringBuffer sb = new StringBuffer("RibbonCommandContext{"); + final StringBuilder sb = new StringBuilder("RibbonCommandContext{"); sb.append("serviceId='").append(serviceId).append('\''); sb.append(", method='").append(method).append('\''); sb.append(", uri='").append(uri).append('\''); diff --git a/spring-cloud-netflix-zuul/src/main/java/org/springframework/cloud/netflix/zuul/filters/ZuulProperties.java b/spring-cloud-netflix-zuul/src/main/java/org/springframework/cloud/netflix/zuul/filters/ZuulProperties.java index 604e7d36..46b6c9ab 100644 --- a/spring-cloud-netflix-zuul/src/main/java/org/springframework/cloud/netflix/zuul/filters/ZuulProperties.java +++ b/spring-cloud-netflix-zuul/src/main/java/org/springframework/cloud/netflix/zuul/filters/ZuulProperties.java @@ -529,7 +529,7 @@ public class ZuulProperties { @Override public String toString() { - final StringBuffer sb = new StringBuffer("Host{"); + final StringBuilder sb = new StringBuilder("Host{"); sb.append("maxTotalConnections=").append(maxTotalConnections); sb.append(", maxPerRouteConnections=").append(maxPerRouteConnections); sb.append(", socketTimeoutMillis=").append(socketTimeoutMillis); @@ -576,7 +576,7 @@ public class ZuulProperties { @Override public String toString() { - final StringBuffer sb = new StringBuffer("HystrixSemaphore{"); + final StringBuilder sb = new StringBuilder("HystrixSemaphore{"); sb.append("maxSemaphores=").append(maxSemaphores); sb.append('}'); return sb.toString();