From c03f78af46a426509f3fa5a46847b8efe642dd04 Mon Sep 17 00:00:00 2001 From: Olga MaciaszekSharma Date: Mon, 4 Dec 2023 18:23:04 +0100 Subject: [PATCH] Improve url validation. Fixes gh-873. --- .../cloud/openfeign/FeignClientFactoryBean.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java index b27d450b..f84f8840 100644 --- a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java +++ b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java @@ -417,7 +417,7 @@ public class FeignClientFactoryBean if (LOG.isInfoEnabled()) { LOG.info("For '" + name + "' URL not provided. Will try picking an instance via load-balancing."); } - if (!name.startsWith("http")) { + if (!name.startsWith("http://") && !name.startsWith("https://")) { url = "http://" + name; } else { @@ -426,7 +426,7 @@ public class FeignClientFactoryBean url += cleanPath(); return (T) loadBalance(builder, context, new HardCodedTarget<>(type, name, url)); } - if (StringUtils.hasText(url) && !url.startsWith("http")) { + if (StringUtils.hasText(url) && !url.startsWith("http://") && !url.startsWith("https://")) { url = "http://" + url; } String url = this.url + cleanPath();