diff --git a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/encoding/FeignAcceptGzipEncodingAutoConfiguration.java b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/encoding/FeignAcceptGzipEncodingAutoConfiguration.java index 5b8860af..845f69a2 100644 --- a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/encoding/FeignAcceptGzipEncodingAutoConfiguration.java +++ b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/encoding/FeignAcceptGzipEncodingAutoConfiguration.java @@ -39,7 +39,8 @@ import org.springframework.context.annotation.Configuration; @EnableConfigurationProperties(FeignClientEncodingProperties.class) @ConditionalOnClass(Feign.class) @ConditionalOnBean(Client.class) -@ConditionalOnProperty(value = "feign.compression.response.enabled", matchIfMissing = false) +@ConditionalOnProperty(value = "feign.compression.response.enabled", + matchIfMissing = false) // The OK HTTP client uses "transparent" compression. // If the accept-encoding header is present it disable transparent compression @ConditionalOnMissingBean(type = "okhttp3.OkHttpClient") diff --git a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/encoding/FeignContentGzipEncodingAutoConfiguration.java b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/encoding/FeignContentGzipEncodingAutoConfiguration.java index 712d0f1c..efe68b27 100644 --- a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/encoding/FeignContentGzipEncodingAutoConfiguration.java +++ b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/encoding/FeignContentGzipEncodingAutoConfiguration.java @@ -42,7 +42,8 @@ import org.springframework.context.annotation.Configuration; // The OK HTTP client uses "transparent" compression. // If the content-encoding header is present it disable transparent compression @ConditionalOnMissingBean(type = "okhttp3.OkHttpClient") -@ConditionalOnProperty(value = "feign.compression.request.enabled", matchIfMissing = false) +@ConditionalOnProperty(value = "feign.compression.request.enabled", + matchIfMissing = false) @AutoConfigureAfter(FeignAutoConfiguration.class) public class FeignContentGzipEncodingAutoConfiguration { diff --git a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/ribbon/HttpClientFeignLoadBalancedConfiguration.java b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/ribbon/HttpClientFeignLoadBalancedConfiguration.java index be11b627..6ca9b237 100644 --- a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/ribbon/HttpClientFeignLoadBalancedConfiguration.java +++ b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/ribbon/HttpClientFeignLoadBalancedConfiguration.java @@ -91,7 +91,8 @@ class HttpClientFeignLoadBalancedConfiguration { } @Bean - @ConditionalOnProperty(value = "feign.compression.response.enabled", havingValue = "true") + @ConditionalOnProperty(value = "feign.compression.response.enabled", + havingValue = "true") public CloseableHttpClient customHttpClient( HttpClientConnectionManager httpClientConnectionManager, FeignHttpClientProperties httpClientProperties) { @@ -103,7 +104,8 @@ class HttpClientFeignLoadBalancedConfiguration { } @Bean - @ConditionalOnProperty(value = "feign.compression.response.enabled", havingValue = "false", matchIfMissing = true) + @ConditionalOnProperty(value = "feign.compression.response.enabled", + havingValue = "false", matchIfMissing = true) public CloseableHttpClient httpClient(ApacheHttpClientFactory httpClientFactory, HttpClientConnectionManager httpClientConnectionManager, FeignHttpClientProperties httpClientProperties) { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientOverrideDefaultsTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientOverrideDefaultsTests.java index a52c89ed..7709bdaf 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientOverrideDefaultsTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientOverrideDefaultsTests.java @@ -141,7 +141,8 @@ public class FeignClientOverrideDefaultsTests { .isEqualTo(2); } - @FeignClient(name = "foo", url = "https://foo", configuration = FooConfiguration.class) + @FeignClient(name = "foo", url = "https://foo", + configuration = FooConfiguration.class) interface FooClient { @RequestLine("GET /") @@ -149,7 +150,8 @@ public class FeignClientOverrideDefaultsTests { } - @FeignClient(name = "bar", url = "https://bar", configuration = BarConfiguration.class) + @FeignClient(name = "bar", url = "https://bar", + configuration = BarConfiguration.class) interface BarClient { @RequestMapping(value = "/", method = RequestMethod.GET) diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientUsingPropertiesTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientUsingPropertiesTests.java index b44396f5..adb3dd83 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientUsingPropertiesTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientUsingPropertiesTests.java @@ -59,7 +59,8 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen * @author Eko Kurniawan Khannedy */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = FeignClientUsingPropertiesTests.Application.class, webEnvironment = RANDOM_PORT) +@SpringBootTest(classes = FeignClientUsingPropertiesTests.Application.class, + webEnvironment = RANDOM_PORT) @TestPropertySource("classpath:feign-properties.properties") @DirtiesContext public class FeignClientUsingPropertiesTests { @@ -146,7 +147,8 @@ public class FeignClientUsingPropertiesTests { protected interface FormClient { - @RequestMapping(value = "/form", method = RequestMethod.POST, consumes = MediaType.APPLICATION_FORM_URLENCODED_VALUE) + @RequestMapping(value = "/form", method = RequestMethod.POST, + consumes = MediaType.APPLICATION_FORM_URLENCODED_VALUE) String form(Map form); } @@ -174,7 +176,8 @@ public class FeignClientUsingPropertiesTests { return "OK"; } - @RequestMapping(value = "/form", method = RequestMethod.POST, consumes = MediaType.APPLICATION_FORM_URLENCODED_VALUE) + @RequestMapping(value = "/form", method = RequestMethod.POST, + consumes = MediaType.APPLICATION_FORM_URLENCODED_VALUE) public String form(HttpServletRequest request) { return request.getParameter("form"); } diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientsRegistrarTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientsRegistrarTests.java index 446f7e8a..62ee09fa 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientsRegistrarTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientsRegistrarTests.java @@ -89,7 +89,8 @@ public class FeignClientsRegistrarTests { new AnnotationConfigApplicationContext(FallbackFactoryTestConfig.class); } - @FeignClient(name = "fallbackTestClient", url = "http://localhost:8080/", fallback = FallbackClient.class) + @FeignClient(name = "fallbackTestClient", url = "http://localhost:8080/", + fallback = FallbackClient.class) protected interface FallbackClient { @RequestMapping(method = RequestMethod.GET, value = "/hello") @@ -97,7 +98,8 @@ public class FeignClientsRegistrarTests { } - @FeignClient(name = "fallbackFactoryTestClient", url = "http://localhost:8081/", fallbackFactory = FallbackFactoryClient.class) + @FeignClient(name = "fallbackFactoryTestClient", url = "http://localhost:8081/", + fallbackFactory = FallbackFactoryClient.class) protected interface FallbackFactoryClient { @RequestMapping(method = RequestMethod.GET, value = "/hello") @@ -114,8 +116,8 @@ public class FeignClientsRegistrarTests { @Configuration @EnableAutoConfiguration - @EnableFeignClients(clients = { - FeignClientsRegistrarTests.FallbackFactoryClient.class }) + @EnableFeignClients( + clients = { FeignClientsRegistrarTests.FallbackFactoryClient.class }) protected static class FallbackFactoryTestConfig { } diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignHttpClientUrlTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignHttpClientUrlTests.java index bb4a3d92..23b553d2 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignHttpClientUrlTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignHttpClientUrlTests.java @@ -50,9 +50,10 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen * @author Spencer Gibb */ @RunWith(SpringRunner.class) -@SpringBootTest(classes = FeignHttpClientUrlTests.TestConfig.class, webEnvironment = DEFINED_PORT, value = { - "spring.application.name=feignclienturltest", "feign.hystrix.enabled=false", - "feign.okhttp.enabled=false" }) +@SpringBootTest(classes = FeignHttpClientUrlTests.TestConfig.class, + webEnvironment = DEFINED_PORT, + value = { "spring.application.name=feignclienturltest", + "feign.hystrix.enabled=false", "feign.okhttp.enabled=false" }) @DirtiesContext public class FeignHttpClientUrlTests { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/SpringDecoderTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/SpringDecoderTests.java index 4068d956..54863b41 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/SpringDecoderTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/SpringDecoderTests.java @@ -47,8 +47,9 @@ import static org.assertj.core.api.Assertions.assertThat; * @author Spencer Gibb */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = SpringDecoderTests.Application.class, webEnvironment = WebEnvironment.RANDOM_PORT, value = { - "spring.application.name=springdecodertest", "spring.jmx.enabled=false" }) +@SpringBootTest(classes = SpringDecoderTests.Application.class, + webEnvironment = WebEnvironment.RANDOM_PORT, value = { + "spring.application.name=springdecodertest", "spring.jmx.enabled=false" }) @DirtiesContext public class SpringDecoderTests extends FeignClientFactoryBean { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/beans/FeignClientTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/beans/FeignClientTests.java index d9dbb87d..ff5d9ca1 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/beans/FeignClientTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/beans/FeignClientTests.java @@ -49,10 +49,11 @@ import static org.assertj.core.api.Assertions.assertThat; * @author Dave Syer */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = FeignClientTests.Application.class, webEnvironment = WebEnvironment.RANDOM_PORT, value = { - "spring.application.name=feignclienttest", - "logging.level.org.springframework.cloud.openfeign.valid=DEBUG", - "feign.httpclient.enabled=false", "feign.okhttp.enabled=false" }) +@SpringBootTest(classes = FeignClientTests.Application.class, + webEnvironment = WebEnvironment.RANDOM_PORT, + value = { "spring.application.name=feignclienttest", + "logging.level.org.springframework.cloud.openfeign.valid=DEBUG", + "feign.httpclient.enabled=false", "feign.okhttp.enabled=false" }) @DirtiesContext public class FeignClientTests { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/FeignAcceptEncodingTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/FeignAcceptEncodingTests.java index 1c1ba7c1..2f971ab1 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/FeignAcceptEncodingTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/FeignAcceptEncodingTests.java @@ -50,8 +50,9 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen * * @author Jakub Narloch */ -@SpringBootTest(classes = FeignAcceptEncodingTests.Application.class, webEnvironment = RANDOM_PORT, value = { - "feign.compression.response.enabled=true" }) +@SpringBootTest(classes = FeignAcceptEncodingTests.Application.class, + webEnvironment = RANDOM_PORT, + value = { "feign.compression.response.enabled=true" }) @RunWith(SpringRunner.class) @DirtiesContext public class FeignAcceptEncodingTests { @@ -75,7 +76,8 @@ public class FeignAcceptEncodingTests { @EnableFeignClients(clients = InvoiceClient.class) @RibbonClient(name = "local", configuration = LocalRibbonClientConfiguration.class) - @SpringBootApplication(scanBasePackages = "org.springframework.cloud.openfeign.encoding.app") + @SpringBootApplication( + scanBasePackages = "org.springframework.cloud.openfeign.encoding.app") @Import(NoSecurityConfiguration.class) public static class Application { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/FeignContentEncodingTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/FeignContentEncodingTests.java index c3fa40cd..a276d188 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/FeignContentEncodingTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/FeignContentEncodingTests.java @@ -49,10 +49,11 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen * * @author Jakub Narloch */ -@SpringBootTest(classes = FeignContentEncodingTests.Application.class, webEnvironment = RANDOM_PORT, value = { - "feign.compression.request.enabled=true", - "hystrix.command.default.execution.isolation.strategy=SEMAPHORE", - "ribbon.OkToRetryOnAllOperations=false" }) +@SpringBootTest(classes = FeignContentEncodingTests.Application.class, + webEnvironment = RANDOM_PORT, + value = { "feign.compression.request.enabled=true", + "hystrix.command.default.execution.isolation.strategy=SEMAPHORE", + "ribbon.OkToRetryOnAllOperations=false" }) @RunWith(SpringJUnit4ClassRunner.class) public class FeignContentEncodingTests { @@ -79,7 +80,8 @@ public class FeignContentEncodingTests { @EnableFeignClients(clients = InvoiceClient.class) @RibbonClient(name = "local", configuration = LocalRibbonClientConfiguration.class) - @SpringBootApplication(scanBasePackages = "org.springframework.cloud.openfeign.encoding.app") + @SpringBootApplication( + scanBasePackages = "org.springframework.cloud.openfeign.encoding.app") @Import(NoSecurityConfiguration.class) public static class Application { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/FeignPageableEncodingTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/FeignPageableEncodingTests.java index d19f35d3..d19255c0 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/FeignPageableEncodingTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/FeignPageableEncodingTests.java @@ -54,10 +54,11 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen * * @author Charlie Mordant. */ -@SpringBootTest(classes = FeignPageableEncodingTests.Application.class, webEnvironment = RANDOM_PORT, value = { - "feign.compression.request.enabled=true", - "hystrix.command.default.execution.isolation.strategy=SEMAPHORE", - "ribbon.OkToRetryOnAllOperations=false" }) +@SpringBootTest(classes = FeignPageableEncodingTests.Application.class, + webEnvironment = RANDOM_PORT, + value = { "feign.compression.request.enabled=true", + "hystrix.command.default.execution.isolation.strategy=SEMAPHORE", + "ribbon.OkToRetryOnAllOperations=false" }) @RunWith(SpringJUnit4ClassRunner.class) public class FeignPageableEncodingTests { @@ -84,7 +85,8 @@ public class FeignPageableEncodingTests { @EnableFeignClients(clients = InvoiceClient.class) @RibbonClient(name = "local", configuration = LocalRibbonClientConfiguration.class) - @SpringBootApplication(scanBasePackages = "org.springframework.cloud.openfeign.encoding.app") + @SpringBootApplication( + scanBasePackages = "org.springframework.cloud.openfeign.encoding.app") @EnableSpringDataWebSupport @Import({ NoSecurityConfiguration.class, FeignClientsConfiguration.class }) public static class Application { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/app/client/InvoiceClient.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/app/client/InvoiceClient.java index 47f0ed8d..86901942 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/app/client/InvoiceClient.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/app/client/InvoiceClient.java @@ -34,14 +34,18 @@ import org.springframework.web.bind.annotation.RequestMethod; @FeignClient("local") public interface InvoiceClient { - @RequestMapping(value = "invoicesPaged", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(value = "invoicesPaged", method = RequestMethod.GET, + produces = MediaType.APPLICATION_JSON_VALUE) ResponseEntity> getInvoicesPaged( org.springframework.data.domain.Pageable pageable); - @RequestMapping(value = "invoices", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(value = "invoices", method = RequestMethod.GET, + produces = MediaType.APPLICATION_JSON_VALUE) ResponseEntity> getInvoices(); - @RequestMapping(value = "invoices", method = RequestMethod.POST, consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(value = "invoices", method = RequestMethod.POST, + consumes = MediaType.APPLICATION_JSON_VALUE, + produces = MediaType.APPLICATION_JSON_VALUE) ResponseEntity> saveInvoices(List invoices); } diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/app/resource/InvoiceResource.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/app/resource/InvoiceResource.java index 2ccba67b..f65b9050 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/app/resource/InvoiceResource.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/encoding/app/resource/InvoiceResource.java @@ -39,19 +39,23 @@ import org.springframework.web.bind.annotation.RestController; @RestController public class InvoiceResource { - @RequestMapping(value = "invoices", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(value = "invoices", method = RequestMethod.GET, + produces = MediaType.APPLICATION_JSON_VALUE) public ResponseEntity> getInvoices() { return ResponseEntity.ok(createInvoiceList(100)); } - @RequestMapping(value = "invoices", method = RequestMethod.POST, consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(value = "invoices", method = RequestMethod.POST, + consumes = MediaType.APPLICATION_JSON_VALUE, + produces = MediaType.APPLICATION_JSON_VALUE) ResponseEntity> saveInvoices(@RequestBody List invoices) { return ResponseEntity.ok(invoices); } - @RequestMapping(value = "invoicesPaged", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(value = "invoicesPaged", method = RequestMethod.GET, + produces = MediaType.APPLICATION_JSON_VALUE) public ResponseEntity> getInvoicesPaged( org.springframework.data.domain.Pageable pageable) { Page page = new PageImpl<>(createInvoiceList(pageable.getPageSize()), diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/hystrix/security/HystrixSecurityTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/hystrix/security/HystrixSecurityTests.java index 44172555..206ea9c7 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/hystrix/security/HystrixSecurityTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/hystrix/security/HystrixSecurityTests.java @@ -56,8 +56,8 @@ import static org.assertj.core.api.Assertions.assertThat; */ @RunWith(SpringRunner.class) @DirtiesContext -@SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT, properties = { - "feign.hystrix.enabled=true" }) +@SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT, + properties = { "feign.hystrix.enabled=true" }) @ActiveProfiles("proxysecurity") public class HystrixSecurityTests { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonClientPathTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonClientPathTests.java index 34fb623f..b141d209 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonClientPathTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonClientPathTests.java @@ -46,11 +46,14 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen * @author Venil Noronha */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = FeignRibbonClientPathTests.Application.class, webEnvironment = RANDOM_PORT, value = { - "spring.application.name=feignribbonclientpathtest", "feign.okhttp.enabled=false", - "feign.httpclient.enabled=false", "feign.hystrix.enabled=false", - "test.path.prefix=/base/path" // For pathWithPlaceholder test -}) +@SpringBootTest(classes = FeignRibbonClientPathTests.Application.class, + webEnvironment = RANDOM_PORT, + value = { "spring.application.name=feignribbonclientpathtest", + "feign.okhttp.enabled=false", "feign.httpclient.enabled=false", + "feign.hystrix.enabled=false", "test.path.prefix=/base/path" // For + // pathWithPlaceholder + // test + }) @DirtiesContext public class FeignRibbonClientPathTests { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonClientRetryTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonClientRetryTests.java index 75e7b7f0..5ab5e86f 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonClientRetryTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonClientRetryTests.java @@ -52,11 +52,12 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen * @author Spencer Gibb */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = FeignRibbonClientRetryTests.Application.class, webEnvironment = RANDOM_PORT, value = { - "spring.application.name=feignclientretrytest", "feign.okhttp.enabled=false", - "feign.httpclient.enabled=false", "feign.hystrix.enabled=false", - "localapp.ribbon.MaxAutoRetries=2", - "localapp.ribbon.MaxAutoRetriesNextServer=3" }) +@SpringBootTest(classes = FeignRibbonClientRetryTests.Application.class, + webEnvironment = RANDOM_PORT, + value = { "spring.application.name=feignclientretrytest", + "feign.okhttp.enabled=false", "feign.httpclient.enabled=false", + "feign.hystrix.enabled=false", "localapp.ribbon.MaxAutoRetries=2", + "localapp.ribbon.MaxAutoRetriesNextServer=3" }) @DirtiesContext public class FeignRibbonClientRetryTests { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonHttpClientConfigurationTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonHttpClientConfigurationTests.java index aef5d837..56d36ae1 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonHttpClientConfigurationTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonHttpClientConfigurationTests.java @@ -44,8 +44,10 @@ import static org.assertj.core.api.Assertions.assertThat; * @author Ryan Baxter */ @RunWith(SpringRunner.class) -@SpringBootTest(classes = FeignRibbonHttpClientConfigurationTests.FeignRibbonHttpClientConfigurationTestsApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT, properties = { - "debug=true", "feign.httpclient.disableSslValidation=true" }) +@SpringBootTest( + classes = FeignRibbonHttpClientConfigurationTests.FeignRibbonHttpClientConfigurationTestsApplication.class, + webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT, + properties = { "debug=true", "feign.httpclient.disableSslValidation=true" }) @DirtiesContext public class FeignRibbonHttpClientConfigurationTests { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonOkHttpClientConfigurationTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonOkHttpClientConfigurationTests.java index fd376853..d320661f 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonOkHttpClientConfigurationTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignRibbonOkHttpClientConfigurationTests.java @@ -40,9 +40,11 @@ import static org.assertj.core.api.Assertions.assertThat; * @author Ryan Baxter */ @RunWith(SpringRunner.class) -@SpringBootTest(classes = FeignRibbonOkHttpClientConfigurationTests.FeignRibbonOkHttpClientConfigurationTestsApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT, properties = { - "debug=true", "feign.httpclient.disableSslValidation=true", - "feign.okhttp.enabled=true", "feign.httpclient.enabled=false" }) +@SpringBootTest( + classes = FeignRibbonOkHttpClientConfigurationTests.FeignRibbonOkHttpClientConfigurationTestsApplication.class, + webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT, + properties = { "debug=true", "feign.httpclient.disableSslValidation=true", + "feign.okhttp.enabled=true", "feign.httpclient.enabled=false" }) @DirtiesContext public class FeignRibbonOkHttpClientConfigurationTests { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/LoadBalancerFeignClientOverrideTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/LoadBalancerFeignClientOverrideTests.java index c238cc68..391d643f 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/LoadBalancerFeignClientOverrideTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/LoadBalancerFeignClientOverrideTests.java @@ -41,9 +41,10 @@ import static org.assertj.core.api.Assertions.assertThat; * @author Spencer Gibb */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = LoadBalancerFeignClientOverrideTests.TestConfiguration.class, webEnvironment = WebEnvironment.RANDOM_PORT, value = { - "spring.application.name=loadBalancerFeignClientTests", - "feign.httpclient.enabled=false", "feign.okhttp.enabled=false" }) +@SpringBootTest(classes = LoadBalancerFeignClientOverrideTests.TestConfiguration.class, + webEnvironment = WebEnvironment.RANDOM_PORT, + value = { "spring.application.name=loadBalancerFeignClientTests", + "feign.httpclient.enabled=false", "feign.okhttp.enabled=false" }) @DirtiesContext public class LoadBalancerFeignClientOverrideTests { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/PageableEncoderTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/PageableEncoderTests.java index 8e0e64ef..c3916507 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/PageableEncoderTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/PageableEncoderTests.java @@ -39,8 +39,9 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen * @author Charlie Mordant. */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = SpringEncoderTests.Application.class, webEnvironment = RANDOM_PORT, value = { - "spring.application.name=springencodertest", "spring.jmx.enabled=false" }) +@SpringBootTest(classes = SpringEncoderTests.Application.class, + webEnvironment = RANDOM_PORT, value = { + "spring.application.name=springencodertest", "spring.jmx.enabled=false" }) @DirtiesContext public class PageableEncoderTests { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/SpringEncoderTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/SpringEncoderTests.java index eeedb90f..0214a869 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/SpringEncoderTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/SpringEncoderTests.java @@ -62,8 +62,9 @@ import static org.springframework.http.MediaType.MULTIPART_FORM_DATA_VALUE; * @author Olga Maciaszek-Sharma */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = SpringEncoderTests.Application.class, webEnvironment = WebEnvironment.RANDOM_PORT, value = { - "spring.application.name=springencodertest", "spring.jmx.enabled=false" }) +@SpringBootTest(classes = SpringEncoderTests.Application.class, + webEnvironment = WebEnvironment.RANDOM_PORT, value = { + "spring.application.name=springencodertest", "spring.jmx.enabled=false" }) @DirtiesContext public class SpringEncoderTests { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/SpringMvcContractTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/SpringMvcContractTests.java index 3efdad96..f6c0ffac 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/SpringMvcContractTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/SpringMvcContractTests.java @@ -525,16 +525,19 @@ public class SpringMvcContractTests { public interface TestTemplate_Simple { - @RequestMapping(value = "/test/{id}", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(value = "/test/{id}", method = RequestMethod.GET, + produces = MediaType.APPLICATION_JSON_VALUE) ResponseEntity getTest(@PathVariable("id") String id); - @RequestMapping(method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(method = RequestMethod.GET, + produces = MediaType.APPLICATION_JSON_VALUE) TestObject getTest(); @GetMapping(value = "/test/{id}", produces = MediaType.APPLICATION_JSON_VALUE) ResponseEntity getMappingTest(@PathVariable("id") String id); - @RequestMapping(method = RequestMethod.POST, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(method = RequestMethod.POST, + produces = MediaType.APPLICATION_JSON_VALUE) TestObject postTest(@RequestBody TestObject object); @PostMapping(produces = MediaType.APPLICATION_JSON_VALUE) @@ -560,15 +563,16 @@ public class SpringMvcContractTests { public interface TestTemplate_Headers { - @RequestMapping(value = "/test/{id}", method = RequestMethod.GET, headers = "X-Foo=bar") + @RequestMapping(value = "/test/{id}", method = RequestMethod.GET, + headers = "X-Foo=bar") ResponseEntity getTest(@PathVariable("id") String id); } public interface TestTemplate_HeadersWithoutValues { - @RequestMapping(value = "/test/{id}", method = RequestMethod.GET, headers = { - "X-Foo", "!X-Bar", "X-Baz!=fooBar" }) + @RequestMapping(value = "/test/{id}", method = RequestMethod.GET, + headers = { "X-Foo", "!X-Bar", "X-Baz!=fooBar" }) ResponseEntity getTest(@PathVariable("id") String id); } @@ -628,21 +632,25 @@ public class SpringMvcContractTests { public interface TestTemplate_Advanced { @ExceptionHandler - @RequestMapping(path = "/test/{id}", method = RequestMethod.PUT, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(path = "/test/{id}", method = RequestMethod.PUT, + produces = MediaType.APPLICATION_JSON_VALUE) ResponseEntity getTest(@RequestHeader("Authorization") String auth, @PathVariable("id") String id, @RequestParam("amount") Integer amount); - @RequestMapping(path = "/test2", method = RequestMethod.PUT, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(path = "/test2", method = RequestMethod.PUT, + produces = MediaType.APPLICATION_JSON_VALUE) ResponseEntity getTest2( @RequestHeader(name = "Authorization") String auth, @RequestParam(name = "amount") Integer amount); @ExceptionHandler - @RequestMapping(path = "/testfallback/{id}", method = RequestMethod.PUT, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(path = "/testfallback/{id}", method = RequestMethod.PUT, + produces = MediaType.APPLICATION_JSON_VALUE) ResponseEntity getTestFallback(@RequestHeader String Authorization, @PathVariable String id, @RequestParam Integer amount); - @RequestMapping(method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(method = RequestMethod.GET, + produces = MediaType.APPLICATION_JSON_VALUE) TestObject getTest(); } @@ -652,8 +660,8 @@ public class SpringMvcContractTests { String CUSTOM_PATTERN = "dd-MM-yyyy HH:mm"; @RequestMapping(method = RequestMethod.GET) - String getTest( - @RequestParam(name = "localDateTime") @DateTimeFormat(pattern = CUSTOM_PATTERN) LocalDateTime localDateTime); + String getTest(@RequestParam(name = "localDateTime") @DateTimeFormat( + pattern = CUSTOM_PATTERN) LocalDateTime localDateTime); } @@ -662,12 +670,13 @@ public class SpringMvcContractTests { String CUSTOM_PATTERN = "$###,###.###"; @RequestMapping(method = RequestMethod.GET) - String getTest( - @RequestParam("amount") @NumberFormat(pattern = CUSTOM_PATTERN) BigDecimal amount); + String getTest(@RequestParam("amount") @NumberFormat( + pattern = CUSTOM_PATTERN) BigDecimal amount); } - @JsonAutoDetect(fieldVisibility = ANY, getterVisibility = NONE, setterVisibility = NONE) + @JsonAutoDetect(fieldVisibility = ANY, getterVisibility = NONE, + setterVisibility = NONE) public class TestObject { public String something; diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/test/ApacheHttpClientConfigurationTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/test/ApacheHttpClientConfigurationTests.java index 638f6294..83c73c0b 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/test/ApacheHttpClientConfigurationTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/test/ApacheHttpClientConfigurationTests.java @@ -65,8 +65,8 @@ import static org.mockito.Mockito.mockingDetails; * @author Ryan Baxter */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(properties = { "feign.okhttp.enabled: false", - "ribbon.eureka.enabled = false" }) +@SpringBootTest( + properties = { "feign.okhttp.enabled: false", "ribbon.eureka.enabled = false" }) @DirtiesContext public class ApacheHttpClientConfigurationTests { @@ -109,8 +109,8 @@ public class ApacheHttpClientConfigurationTests { @SpringBootConfiguration @EnableAutoConfiguration - @EnableFeignClients(clients = { - ApacheHttpClientConfigurationTestApp.FooClient.class }) + @EnableFeignClients( + clients = { ApacheHttpClientConfigurationTestApp.FooClient.class }) static class ApacheHttpClientConfigurationTestApp { @FeignClient(name = "foo", serviceId = "foo") diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignClientNotPrimaryTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignClientNotPrimaryTests.java index 4438e291..cc123d29 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignClientNotPrimaryTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignClientNotPrimaryTests.java @@ -49,10 +49,11 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen * @author Jakub Narloch */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = FeignClientNotPrimaryTests.Application.class, webEnvironment = RANDOM_PORT, value = { - "spring.application.name=feignclientnotprimarytest", - "logging.level.org.springframework.cloud.openfeign.valid=DEBUG", - "feign.httpclient.enabled=false", "feign.okhttp.enabled=false" }) +@SpringBootTest(classes = FeignClientNotPrimaryTests.Application.class, + webEnvironment = RANDOM_PORT, + value = { "spring.application.name=feignclientnotprimarytest", + "logging.level.org.springframework.cloud.openfeign.valid=DEBUG", + "feign.httpclient.enabled=false", "feign.okhttp.enabled=false" }) @DirtiesContext public class FeignClientNotPrimaryTests { @@ -101,8 +102,8 @@ public class FeignClientNotPrimaryTests { @Configuration @EnableAutoConfiguration @RestController - @EnableFeignClients(clients = { - TestClient.class }, defaultConfiguration = TestDefaultFeignConfig.class) + @EnableFeignClients(clients = { TestClient.class }, + defaultConfiguration = TestDefaultFeignConfig.class) @RibbonClient(name = "localapp", configuration = LocalRibbonClientConfiguration.class) protected static class Application { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignClientTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignClientTests.java index dd8b8650..5788abc1 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignClientTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignClientTests.java @@ -93,11 +93,12 @@ import static org.assertj.core.api.Assertions.assertThat; * @author Halvdan Hoem Grelland */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = FeignClientTests.Application.class, webEnvironment = WebEnvironment.RANDOM_PORT, value = { - "spring.application.name=feignclienttest", - "logging.level.org.springframework.cloud.openfeign.valid=DEBUG", - "feign.httpclient.enabled=false", "feign.okhttp.enabled=false", - "feign.hystrix.enabled=true" }) +@SpringBootTest(classes = FeignClientTests.Application.class, + webEnvironment = WebEnvironment.RANDOM_PORT, + value = { "spring.application.name=feignclienttest", + "logging.level.org.springframework.cloud.openfeign.valid=DEBUG", + "feign.httpclient.enabled=false", "feign.okhttp.enabled=false", + "feign.hystrix.enabled=true" }) @DirtiesContext public class FeignClientTests { @@ -441,7 +442,8 @@ public class FeignClientTests { @RequestMapping(method = RequestMethod.GET, path = "/hello") Optional getOptionalHello(); - @RequestMapping(method = RequestMethod.GET, path = "${feignClient.methodLevelRequestMappingPath}") + @RequestMapping(method = RequestMethod.GET, + path = "${feignClient.methodLevelRequestMappingPath}") Hello getHelloUsingPropertyPlaceHolder(); @RequestMapping(method = RequestMethod.GET, path = "/hello") @@ -456,15 +458,16 @@ public class FeignClientTests { @RequestMapping(method = RequestMethod.GET, path = "/helloheaders") List getHelloHeaders(); - @RequestMapping(method = RequestMethod.GET, path = "/helloheadersplaceholders", headers = "myPlaceholderHeader=${feignClient.myPlaceholderHeader}") + @RequestMapping(method = RequestMethod.GET, path = "/helloheadersplaceholders", + headers = "myPlaceholderHeader=${feignClient.myPlaceholderHeader}") String getHelloHeadersPlaceholders(); @RequestMapping(method = RequestMethod.GET, path = "/helloparams") List getParams(@RequestParam("params") List params); @RequestMapping(method = RequestMethod.GET, path = "/formattedparams") - List getFormattedParams( - @RequestParam("params") @DateTimeFormat(pattern = "dd-MM-yyyy") List params); + List getFormattedParams(@RequestParam("params") @DateTimeFormat( + pattern = "dd-MM-yyyy") List params); @RequestMapping(method = RequestMethod.GET, path = "/hellos") HystrixCommand> getHellosHystrix(); @@ -478,7 +481,10 @@ public class FeignClientTests { @RequestMapping(method = RequestMethod.GET, path = "/hello") HttpEntity getHelloEntity(); - @RequestMapping(method = RequestMethod.POST, consumes = "application/vnd.io.spring.cloud.test.v1+json", produces = "application/vnd.io.spring.cloud.test.v1+json", path = "/complex") + @RequestMapping(method = RequestMethod.POST, + consumes = "application/vnd.io.spring.cloud.test.v1+json", + produces = "application/vnd.io.spring.cloud.test.v1+json", + path = "/complex") String moreComplexContentType(String body); @RequestMapping(method = RequestMethod.GET, path = "/tostring") @@ -539,7 +545,8 @@ public class FeignClientTests { } - @FeignClient(name = "localapp6", fallbackFactory = InvalidTypeHystrixClientFallbackFactory.class) + @FeignClient(name = "localapp6", + fallbackFactory = InvalidTypeHystrixClientFallbackFactory.class) protected interface InvalidTypeHystrixClientWithFallBackFactory { @RequestMapping(method = RequestMethod.GET, path = "/fail") @@ -547,7 +554,8 @@ public class FeignClientTests { } - @FeignClient(name = "localapp7", fallbackFactory = NullHystrixClientFallbackFactory.class) + @FeignClient(name = "localapp7", + fallbackFactory = NullHystrixClientFallbackFactory.class) protected interface NullHystrixClientWithFallBackFactory { @RequestMapping(method = RequestMethod.GET, path = "/fail") @@ -555,7 +563,8 @@ public class FeignClientTests { } - @FeignClient(name = "localapp5", configuration = TestHystrixSetterFactoryClientConfig.class) + @FeignClient(name = "localapp5", + configuration = TestHystrixSetterFactoryClientConfig.class) protected interface HystrixSetterFactoryClient { @RequestMapping(method = RequestMethod.GET, path = "/hellos") @@ -697,16 +706,25 @@ public class FeignClientTests { DecodingTestClient.class, HystrixClient.class, HystrixClientWithFallBackFactory.class, HystrixSetterFactoryClient.class, InvalidTypeHystrixClientWithFallBackFactory.class, - NullHystrixClientWithFallBackFactory.class }, defaultConfiguration = TestDefaultFeignConfig.class) + NullHystrixClientWithFallBackFactory.class }, + defaultConfiguration = TestDefaultFeignConfig.class) @RibbonClients({ - @RibbonClient(name = "localapp", configuration = LocalRibbonClientConfiguration.class), - @RibbonClient(name = "localapp1", configuration = LocalRibbonClientConfiguration.class), - @RibbonClient(name = "localapp2", configuration = LocalRibbonClientConfiguration.class), - @RibbonClient(name = "localapp3", configuration = LocalRibbonClientConfiguration.class), - @RibbonClient(name = "localapp4", configuration = LocalRibbonClientConfiguration.class), - @RibbonClient(name = "localapp5", configuration = LocalRibbonClientConfiguration.class), - @RibbonClient(name = "localapp6", configuration = LocalRibbonClientConfiguration.class), - @RibbonClient(name = "localapp7", configuration = LocalRibbonClientConfiguration.class) }) + @RibbonClient(name = "localapp", + configuration = LocalRibbonClientConfiguration.class), + @RibbonClient(name = "localapp1", + configuration = LocalRibbonClientConfiguration.class), + @RibbonClient(name = "localapp2", + configuration = LocalRibbonClientConfiguration.class), + @RibbonClient(name = "localapp3", + configuration = LocalRibbonClientConfiguration.class), + @RibbonClient(name = "localapp4", + configuration = LocalRibbonClientConfiguration.class), + @RibbonClient(name = "localapp5", + configuration = LocalRibbonClientConfiguration.class), + @RibbonClient(name = "localapp6", + configuration = LocalRibbonClientConfiguration.class), + @RibbonClient(name = "localapp7", + configuration = LocalRibbonClientConfiguration.class) }) @Import(NoSecurityConfiguration.class) protected static class Application { @@ -809,8 +827,8 @@ public class FeignClientTests { } @RequestMapping(method = RequestMethod.GET, path = "/formattedparams") - public List getFormattedParams( - @RequestParam("params") @DateTimeFormat(pattern = "dd-MM-yyyy") List params) { + public List getFormattedParams(@RequestParam("params") @DateTimeFormat( + pattern = "dd-MM-yyyy") List params) { return params; } @@ -834,7 +852,10 @@ public class FeignClientTests { return ResponseEntity.status(HttpStatus.NOT_FOUND).body((String) null); } - @RequestMapping(method = RequestMethod.POST, consumes = "application/vnd.io.spring.cloud.test.v1+json", produces = "application/vnd.io.spring.cloud.test.v1+json", path = "/complex") + @RequestMapping(method = RequestMethod.POST, + consumes = "application/vnd.io.spring.cloud.test.v1+json", + produces = "application/vnd.io.spring.cloud.test.v1+json", + path = "/complex") String complex(@RequestBody String body, @RequestHeader("Content-Length") int contentLength) { if (contentLength <= 0) { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignHttpClientTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignHttpClientTests.java index 7b737ea0..8267c67d 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignHttpClientTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignHttpClientTests.java @@ -56,9 +56,10 @@ import static org.assertj.core.api.Assertions.assertThat; * @author Spencer Gibb */ @RunWith(SpringRunner.class) -@SpringBootTest(classes = FeignHttpClientTests.Application.class, webEnvironment = WebEnvironment.RANDOM_PORT, value = { - "spring.application.name=feignclienttest", "feign.hystrix.enabled=false", - "feign.okhttp.enabled=false" }) +@SpringBootTest(classes = FeignHttpClientTests.Application.class, + webEnvironment = WebEnvironment.RANDOM_PORT, + value = { "spring.application.name=feignclienttest", + "feign.hystrix.enabled=false", "feign.okhttp.enabled=false" }) @DirtiesContext public class FeignHttpClientTests { @@ -113,17 +114,20 @@ public class FeignHttpClientTests { protected interface BaseTestClient { - @RequestMapping(method = RequestMethod.GET, value = "/hello", produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(method = RequestMethod.GET, value = "/hello", + produces = MediaType.APPLICATION_JSON_VALUE) Hello getHello(); - @RequestMapping(method = RequestMethod.PATCH, value = "/hellop", consumes = "application/json") + @RequestMapping(method = RequestMethod.PATCH, value = "/hellop", + consumes = "application/json") ResponseEntity patchHello(Hello hello); } protected interface UserService { - @RequestMapping(method = RequestMethod.GET, value = "/users/{id}", produces = MediaType.APPLICATION_JSON_VALUE) + @RequestMapping(method = RequestMethod.GET, value = "/users/{id}", + produces = MediaType.APPLICATION_JSON_VALUE) User getUser(@PathVariable("id") long id); } @@ -138,8 +142,10 @@ public class FeignHttpClientTests { @RestController @EnableFeignClients(clients = { TestClient.class, UserClient.class }) @RibbonClients({ - @RibbonClient(name = "localapp", configuration = LocalRibbonClientConfiguration.class), - @RibbonClient(name = "localapp1", configuration = LocalRibbonClientConfiguration.class) }) + @RibbonClient(name = "localapp", + configuration = LocalRibbonClientConfiguration.class), + @RibbonClient(name = "localapp1", + configuration = LocalRibbonClientConfiguration.class) }) @Import(NoSecurityConfiguration.class) protected static class Application implements UserService { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignOkHttpTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignOkHttpTests.java index db1bfb4b..62feb91b 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignOkHttpTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/FeignOkHttpTests.java @@ -55,10 +55,12 @@ import static org.assertj.core.api.Assertions.assertThat; * @author Spencer Gibb */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = FeignOkHttpTests.Application.class, webEnvironment = WebEnvironment.RANDOM_PORT, value = { - "spring.application.name=feignclienttest", "feign.hystrix.enabled=false", - "feign.httpclient.enabled=false", "feign.okhttp.enabled=true", - "spring.cloud.httpclientfactories.ok.enabled=true" }) +@SpringBootTest(classes = FeignOkHttpTests.Application.class, + webEnvironment = WebEnvironment.RANDOM_PORT, + value = { "spring.application.name=feignclienttest", + "feign.hystrix.enabled=false", "feign.httpclient.enabled=false", + "feign.okhttp.enabled=true", + "spring.cloud.httpclientfactories.ok.enabled=true" }) @DirtiesContext public class FeignOkHttpTests { @@ -116,7 +118,8 @@ public class FeignOkHttpTests { @RequestMapping(method = RequestMethod.GET, value = "/hello") Hello getHello(); - @RequestMapping(method = RequestMethod.PATCH, value = "/hellop", consumes = "application/json") + @RequestMapping(method = RequestMethod.PATCH, value = "/hellop", + consumes = "application/json") ResponseEntity patchHello(Hello hello); } @@ -138,8 +141,10 @@ public class FeignOkHttpTests { @RestController @EnableFeignClients(clients = { TestClient.class, UserClient.class }) @RibbonClients({ - @RibbonClient(name = "localapp", configuration = LocalRibbonClientConfiguration.class), - @RibbonClient(name = "localapp1", configuration = LocalRibbonClientConfiguration.class) }) + @RibbonClient(name = "localapp", + configuration = LocalRibbonClientConfiguration.class), + @RibbonClient(name = "localapp1", + configuration = LocalRibbonClientConfiguration.class) }) @Import(NoSecurityConfiguration.class) protected static class Application implements UserService { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/IterableParameterTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/IterableParameterTests.java index 1cb2064d..975b819a 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/IterableParameterTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/IterableParameterTests.java @@ -48,11 +48,12 @@ import static org.assertj.core.api.Assertions.assertThat; * @author Spencer Gibb */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = IterableParameterTests.Application.class, webEnvironment = WebEnvironment.RANDOM_PORT, value = { - "spring.application.name=iterableparametertest", - "logging.level.org.springframework.cloud.openfeign.valid=DEBUG", - "feign.httpclient.enabled=false", "feign.okhttp.enabled=false", - "feign.hystrix.enabled=false" }) +@SpringBootTest(classes = IterableParameterTests.Application.class, + webEnvironment = WebEnvironment.RANDOM_PORT, + value = { "spring.application.name=iterableparametertest", + "logging.level.org.springframework.cloud.openfeign.valid=DEBUG", + "feign.httpclient.enabled=false", "feign.okhttp.enabled=false", + "feign.hystrix.enabled=false" }) @DirtiesContext public class IterableParameterTests { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/scanning/FeignClientEnvVarTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/scanning/FeignClientEnvVarTests.java index 5e57b349..68b3921c 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/scanning/FeignClientEnvVarTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/scanning/FeignClientEnvVarTests.java @@ -46,9 +46,11 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen * @author Ryan Baxter */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = FeignClientEnvVarTests.Application.class, webEnvironment = RANDOM_PORT, value = { - "spring.application.name=feignclienttest", "feign.httpclient.enabled=false", - "basepackage=org.springframework.cloud.openfeign.testclients" }) +@SpringBootTest(classes = FeignClientEnvVarTests.Application.class, + webEnvironment = RANDOM_PORT, + value = { "spring.application.name=feignclienttest", + "feign.httpclient.enabled=false", + "basepackage=org.springframework.cloud.openfeign.testclients" }) @DirtiesContext public class FeignClientEnvVarTests { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/scanning/FeignClientScanningTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/scanning/FeignClientScanningTests.java index 00517e93..0fa4a115 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/scanning/FeignClientScanningTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/valid/scanning/FeignClientScanningTests.java @@ -47,8 +47,9 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen * @author Spencer Gibb */ @RunWith(SpringJUnit4ClassRunner.class) -@SpringBootTest(classes = FeignClientScanningTests.Application.class, webEnvironment = RANDOM_PORT, value = { - "spring.application.name=feignclienttest", "feign.httpclient.enabled=false" }) +@SpringBootTest(classes = FeignClientScanningTests.Application.class, + webEnvironment = RANDOM_PORT, value = { "spring.application.name=feignclienttest", + "feign.httpclient.enabled=false" }) @DirtiesContext public class FeignClientScanningTests {