diff --git a/spring-cloud-openfeign-core/pom.xml b/spring-cloud-openfeign-core/pom.xml index 9bf0009d..d0a1c9a4 100644 --- a/spring-cloud-openfeign-core/pom.xml +++ b/spring-cloud-openfeign-core/pom.xml @@ -123,11 +123,6 @@ feign-okhttp true - - io.github.openfeign - feign-java8 - true - com.netflix.hystrix hystrix-core diff --git a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/loadbalancer/FeignBlockingLoadBalancerClient.java b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/loadbalancer/FeignBlockingLoadBalancerClient.java index 82dd8401..0dcd9aca 100644 --- a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/loadbalancer/FeignBlockingLoadBalancerClient.java +++ b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/loadbalancer/FeignBlockingLoadBalancerClient.java @@ -73,7 +73,7 @@ public class FeignBlockingLoadBalancerClient implements Client { String reconstructedUrl = loadBalancerClient.reconstructURI(instance, originalUri) .toString(); Request newRequest = Request.create(request.httpMethod(), reconstructedUrl, - request.headers(), request.requestBody()); + request.headers(), request.requestBody().asBytes(), request.charset()); return delegate.execute(newRequest, options); } diff --git a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/ribbon/FeignLoadBalancer.java b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/ribbon/FeignLoadBalancer.java index 2a449fa9..b3a7c4c8 100644 --- a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/ribbon/FeignLoadBalancer.java +++ b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/ribbon/FeignLoadBalancer.java @@ -134,7 +134,7 @@ public class FeignLoadBalancer extends Map> headers = new LinkedHashMap<>( request.headers()); return Request.create(request.httpMethod(), getUri().toASCIIString(), headers, - request.requestBody()); + request.requestBody().asBytes(), request.charset()); } Request toRequest() { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/loadbalancer/FeignBlockingLoadBalancerClientTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/loadbalancer/FeignBlockingLoadBalancerClientTests.java index e8502bb0..d64dcbe6 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/loadbalancer/FeignBlockingLoadBalancerClientTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/loadbalancer/FeignBlockingLoadBalancerClientTests.java @@ -130,8 +130,7 @@ class FeignBlockingLoadBalancerClientTests { private Request testRequest(String host) { return Request.create(Request.HttpMethod.GET, "http://" + host + "/path", - testHeaders(), - Request.Body.encoded("hello".getBytes(), StandardCharsets.UTF_8)); + testHeaders(), "hello".getBytes(), StandardCharsets.UTF_8); } private Map> testHeaders() { diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignLoadBalancerTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignLoadBalancerTests.java index 9faeb049..a8c3b37c 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignLoadBalancerTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/FeignLoadBalancerTests.java @@ -159,7 +159,7 @@ public class FeignLoadBalancerTests { @Test public void testRibbonRequestURLEncode() throws Exception { String url = "https://foo/?name=%7bcookie"; // name={cookie - Request request = Request.create(GET, url, new HashMap<>(), null, null); + Request request = Request.create(GET, url, new HashMap<>(), null, null, null); assertThat(request.url()).isEqualTo(url); diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/RibbonResponseStatusCodeExceptionTest.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/RibbonResponseStatusCodeExceptionTest.java index f2d47fb7..686d1294 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/RibbonResponseStatusCodeExceptionTest.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/ribbon/RibbonResponseStatusCodeExceptionTest.java @@ -44,13 +44,12 @@ public class RibbonResponseStatusCodeExceptionTest { @Test public void getResponse() throws Exception { - Map> headers = new HashMap>(); - List fooValues = new ArrayList(); + Map> headers = new HashMap<>(); + List fooValues = new ArrayList<>(); fooValues.add("bar"); headers.put("foo", fooValues); - Request request = Request.create(GET, "https://service.com", - new HashMap>(), new byte[] {}, - Charset.defaultCharset()); + Request request = Request.create(GET, "https://service.com", new HashMap<>(), + new byte[] {}, Charset.defaultCharset()); byte[] body = "foo".getBytes(); ByteArrayInputStream is = new ByteArrayInputStream(body); Response response = Response.builder().status(200).reason("Success") diff --git a/spring-cloud-openfeign-dependencies/pom.xml b/spring-cloud-openfeign-dependencies/pom.xml index 7275e49e..3602be91 100644 --- a/spring-cloud-openfeign-dependencies/pom.xml +++ b/spring-cloud-openfeign-dependencies/pom.xml @@ -15,7 +15,7 @@ spring-cloud-openfeign-dependencies Spring Cloud OpenFeign Dependencies - 10.4.0 + 10.7.0 3.8.0 @@ -55,11 +55,6 @@ feign-hystrix ${feign.version} - - io.github.openfeign - feign-java8 - ${feign.version} - io.github.openfeign feign-okhttp diff --git a/spring-cloud-starter-openfeign/pom.xml b/spring-cloud-starter-openfeign/pom.xml index 915fff3d..027c4068 100644 --- a/spring-cloud-starter-openfeign/pom.xml +++ b/spring-cloud-starter-openfeign/pom.xml @@ -48,10 +48,6 @@ io.github.openfeign feign-hystrix - - io.github.openfeign - feign-java8 - org.springframework.cloud spring-cloud-starter-netflix-ribbon