From 8f5e3ad7c0ff9a057ef9cd6e2b8f76ba43d61fd8 Mon Sep 17 00:00:00 2001 From: Spencer Gibb Date: Wed, 15 Feb 2017 14:43:19 -0700 Subject: [PATCH] polish --- .../cloud/netflix/feign/FeignClientsRegistrar.java | 6 ++---- .../cloud/netflix/feign/FeignClientsRegistrarTests.java | 2 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/feign/FeignClientsRegistrar.java b/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/feign/FeignClientsRegistrar.java index 2ed76819..9eb0e315 100644 --- a/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/feign/FeignClientsRegistrar.java +++ b/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/feign/FeignClientsRegistrar.java @@ -237,10 +237,8 @@ class FeignClientsRegistrar implements ImportBeanDefinitionRegistrar, } private String resolve(String value) { - if (StringUtils.hasText(value) - && this.resourceLoader instanceof ConfigurableApplicationContext) { - return ((ConfigurableApplicationContext) this.resourceLoader).getEnvironment() - .resolvePlaceholders(value); + if (StringUtils.hasText(value)) { + return this.environment.resolvePlaceholders(value); } return value; } diff --git a/spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/feign/FeignClientsRegistrarTests.java b/spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/feign/FeignClientsRegistrarTests.java index fb349686..5387f601 100644 --- a/spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/feign/FeignClientsRegistrarTests.java +++ b/spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/feign/FeignClientsRegistrarTests.java @@ -20,6 +20,7 @@ package org.springframework.cloud.netflix.feign; import java.util.Collections; import org.junit.Test; +import org.springframework.mock.env.MockEnvironment; import static org.hamcrest.Matchers.is; import static org.junit.Assert.assertThat; @@ -70,6 +71,7 @@ public class FeignClientsRegistrarTests { private String testGetName(String name) { FeignClientsRegistrar registrar = new FeignClientsRegistrar(); + registrar.setEnvironment(new MockEnvironment()); return registrar.getName(Collections.singletonMap("name", name)); } }