From 89db04d7d080f8fa22bfeb20651387eea9b6dfe4 Mon Sep 17 00:00:00 2001 From: Olga Maciaszek-Sharma Date: Wed, 27 Jan 2021 13:33:57 +0100 Subject: [PATCH 1/3] Fix broken reference in docs. --- docs/src/main/asciidoc/spring-cloud-openfeign.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/src/main/asciidoc/spring-cloud-openfeign.adoc b/docs/src/main/asciidoc/spring-cloud-openfeign.adoc index 659ede2e..816792c5 100644 --- a/docs/src/main/asciidoc/spring-cloud-openfeign.adoc +++ b/docs/src/main/asciidoc/spring-cloud-openfeign.adoc @@ -459,14 +459,14 @@ Spring Cloud CircuitBreaker supports the notion of a fallback: a default code pa [source,java,indent=0] ---- -include::{core_path}/src/test/java/org/springframework/cloud/openfeign/circuitbreaker/CirciutBreakerTests.java[tags=client_with_fallback, indent=0] +include::{core_path}/src/test/java/org/springframework/cloud/openfeign/circuitbreaker/CircuitBreakerTests.java[tags=client_with_fallback, indent=0] ---- If one needs access to the cause that made the fallback trigger, one can use the `fallbackFactory` attribute inside `@FeignClient`. [source,java,indent=0] ---- -include::{core_path}/src/test/java/org/springframework/cloud/openfeign/circuitbreaker/CirciutBreakerTests.java[tags=client_with_fallback_factory, indent=0] +include::{core_path}/src/test/java/org/springframework/cloud/openfeign/circuitbreaker/CircuitBreakerTests.java[tags=client_with_fallback_factory, indent=0] ---- === Feign and `@Primary` From 60558c46ef53ada2833dcb4e114d86d41a465f26 Mon Sep 17 00:00:00 2001 From: Olga Maciaszek-Sharma Date: Tue, 2 Feb 2021 15:31:06 +0100 Subject: [PATCH 2/3] Reformat. --- .../cloud/openfeign/support/PageJacksonModuleTests.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/PageJacksonModuleTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/PageJacksonModuleTests.java index 8cf97fe2..89a18148 100644 --- a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/PageJacksonModuleTests.java +++ b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/PageJacksonModuleTests.java @@ -43,10 +43,12 @@ public class PageJacksonModuleTests { } @ParameterizedTest - @ValueSource(strings = {"totalElements", "total-elements", "total_elements", "totalelements", "TotalElements"}) + @ValueSource(strings = { "totalElements", "total-elements", "total_elements", + "totalelements", "TotalElements" }) public void deserializePage(String totalElements) throws JsonProcessingException { // Given - String pageJson = "{\"content\":[\"A name\"], \"number\":1, \"size\":2, \"" + totalElements + "\": 3}"; + String pageJson = "{\"content\":[\"A name\"], \"number\":1, \"size\":2, \"" + + totalElements + "\": 3}"; // When Page result = objectMapper.readValue(pageJson, Page.class); // Then From 9bb8b43d5893847c75ca544876fa5871c12da5b2 Mon Sep 17 00:00:00 2001 From: Tim Peeters Date: Mon, 8 Feb 2021 16:18:52 +0100 Subject: [PATCH 3/3] Import OpenFeign bom --- spring-cloud-openfeign-dependencies/pom.xml | 64 +-------------------- 1 file changed, 3 insertions(+), 61 deletions(-) diff --git a/spring-cloud-openfeign-dependencies/pom.xml b/spring-cloud-openfeign-dependencies/pom.xml index f5cc521d..6d5aabcd 100644 --- a/spring-cloud-openfeign-dependencies/pom.xml +++ b/spring-cloud-openfeign-dependencies/pom.xml @@ -32,74 +32,16 @@ io.github.openfeign - feign-core + feign-bom ${feign.version} + pom + import io.github.openfeign.form feign-form-spring ${feign-form.version} - - io.github.openfeign - feign-slf4j - ${feign.version} - - - io.github.openfeign - feign-httpclient - ${feign.version} - - - io.github.openfeign - feign-hystrix - ${feign.version} - - - io.github.openfeign - feign-okhttp - ${feign.version} - - - io.github.openfeign - feign-gson - ${feign.version} - - - io.github.openfeign - feign-jackson-jaxb - ${feign.version} - - - io.github.openfeign - feign-jackson - ${feign.version} - - - io.github.openfeign - feign-jaxb - ${feign.version} - - - io.github.openfeign - feign-jaxrs - ${feign.version} - - - io.github.openfeign - feign-ribbon - ${feign.version} - - - io.github.openfeign - feign-sax - ${feign.version} - - - io.github.openfeign - feign-mock - ${feign.version} -