From c3475f194e02232d824c93378a74c98b280c1dfb Mon Sep 17 00:00:00 2001 From: Ryan Baxter Date: Fri, 26 Jan 2018 10:20:46 -0500 Subject: [PATCH] Fix failing unit test --- .../cloud/netflix/feign/FeignHttpClientUrlTests.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/feign/FeignHttpClientUrlTests.java b/spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/feign/FeignHttpClientUrlTests.java index ca897843..38fcd89f 100644 --- a/spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/feign/FeignHttpClientUrlTests.java +++ b/spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/feign/FeignHttpClientUrlTests.java @@ -31,14 +31,13 @@ import org.junit.BeforeClass; import org.junit.Test; import org.junit.runner.RunWith; import org.springframework.beans.factory.annotation.Autowired; -import org.springframework.beans.factory.annotation.Value; import org.springframework.boot.autoconfigure.EnableAutoConfiguration; import org.springframework.boot.test.context.SpringBootTest; import org.springframework.boot.test.context.SpringBootTest.WebEnvironment; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; import org.springframework.test.annotation.DirtiesContext; -import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; +import org.springframework.test.context.junit4.SpringRunner; import org.springframework.util.ReflectionUtils; import org.springframework.util.SocketUtils; import org.springframework.web.bind.annotation.RequestMapping; @@ -53,16 +52,18 @@ import feign.httpclient.ApacheHttpClient; /** * @author Spencer Gibb */ -@RunWith(SpringJUnit4ClassRunner.class) +@RunWith(SpringRunner.class) @SpringBootTest(classes = FeignHttpClientUrlTests.TestConfig.class, webEnvironment = WebEnvironment.DEFINED_PORT, value = { "spring.application.name=feignclienturltest", "feign.hystrix.enabled=false", "feign.okhttp.enabled=false" }) @DirtiesContext public class FeignHttpClientUrlTests { + static int port; + @BeforeClass public static void beforeClass() { - int port = SocketUtils.findAvailableTcpPort(); + port = SocketUtils.findAvailableTcpPort(); System.setProperty("server.port", String.valueOf(port)); } @@ -103,8 +104,6 @@ public class FeignHttpClientUrlTests { @RestController @EnableFeignClients(clients = { UrlClient.class, BeanUrlClient.class, BeanUrlClientNoProtocol.class }) protected static class TestConfig { - @Value("${server.port}") - private int port; @RequestMapping(method = RequestMethod.GET, value = "/hello") public Hello getHello() {