From c568ded7c9e37dbe57fdf580117324c32c84ef6d Mon Sep 17 00:00:00 2001 From: Spencer Gibb Date: Wed, 27 Sep 2017 16:13:38 -0400 Subject: [PATCH] remove TODO since servlet 3.0 support is still needed. --- .../cloud/netflix/zuul/filters/post/SendResponseFilter.java | 2 +- .../cloud/netflix/zuul/filters/route/RibbonRoutingFilter.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/post/SendResponseFilter.java b/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/post/SendResponseFilter.java index 7c178a62..19b547c9 100644 --- a/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/post/SendResponseFilter.java +++ b/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/post/SendResponseFilter.java @@ -72,8 +72,8 @@ public class SendResponseFilter extends ZuulFilter { public SendResponseFilter() { super(); // To support Servlet API 3.1 we need to check if setContentLengthLong exists + // minimum support in Spring 5 is 3.0 so we need to keep tihs try { - //TODO: remove in 2.0 HttpServletResponse.class.getMethod("setContentLengthLong", long.class); } catch(NoSuchMethodException e) { useServlet31 = false; diff --git a/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/route/RibbonRoutingFilter.java b/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/route/RibbonRoutingFilter.java index 36f86150..94267eff 100644 --- a/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/route/RibbonRoutingFilter.java +++ b/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/route/RibbonRoutingFilter.java @@ -69,8 +69,8 @@ public class RibbonRoutingFilter extends ZuulFilter { this.ribbonCommandFactory = ribbonCommandFactory; this.requestCustomizers = requestCustomizers; // To support Servlet API 3.1 we need to check if getContentLengthLong exists + // Spring 5 minimum support is 3.0, so this stays try { - //TODO: remove in 2.0 HttpServletRequest.class.getMethod("getContentLengthLong"); } catch(NoSuchMethodException e) { useServlet31 = false;