From b6422db8e9a5067b8b1d7ca28421ce05681ad415 Mon Sep 17 00:00:00 2001 From: spencergibb Date: Mon, 3 Aug 2020 13:21:17 -0400 Subject: [PATCH 1/3] ignores .sdkmanrc --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 8a860b40..727dacbd 100644 --- a/.gitignore +++ b/.gitignore @@ -20,4 +20,5 @@ _site/ *.swo .vscode/ .flattened-pom.xml +.sdkmanrc From 84819e1328d2d7135be07aaeb62956462f43eca4 Mon Sep 17 00:00:00 2001 From: spencergibb Date: Mon, 3 Aug 2020 13:21:35 -0400 Subject: [PATCH 2/3] Bumps s-c-build to 2.3.2.BUILD-SNAPSHOT --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f07ddbe9..709baa48 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ org.springframework.cloud spring-cloud-build - 2.3.1.RELEASE + 2.3.2.BUILD-SNAPSHOT From b66e08fda8756644f09b6a65334f015c07093c7f Mon Sep 17 00:00:00 2001 From: Olga Maciaszek-Sharma Date: Thu, 13 Aug 2020 14:37:55 +0200 Subject: [PATCH 3/3] Fix the docs. --- docs/src/main/asciidoc/spring-cloud-openfeign.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/src/main/asciidoc/spring-cloud-openfeign.adoc b/docs/src/main/asciidoc/spring-cloud-openfeign.adoc index 7cc78857..de543470 100644 --- a/docs/src/main/asciidoc/spring-cloud-openfeign.adoc +++ b/docs/src/main/asciidoc/spring-cloud-openfeign.adoc @@ -112,7 +112,7 @@ public interface StoreClient { } ---- -Spring Cloud Netflix provides the following beans by default for feign (`BeanType` beanName: `ClassName`): +Spring Cloud OpenFeign provides the following beans by default for feign (`BeanType` beanName: `ClassName`): * `Decoder` feignDecoder: `ResponseEntityDecoder` (which wraps a `SpringDecoder`) * `Encoder` feignEncoder: `SpringEncoder` @@ -305,7 +305,7 @@ class FooController { ---- NOTE: In the above example `FeignClientsConfiguration.class` is the default configuration -provided by Spring Cloud Netflix. +provided by Spring Cloud OpenFeign. NOTE: `PROD-SVC` is the name of the service the Clients will be making requests to. @@ -388,7 +388,7 @@ WARNING: There is a limitation with the implementation of fallbacks in Feign and === Feign and `@Primary` -When using Feign with Hystrix fallbacks, there are multiple beans in the `ApplicationContext` of the same type. This will cause `@Autowired` to not work because there isn't exactly one bean, or one marked as primary. To work around this, Spring Cloud Netflix marks all Feign instances as `@Primary`, so Spring Framework will know which bean to inject. In some cases, this may not be desirable. To turn off this behavior set the `primary` attribute of `@FeignClient` to false. +When using Feign with Hystrix fallbacks, there are multiple beans in the `ApplicationContext` of the same type. This will cause `@Autowired` to not work because there isn't exactly one bean, or one marked as primary. To work around this, Spring Cloud OpenFeign marks all Feign instances as `@Primary`, so Spring Framework will know which bean to inject. In some cases, this may not be desirable. To turn off this behavior set the `primary` attribute of `@FeignClient` to false. [source,java,indent=0] ----