SpringCloud/spring-cloud-openfeign
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
1,044 Commits 28 Branches 0 Tags
2ff2ce4de46aebdee6111f23211f8dfbcdb49ea5
Commit Graph

505 Commits

Author SHA1 Message Date
Dave Syer
880efd1843 Remove @AliasFor from @FeignClient.serviceId() 
The way it was being used internally means that we didn't need the
annotation anyway. It would be nice to have it back if the Spring
issue gets resolved, because then we could actually use it as
intended.

Fixes gh-1025
 2016-05-17 15:33:42 +01:00
Dave Syer
9823d07817 Revert "Add support in SpringMvcContract for query string in Class @RequestMapping" 
This reverts commit 2c502e3997.
 2016-05-17 15:26:34 +01:00
Jacques-Etienne Beaudet
2c502e3997 Add support in SpringMvcContract for query string in Class @RequestMapping 
This commit adds the support for query string defined in the class'
@RequestMapping Annotation that is applied to all method of a
controller.

Fxies gh-1023, fixes gh-1024
 2016-05-17 12:08:49 +01:00
Dave Syer
5d50a773e7 Make test more robust by creating feign clients and validating them 
This test should run with Spring Boot 1.4.0.M2 now.

See https://github.com/spring-projects/spring-boot/issues/5870
 2016-05-11 10:22:57 +01:00
Dave Syer
617ecf11ec Track customization of sensitive headers so route can be cleared 
When the users explicitly sets the sensitive headers of a rroute to
empty, it means they should be empty, not the global defaults.

Fixes gh-1012
 2016-05-09 11:47:41 +01:00
Venil Noronha
d3cba4d80e Adds path parameter to @FeignClient. 
Fixes gh-966
 2016-05-06 14:06:22 -06:00
Spencer Gibb
4888299b28 polish 2016-05-06 10:54:29 -06:00
Dave Syer
5de52b96f4 Some changes to help with Spring Boot 1.4 compatibility 
The jackson version needs to be explicit (not in parent potentially)
and there is a weirdness with @RequestMapping in Spring 4.3
 2016-05-05 16:55:09 +01:00
Jacques-Etienne Beaudet
ea1a4c5add Sensitive headers set in PreDecorationFilter no longer override previously set ignored headers. 
Removed the case sensitiveness when the sensitive headers are set.
Fixes https://github.com/spring-cloud/spring-cloud-netflix/issues/1003
 2016-05-04 13:40:21 -04:00
Dave Syer
88864153eb Test for default ribbon client configuration 2016-05-04 08:50:57 +01:00
Dave Syer
9ad3d21b75 Tidy up more compiler warnings for generics 2016-05-03 11:53:22 +01:00
Spencer Gibb
860d7b8446 Log warning if ServoMonitorCache size exceeds threshold. 
Fixes gh-947
 2016-05-02 12:27:33 -06:00
Sébastien PERALTA
5613e48141 Append to X-Forwarded-Prefix in case it already exists 
Fixes gh-993
 2016-04-28 13:22:38 +01:00
Dave Syer
3a251e2a38 Revert "Use the original query string when forwarding the request" 
This reverts commit 8952cff24d.
 2016-04-28 12:03:10 +01:00
Dave Syer
c7c191c01e Ensure Servo metrics are exported the same as default metrics 
Adds an `@ExportMetricReader` which was missing before and
led to people losing their metric exports when they had Servo
on the classpath.

Also allow servo metrics autoconfiguration to be disabled via
a flag netflix.metrics.servo.enabled=false (as an alternative to
excluding the class in `@EnableAutoConfiguration`).
 2016-04-28 11:57:00 +01:00
Nicolas Byl
8952cff24d Use the original query string when forwarding the request 
to ensure compatibility with legacy apps

Fixes gh-989
 2016-04-26 17:31:22 +01:00
Dave Syer
314d229ccf Add @ConditionalOnEnabledHealthIndicator("hystrix") 
Users will have to switch from health.hystrix.enabled to
management.health.* for consistency with other health
indicators.

Fixes gh-985
 2016-04-26 09:13:06 +01:00
Spencer Gibb
5acf4e1a2e Throw IOException in RibbonLoadBalancerClient.execute 
Fixes proper RestTemplate behavior.

fixes gh-986
 2016-04-25 13:48:00 -06:00
Pedro Alvarado
2b40952429 Add support for placeholders to Feign spring-mvc RequestMapping annotation. 
Fixes gh-894
 2016-04-25 11:01:26 +01:00
Spencer Gibb
e0c67b30f8 Pass headers back to feign request. 
Spring HttpMessageConverters can modify headers. This change passes the modified headersr back to the feign request, so the proper headers are sent on the request.

 fixes gh-977
 2016-04-20 06:46:23 -06:00
Dave Syer
5fc76aaa72 Fix javadocs in @FeignClient 
The descriptions of name/serviceId/value and url were out of date
(name is mandatory now and can be mixed with url).
 2016-04-19 14:58:59 +01:00
Spencer Gibb
df5303912f Add global zuul sensitiveHeaders option. 
Route specific sensitiveHeaders override global.

fixes gh-944
 2016-04-08 10:38:24 -06:00
Tyler Van Gorder
05351b7809 Ribbon retry works & fix Content-Length error. 
This change requires setting `ribbon.http.client.enabled=true`.

This change addresses issue #648 Getting Retry Working In RestTemplate. There is also a fix in place that addresses the issue #357 RestTemplate Error.

fixes gh-648
 2016-04-07 16:15:03 -06:00
Spencer Gibb
a3ab3259e3 Make RibbonClientHttpRequestFactory disabled by default. 
fixes gh-961
 2016-04-07 15:10:39 -06:00
Adrian Ivan
d0841f792e Send 404 in zuul servlet when no route is found. 
Fixes false 200 in zuul when using zuul servlet rather than mvc servlet.

Fixes gh-865
 2016-04-07 13:44:29 -06:00
Tim te Beek
593549551a Set or append to X-Forwarded-For for downstream requests 
Fixes gh-352
 2016-04-05 15:42:56 +01:00
Tyler Van Gorder
983221a710 Adding the ability to specify a custom retry handler in the ribbon client configuration. 
fixes gh-931
 2016-03-31 11:36:57 -06:00
Dave Syer
5d2065b3e7 Add some javadocs to ZuulProperties 2016-03-24 12:31:51 +00:00
Spencer Gibb
892eea752b Lazily look up MetricsClientHttpRequestInterceptor in BPP. 
fixes gh-912
 2016-03-23 12:00:06 -06:00
Spencer Gibb
d8da9af29d try and fix LoadBalancerFeignClientOverrideTests 2016-03-21 18:40:39 -06:00
Spencer Gibb
d774847d00 try and fix LoadBalancerFeignClientOverrideTests 2016-03-21 18:10:12 -06:00
Spencer Gibb
5e38ae1234 polish 2016-03-21 17:54:50 -06:00
Spencer Gibb
67b6eafbf0 Use ribbon configuration for ReadTimeout & ConnectTimeout. 
Allows feign/ribbon users to use standard config files rather than creating a bean of Request.Options.

fixes gh-696
 2016-03-21 17:23:21 -06:00
Spencer Gibb
08f7076f6e Mark @FeignClient beans as primary. 
When fallback beans are created, there was no longer a unique bean of the feign interface which caused autowire problems.

fixes gh-899
 2016-03-16 17:01:45 -06:00
Spencer Gibb
b9a6876d00 Upgrade ribbon to 2.1.3 
fixes gh-908
 2016-03-16 14:36:52 -06:00
Jakub Narloch
bca86191b3 Spring Mvc RxJava integration. 
Support for Single via a ReturnValueHandler.
Support for Observable via SseEmitter.
 2016-03-14 14:14:06 -06:00
Matt Benson
a71e13ef07 Where a given String conversion is supported, register Feign Param.Expanders 
backed by a Feign-specific FormattingConversionService.
 2016-03-11 17:03:04 -07:00
Spencer Gibb
b8f11e79c6 Atlas no longer requires a RestTemplate bean. 
fixes gh-881
 2016-03-10 18:13:20 -07:00
Dave Syer
371edbf827 Prevent possible memory leak with archaius 2016-03-09 16:58:31 +00:00
Jean-Eric Cuendet
f8df337893 Verify that the stream is more than ZERO bytes before un-gzipping 
Fixes gh-891
 2016-03-09 13:47:16 +00:00
Marcin Grzejszczak
61e9d0723c Test to prove the issue 2016-03-08 14:36:37 +01:00
Dave Syer
2670890845 Whitespace 2016-03-08 08:18:38 +00:00
Spencer Gibb
a913369dd0 Upgrade feign version to 8.15.0 
fixes gh-880
 2016-03-07 14:31:44 -07:00
Spencer Gibb
eed5a6f10b Test RestTemplate with ribbon when metrics are enabled. 2016-03-07 14:08:27 -07:00
Spencer Gibb
0634c4bc37 Disabling the metrics interceptor fixes the tests. 
I'm not sure that is a good thing though.
 2016-03-07 12:30:39 -07:00
Dave Syer
8375e3b444 Adapt to changes in commons that put onus on user with @LoadBalanced 2016-03-07 18:04:10 +00:00
Spencer Gibb
790ac76a48 Change type of loadBalancerClient back LoadBalancerClient. 2016-03-04 11:21:43 -07:00
Dave Syer
5bd18e4567 Mostly whitespace 2016-03-04 14:30:11 +00:00
Dave Syer
000fee96aa Use "=" as separator in @RequestMapping(headers=...) 
Consistent with Spring MVC (and untested up to now apparently).

Fixes gh-874
 2016-03-04 09:38:31 +00:00
Dave Syer
718cafcd04 Add X-Forwarded-Port explicitly for Tomcat (and other servers) 
Fixes gh-872
 2016-03-03 11:29:30 +00:00